utxo_to_sqlite
tool while using it, this PR fixes them. More details in the commit messages.
contrib: update utxo_to_sqlite
tool documentation and comment
#31925
pull
rkrux
wants to merge
2
commits into
bitcoin:master
from
rkrux:utxo-sql
changing
1
files
+2 −2
-
rkrux commented at 11:30 am on February 21, 2025: contributorI noticed couple discrepancies in the documentation and comments of
-
contrib: update `dumptxoutset` command in utxo_to_sqlite doc
Running the `dumptxoutset` command without a `type` parameter leads to the following error. Update the tool documentation to make it easier to follow. `Invalid snapshot type "" specified. Please specify "rollback" or "latest"`
-
contrib: fix read metadata related comment
The utxo snapshot metadata doesn't seem to contain any block height as per the CPP code and no such value is read few lines down by the tool code as well. Related CPP code: bitcoin/bitcoin/blob/28.x/src/node/utxo_snapshot.h#L60-L66
-
DrahtBot commented at 11:30 am on February 21, 2025: contributor
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31925.
Reviews
See the guideline for information on the review process.
Type Reviewers ACK theStack If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
-
DrahtBot added the label Scripts and tools on Feb 21, 2025
-
rkrux marked this as ready for review on Feb 21, 2025
-
theStack approved
-
theStack commented at 11:40 am on February 21, 2025: contributor
lgtm ACK e747ed989ebb7b9650ba1478d583f7f507e1083f
Thanks for fixing the outdated comments! nit for the future: to refer code lines in the repo (second commit message body), it’s better to use permalinks, as otherwise these links get stale quickly
-
fanquake merged this on Feb 21, 2025
-
fanquake closed this on Feb 21, 2025
Labels
Scripts and tools
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-02-22 06:12 UTC
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-02-22 06:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me