I noticed couple discrepancies in the documentation and comments of utxo_to_sqlite tool while using it, this PR fixes them. More details in the commit messages.
contrib: update `utxo_to_sqlite` tool documentation and comment #31925
pull rkrux wants to merge 2 commits into bitcoin:master from rkrux:utxo-sql changing 1 files +2 −2-
rkrux commented at 11:30 AM on February 21, 2025: contributor
-
d3095ac35a
contrib: update `dumptxoutset` command in utxo_to_sqlite doc
Running the `dumptxoutset` command without a `type` parameter leads to the following error. Update the tool documentation to make it easier to follow. `Invalid snapshot type "" specified. Please specify "rollback" or "latest"`
-
e747ed989e
contrib: fix read metadata related comment
The utxo snapshot metadata doesn't seem to contain any block height as per the CPP code and no such value is read few lines down by the tool code as well. Related CPP code: bitcoin/bitcoin/blob/28.x/src/node/utxo_snapshot.h#L60-L66
-
DrahtBot commented at 11:30 AM on February 21, 2025: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31925.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK theStack If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
- DrahtBot added the label Scripts and tools on Feb 21, 2025
- rkrux marked this as ready for review on Feb 21, 2025
- theStack approved
-
theStack commented at 11:40 AM on February 21, 2025: contributor
lgtm ACK e747ed989ebb7b9650ba1478d583f7f507e1083f
Thanks for fixing the outdated comments! nit for the future: to refer code lines in the repo (second commit message body), it's better to use permalinks, as otherwise these links get stale quickly
- fanquake merged this on Feb 21, 2025
- fanquake closed this on Feb 21, 2025
- sedited referenced this in commit 2cab7a09ea on Mar 16, 2025
- stickies-v referenced this in commit d760fd3dda on Mar 17, 2025
- stickies-v referenced this in commit cc83553352 on Mar 17, 2025
- stickies-v referenced this in commit 2614933f06 on Mar 17, 2025
- stickies-v referenced this in commit b70418c5fc on Mar 17, 2025
- stickies-v referenced this in commit 69f8a1fe50 on Mar 17, 2025
- bug-castercv502 referenced this in commit a6aeab1eeb on Sep 28, 2025
- ivanlele referenced this in commit d608af520e on Apr 16, 2026
- Kino1994 referenced this in commit 97eca0fb0b on Jun 28, 2026
- BigcoinBGC referenced this in commit a57033b1c8 on Jun 30, 2026
- bitcoin locked this on Jul 30, 2026
Labels