This PR:
- Adjusts the regex for Qt-generated files to match the CMake build directory structure.
- Moves the filtering command to run before
clang-tidy
, ensuring that Qt-generated files are not needlessly processed.
Fixes #31801.
compile_commands.json
#31928
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31928.
See the guideline for information on the review process.
Type | Reviewers |
---|---|
ACK | maflcko |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
ACK d82dc1041524e8402d201d32c9143233b5ec1baf 🚂
Signature:
0untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
1RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
2trusted comment: ACK d82dc1041524e8402d201d32c9143233b5ec1baf 🚂
3VxeXCGLGGD5Mokc9xIUZQZRwrg91hsJUs6+zbThTAgoIarCrQx8s0lJ9WQaCwte6blo2y+lyqFbwQZEKXjVKAw==
post-merge ACK d82dc1041524e8402d201d32c9143233b5ec1baf
Verified that the regex adjustment successfully excludes CMake-generated files (bitcoinqt_autogen/
), as evidenced by the absence of clang-tidy
runs on these files in the updated logs.
hebasto
DrahtBot
maflcko
pablomartin4btc
Labels
Tests