This PR:
- Adjusts the regex for Qt-generated files to match the CMake build directory structure.
- Moves the filtering command to run before
clang-tidy, ensuring that Qt-generated files are not needlessly processed.
Fixes #31801.
ci: Fix filtering out Qt-generated files from `compile_commands.json` #31928
pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:250221-autogen changing 1 files +6 −4-
hebasto commented at 1:32 PM on February 21, 2025: member
-
ci: Fix filtering out Qt generated files from `compile_commands.json` d82dc10415
- hebasto added the label Tests on Feb 21, 2025
-
DrahtBot commented at 1:32 PM on February 21, 2025: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31928.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK maflcko If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
-
maflcko commented at 2:23 PM on February 21, 2025: member
ACK d82dc1041524e8402d201d32c9143233b5ec1baf 🚂
<details><summary>Show signature</summary>
Signature:
untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}" RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM= trusted comment: ACK d82dc1041524e8402d201d32c9143233b5ec1baf 🚂 VxeXCGLGGD5Mokc9xIUZQZRwrg91hsJUs6+zbThTAgoIarCrQx8s0lJ9WQaCwte6blo2y+lyqFbwQZEKXjVKAw==</details>
- fanquake merged this on Feb 21, 2025
- fanquake closed this on Feb 21, 2025
- hebasto deleted the branch on Feb 21, 2025
- pablomartin4btc approved
-
pablomartin4btc commented at 4:42 PM on February 21, 2025: member
post-merge ACK d82dc1041524e8402d201d32c9143233b5ec1baf
Verified that the regex adjustment successfully excludes CMake-generated files (
bitcoinqt_autogen/), as evidenced by the absence ofclang-tidyruns on these files in the updated logs. - sedited referenced this in commit 2cab7a09ea on Mar 16, 2025
- stickies-v referenced this in commit d760fd3dda on Mar 17, 2025
- stickies-v referenced this in commit cc83553352 on Mar 17, 2025
- stickies-v referenced this in commit 2614933f06 on Mar 17, 2025
- stickies-v referenced this in commit b70418c5fc on Mar 17, 2025
- stickies-v referenced this in commit 69f8a1fe50 on Mar 17, 2025
- bug-castercv502 referenced this in commit a6aeab1eeb on Sep 28, 2025
- ivanlele referenced this in commit 78f938415e on Apr 16, 2026
- Kino1994 referenced this in commit 47bcc2182a on Jun 28, 2026
- BigcoinBGC referenced this in commit c21615c83a on Jun 30, 2026
- bitcoin locked this on Jul 30, 2026
Contributors
Labels