qt: 29.0 translations update

hebasto commented at 11:21 pm on March 5, 2025: member

This PR follows our Release Process and concludes the translation-specific efforts for this release cycle. It follows two previous translation-related PRs, #31809 and https://github.com/bitcoin-core/gui/pull/854.

It is one of the steps required before branch-off, as scheduled in #31029.

The previous similar PR: #30715.

Notes for reviewers:

This is the first release process conducted after migrating the build system to CMake. The bitcoin-maintainer-tools/update-translations.py tool, which is used to fetch translations from Transifex.com, still generates the no-longer-needed src/Makefile.qt_locale.include file. Please ignore it.
The actual translations on Transifex is a moving target. Therefore, your diff after running bitcoin-maintainer-tools/update-translations.py might differ.

hebasto added the label GUI on Mar 5, 2025

hebasto added this to the milestone 29.0 on Mar 5, 2025

DrahtBot commented at 11:21 pm on March 5, 2025: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32004.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	pablomartin4btc

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

hebasto commented at 11:23 pm on March 5, 2025: member

cc @stickies-v @pablomartin4btc @johnny9 @jarolrod as regular reviewers of similar previous PRs.

cc @glozow as the 29.0 release manager.

Sjors commented at 10:42 am on March 7, 2025: member

I would be useful if the PR describes any major intended changes.

It adds several new languages: ast_ES, ay, or, ps, sa, sm, tn, ve, xh, yi

It almost completely drops Dutch, Czech, Danish and perhaps others (Github can barely load the diff).

It would be great if, in the future, the strings can have canonical ordering, so the XML files are easier to diff (without going to Transifex)

E.g.

0git show 5a52e0946d399fa467073c44752a5ce68b2a9008 src/qt/locale/bitcoin_de.ts

show a lot of movement, which even --color-moved=dimmed-zebra doesn’t seem able to solve for.

pablomartin4btc approved

pablomartin4btc commented at 10:45 am on March 7, 2025: member

tACK 5a52e0946d399fa467073c44752a5ce68b2a9008

Tested sync’ing master (doc) and generating the translate (doc) from both master and this PR.

No diffs.

hebasto commented at 11:45 am on March 7, 2025: member

I would be useful if the PR describes any major intended changes.

It adds several new languages: ast_ES, ay, or, ps, sa, sm, tn, ve, xh, yi

It almost completely drops Dutch, Czech, Danish and perhaps others (Github can barely load the diff).

As a PR author, I take responsibility for committing changes that are generated by the bitcoin-maintainer-tools/update-translations.py script, which in turn fetches translations from the Transifex website. When a translation file is removed, I do check whether a translation has been vandalized.

Otherwise, it is translators’ and language coordinators’ responsibility for the completeness and quality of the translations.

I’d like to reiterate my point that Transifex is poorly suited for Bitcoin Core translations, and I’m keen to use GitHub to track translation changes (as was done many years ago). This seems doable in the context of the recently discussed separation of the GUI repository.

It would be great if, in the future, the strings can have canonical ordering, so the XML files are easier to diff (without going to Transifex)

E.g.
0git show 5a52e0946d399fa467073c44752a5ce68b2a9008 src/qt/locale/bitcoin_de.ts
show a lot of movement, which even --color-moved=dimmed-zebra doesn’t seem able to solve for.

I agree.

in src/qt/locale/bitcoin_gl_ES.ts:6 in 5a52e0946d outdated

0@@ -1,6 +1,10 @@
1 <TS version="2.1" language="gl_ES">
2 <context>
3     <name>AddressBookPage</name>
4+    <message>
5+        <source>Right-click to edit address or label</source>
6+        <translation type="unfinished">cd vcpkg/buildtrees/libvpx/srccd *./configuresed -i 's/CFLAGS+=-I/CFLAGS+=-fPIC -I/g' Makefilesed -i 's/CXXFLAGS+=-I/CXXFLAGS+=-fPIC -I/g' Makefilemakecp libvpx.a $HOME/vcpkg/installed/x64-linux/lib/cd</translation>

fanquake commented at 11:50 am on March 7, 2025:

This is pulling back in the same spam from #30897.

hebasto commented at 12:09 pm on March 7, 2025:

Removed the spam on Transifex and made a fresh fetching.

fanquake changes_requested

qt: 29.0 translations update 86a28b6a33

hebasto force-pushed on Mar 7, 2025

pablomartin4btc approved

pablomartin4btc commented at 1:14 pm on March 7, 2025: member

re-ACK 86a28b6a3368acd2e6183fcfc9bbb13ee306c9fb

(no diffs - verified spam was removed from /src/qt/locale/bitcoin_gl_ES.ts)

in src/qt/locale/bitcoin_da.ts:6 in 86a28b6a33

10-        <translation type="unfinished">Opret en ny adresse</translation>
11-    </message>
12-    <message>
13-        <source>&amp;New</source>
14-        <translation type="unfinished">&amp;Ny</translation>
15+        <translation type="unfinished">  Về     Tải về     blog     phát hành     Phát triển     Liên hệ                                Tiếng Anh                                                                                                    Tiếng Tây Ban Nha                                                  Nhật Bản                                                  Tiếng Trung giản thể                                                  繁體中文                                                                            Phát hành  Bitcoin Core 28.0  Bitcoin Core 27.1  Bitcoin Core 27.0  Bitcoin Core 26.2  Bitcoin Core 26.1  Bitcoin Core 26.0  Bitcoin Core 25.2  Bitcoin Core 25.1  Bitcoin Core 25.0  Bitcoin Core 24.2  Bitcoin Core 24.1  Lõi Bitcoin 24.0.1  Bitcoin Core 23.2  Bitcoin Core 23.1  Bitcoin Core 23.0  Bitcoin Core 22.1  Bitcoin Core 22.0  Bitcoin Core 0.21.2  Bitcoin Core 0.21.1  Bitcoin Core 0.21.0  Bitcoin Core 0.20.2  Bitcoin Core 0.20.1  Bitcoin Core 0.20.0  Bitcoin Core 0.19.1  Lõi Bitcoin 0.19.0.1  Bitcoin Core 0.18.1  Bitcoin Core 0.18.0  Lõi Bitcoin 0.17.1  Lõi Bitcoin 0.17.0.1  Bitcoin Core 0.17.0  Lõi Bitcoin 0.16.3  Lõi Bitcoin 0.16.2  Lõi Bitcoin 0.16.1  Bitcoin Core 0.16.0  Bitcoin Core 0.15.2  Lõi Bitcoin 0.15.1  Lõi Bitcoin 0.15.0.1  Bitcoin Core 0.15.0  Lõi Bitcoin 0.14.3  Bitcoin Core 0.14.2  Bitcoin Core 0.14.1  Bitcoin Core 0.14.0  Bitcoin Core 0.13.2  Lõi Bitcoin 10.11.12.8333  Bitcoin Core 0.13.0  Bitcoin Core 0.12.1  Bitcoin Core 0.12.0  Bitcoin Core 0.11.2  Bitcoin Core 1010568.11.1  Bitcoin Core 10.11.0..  Twitter Pháp lý | Chính sách bảo mật | RSS   © 2024 Lõi Bitcoin</translation>

achow101 commented at 0:37 am on March 8, 2025:

This looks like spam.

in src/qt/locale/bitcoin_ps.ts:294 in 86a28b6a33

289+
290+
291+
292+
293+
294+.</translation>

achow101 commented at 0:53 am on March 8, 2025:

This seems like an excessive number of new lines, probably spam?

in src/qt/locale/bitcoin_or.ts:93 in 86a28b6a33

88+
89+
90+
91+
92+
93+</translation>

achow101 commented at 0:56 am on March 8, 2025:

Extra newlines, although google translate thinks the translation is correct. It seems like the newlines do render in the gui.

There are a number of these in this file.

in src/qt/locale/bitcoin_th.ts:1732 in 86a28b6a33

1729+    </message>
1730+    <message>
1731+        <source>Port of the proxy (e.g. 9050)</source>
1732+        <translation type="unfinished">พอร์ตของพร็อกซี (เช่น 9050)
1733+ 
1734+4o mini</translation>

achow101 commented at 0:59 am on March 8, 2025:

AI generated?

in src/qt/locale/bitcoin_th.ts:1813 in 86a28b6a33

1810+        <translation type="unfinished">เชื่อมต่อกับเครือข่าย Bitcoin ผ่านพร็อกซี SOCKS5 แยกต่างหากสำหรับบริการ Tor onion</translation>
1811+    </message>
1812+    <message>
1813+        <source>Use separate SOCKS&amp;5 proxy to reach peers via Tor onion services:</source>
1814+        <translation type="unfinished">ใช้พร็อกซี่ SOCKS5 แยกต่างหากเพื่อเชื่อมต่อกับเพื่อนผ่านบริการ Tor onion
1815+

achow101 commented at 1:00 am on March 8, 2025:

Extra newline

in src/qt/locale/bitcoin_th.ts:1970 in 86a28b6a33

1967+4o
1968+ 
1969+ 
1970+
1971+
1972+ </translation>

achow101 commented at 1:00 am on March 8, 2025:

A lot of extra newlines, and the 4o makes me think this was AI generated.

in src/qt/locale/bitcoin_th.ts:2158 in 86a28b6a33

2155+    <name>PeerTableModel</name>
2156+    <message>
2157+        <source>User Agent</source>
2158+        <extracomment>Title of Peers Table column which contains the peer's User Agent string.</extracomment>
2159+        <translation type="unfinished">ตัวแทนผู้ใช้
2160+(Pronounced: Dtua-Thaen Phu-Chai)</translation>

achow101 commented at 1:06 am on March 8, 2025:

I noticed a couple of translations have these pronunciations, is that expected according to our translation guidelines (do we have any)?

qt: 29.0 translations update #32004

Code Coverage & Benchmarks

Reviews