Docs: fix typos in documentation files #32011

wgyt commented at 2:11 AM on March 7, 2025: contributor

No description provided.

DrahtBot commented at 2:11 AM on March 7, 2025: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32011.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	jonatack, mabu44, maflcko
Stale ACK	rkrux

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

DrahtBot added the label Docs on Mar 7, 2025

in src/leveldb/README.md:52 in 01c14b3511 outdated

  48 | @@ -49,7 +49,7 @@ mkdir build
  49 |  cd build
  50 |  cmake -G "Visual Studio 15" ..
  51 |  ```
  52 | -The default default will build for x86. For 64-bit run:
  53 | +The default will build for x86. For 64-bit run:

jonatack commented at 3:03 AM on March 7, 2025:

This change is on a subtree directory and would need to be made upstream, not here. You can verify this locally by running ./test/lint/git-subtree-check.sh src/leveldb from repo root.

wgyt commented at 3:18 AM on March 7, 2025:

Thanks for sharing this, I have reverted this change.

jonatack commented at 3:45 AM on March 7, 2025:

You'll need to squash the fixup commit into the first one (see https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#squashing-commits).

wgyt commented at 3:54 AM on March 7, 2025:

OK, I have squashed the commit. :)

DrahtBot added the label CI failed on Mar 7, 2025

DrahtBot commented at 3:05 AM on March 7, 2025: contributor

🚧 At least one of the CI tasks failed. <sub>Debug: https://github.com/bitcoin/bitcoin/runs/38350828258</sub>

<details><summary>Hints</summary>

Try to run the tests locally, according to the documentation. However, a CI failure may still happen due to a number of reasons, for example:

Possibly due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.
A sanitizer issue, which can only be found by compiling with the sanitizer and running the affected test.
An intermittent issue.

Leave a comment here, if you need help tracking down a confusing failure.

</details>

jonatack commented at 3:09 AM on March 7, 2025: member

ACK 01c14b3511610c5d5c6f509aadee1836220753ac modulo failing CI (see comment below)

wgyt force-pushed on Mar 7, 2025

DrahtBot removed the label CI failed on Mar 7, 2025

rkrux commented at 1:31 PM on March 7, 2025: contributor

crACK 8ff8af1

DrahtBot requested review from jonatack on Mar 7, 2025

in contrib/signet/README.md:15 in 8ff8af1e34 outdated

  11 | @@ -12,7 +12,7 @@ Syntax: `getcoins.py [-h|--help] [-c|--cmd=<bitcoin-cli path>] [-f|--faucet=<fau
  12 |  * `--cmd` lets you customize the bitcoin-cli path. By default it will look for it in the PATH
  13 |  * `--faucet` lets you specify which faucet to use; the faucet is assumed to be compatible with https://github.com/kallewoof/bitcoin-faucet
  14 |  * `--addr` lets you specify a Signet address; by default, the address must be a bech32 address. This and `--cmd` above complement each other (i.e. you do not need `bitcoin-cli` if you use `--addr`)
  15 | -* `--password` lets you specify a faucet password; this is handy if you are in a classroom and set up your own faucet for your students; (above faucet does not limit by IP when password is enabled)
  16 | +* `--password` lets you specify a faucet password; this is handy if you are in a classroom and set up your own faucet for your students; (above faucet is not limited by IP when password is enabled)

jonatack commented at 1:14 AM on March 8, 2025:

I think the active voice makes more sense here (the original text). The faucet is doing the limiting, not the IP. Suggest dropping this change.

wgyt commented at 1:30 AM on March 8, 2025:

Thanks, I have reverted it.

jonatack commented at 1:18 AM on March 8, 2025: member

ACK, modulo the feedback below.

(Friendly suggestion: I believe you have opened multiple spelling changes recently and suggest ramping up to more valuable contributions, including reviewing other pull requests. See https://jonatack.github.io/articles for more info. Cheers.)

Docs: fix typos in documentation files 5601bab4f8

wgyt force-pushed on Mar 8, 2025

jonatack commented at 2:02 AM on March 8, 2025: member

ACK 5601bab4f8b01fdef7a54c9e397d513217ab1c1f

DrahtBot requested review from rkrux on Mar 8, 2025

mabu44 commented at 5:41 PM on March 8, 2025: none

crACK 5601bab4f8b01fdef7a54c9e397d513217ab1c1f

maflcko commented at 2:09 PM on March 9, 2025: member

lgtm ACK 5601bab4f8b01fdef7a54c9e397d513217ab1c1f

hebasto merged this on Mar 9, 2025

hebasto closed this on Mar 9, 2025

sedited referenced this in commit 2cab7a09ea on Mar 16, 2025

stickies-v referenced this in commit d760fd3dda on Mar 17, 2025

stickies-v referenced this in commit cc83553352 on Mar 17, 2025

stickies-v referenced this in commit 2614933f06 on Mar 17, 2025

stickies-v referenced this in commit b70418c5fc on Mar 17, 2025

stickies-v referenced this in commit 69f8a1fe50 on Mar 17, 2025

bug-castercv502 referenced this in commit a6aeab1eeb on Sep 28, 2025

ivanlele referenced this in commit c1f84b7e11 on Apr 16, 2026

Kino1994 referenced this in commit 61aa7bb372 on Jun 28, 2026

BigcoinBGC referenced this in commit aa0a038543 on Jun 30, 2026

bitcoin locked this on Jul 30, 2026