Improve Clarity of Commentary by Removing Redundant Word #32020

pull abguermez wants to merge 1 commits into bitcoin:master from abguermez:remove-redundant-word changing 1 files +1 −1
  1. abguermez commented at 3:19 am on March 8, 2025: none
    This PR removes a redundant word in a comment to improve clarity and readability. The change does not affect functionality but makes the documentation more precise.
  2. remove redundant word 799fd29e10
  3. DrahtBot commented at 3:19 am on March 8, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32020.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    Concept NACK jonatack, laanwj

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. jonatack commented at 3:25 am on March 8, 2025: member
    NACK, proposed change is incorrect/worse (and would need to be changed upstream, not here).
  5. DrahtBot added the label CI failed on Mar 8, 2025
  6. DrahtBot commented at 4:27 am on March 8, 2025: contributor

    🚧 At least one of the CI tasks failed. Debug: https://github.com/bitcoin/bitcoin/runs/38414279513

    Try to run the tests locally, according to the documentation. However, a CI failure may still happen due to a number of reasons, for example:

    • Possibly due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.

    • A sanitizer issue, which can only be found by compiling with the sanitizer and running the affected test.

    • An intermittent issue.

    Leave a comment here, if you need help tracking down a confusing failure.

  7. laanwj commented at 4:41 am on March 8, 2025: member

    NACK

    This is not an improvement. The double “is” looks strange but it is intentional, and works.

    Maybe inserting a comme inbetween would be a slight improvement? i don’t think it’s worth spending a lot of time on tbh.

    And yes, this needs to go upstream into the minisketch repository.

  8. laanwj closed this on Mar 8, 2025

  9. abguermez deleted the branch on Mar 8, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-03-31 09:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me