Use it for checking -fsanitize
.
This change improves the user experience when the configuration step fails due to a missing library. Now, there is no need to manually clean the CMake cache after installing the required library.
NO_CACHE_IF_FAILED
option for checking linker flags
#32027
Use it for checking `-fsanitize`.
This change improves the user experience when the configuration step
fails due to a missing library. Now, there is no need to manually clean
the CMake cache after installing the required library.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32027.
See the guideline for information on the review process.
Type | Reviewers |
---|---|
ACK | fanquake |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
This seems useful, but I’m having a hard time reproducing the issue, or something similar, on macOS, because XCode 15.2 ships with most of the sanitizers.
I can hit an earlier error:
0cmake -B build -DSANITIZERS=memory
1...
2-- Performing Test CXX_SUPPORTS__FSANITIZE_MEMORY - Failed
3CMake Error at CMakeLists.txt:362 (message):
4 Compiler did not accept requested flags.
But then I’d probably have to recompile LLVM.
Might be easier to reproduce on a linux distro, like the original example.