cmake, guix: Skip building tests in subtrees for releases #32054

1. 
   hebasto commented at 9:21 am on March 13, 2025: member

   The BUILD_TESTS variable has a broad scope, controlling:

   • Building test_bitcoin
   • Building test_bitcoin-qt
   • Building tests in subtrees, such as secp256k1 and univalue
   • Creating CTest’s tests

   However, for release builds, only the first is necessary.

   To address this, this PR introduces the new BUILD_TEST_BINARY variable, which allows building only the test_bitcoin binary without enabling other tests.

   ---

   As an alternative, an explicit list of build targets can be specified in the contrib/guix/libexec/build.sh.

2. cmake: Introduce `BUILD_TEST_BINARY` variable

   The `BUILD_TESTS` variable has a broad scope, controlling:
   - Building `test_bitcoin`
   - Building `test_bitcoin-qt`
   - Building tests in subtrees, such as `secp256k1` and `univalue`
   - Creating CTest's tests
   
   However, for release builds, only the first is necessary.
   
   To address this, the new `BUILD_TEST_BINARY` variable allows building
   only the `test_bitcoin` binary without enabling other tests.

   ebfa1192ba
3. guix: Skip building tests in subtrees 72211802e5
4. hebasto added the label Build system on Mar 13, 2025
5. 
   DrahtBot commented at 9:21 am on March 13, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32054.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   Concept NACK	fanquake

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #32250 (ci: Slim down lint image by maflcko)
   • #32247 (BIP-348 (OP_CHECKSIGFROMSTACK) (regtest only) by jamesob)
   • #32191 (Make TxGraph fuzz tests more deterministic by sipa)
   • #31802 (Add bitcoin-{node,gui} to release binaries for IPC by Sjors)
   • #30975 (ci: build multiprocess on most jobs by Sjors)
   • #25573 ([POC] guix: produce a fully -static-pie bitcoind by fanquake)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

6. hebasto renamed this:
   cmake, guix: Skip building tests in subtrees
   cmake, guix: Skip building tests in subtrees for releases
   on Mar 13, 2025
7. 
   fanquake commented at 9:36 am on March 13, 2025: member

   Concept NACK on introducing build options to control building single binaries.
8. 
   hebasto commented at 9:40 am on March 13, 2025: member

   Concept NACK on introducing build options to control building single binaries.

   Every other BUILD_* variable does exactly the same.

9. 
   hebasto commented at 9:45 am on March 13, 2025: member

   Alternatively, an explicit list of targets could be specified here:https://github.com/bitcoin/bitcoin/blob/c20a5ce106be716a503bcf615a1900ba8c635430/contrib/guix/libexec/build.sh#L247-L248
10. 
    fanquake commented at 9:45 am on March 13, 2025: member

    Sure, but I think that isn’t a great pattern, and this makes it worse. Having a BUILD_TESTS & BUILD_TEST_BINARY is awkward, and I think the motivation is poor; if you only want to build certain binaries in a Guix build, then use --target. Why does it need a new build option?
11. DrahtBot added the label Needs rebase on Apr 11, 2025
12. 
    DrahtBot commented at 1:23 pm on April 11, 2025: contributor

    🐙 This pull request conflicts with the target branch and needs rebase.
13. hebasto marked this as a draft on May 20, 2025
14. 
    DrahtBot commented at 2:02 am on August 17, 2025: contributor

    ⌛ There hasn’t been much activity lately and the patch still needs rebase. What is the status here?

    • Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
    • Is it no longer relevant? ➡️ Please close.
    • Did the author lose interest or time to work on this? ➡️ Please close it and mark it ‘Up for grabs’ with the label, so that it can be picked up in the future.
15. 
    DrahtBot commented at 4:08 am on August 17, 2025: contributor

    ⌛ There hasn’t been much activity lately and the patch still needs rebase. What is the status here?

    • Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
    • Is it no longer relevant? ➡️ Please close.
    • Did the author lose interest or time to work on this? ➡️ Please close it and mark it ‘Up for grabs’ with the label, so that it can be picked up in the future.
16. 
    maflcko commented at 11:57 am on August 28, 2025: member

    @hebasto Could close?
17. hebasto closed this on Aug 28, 2025

    ---

Contributors
hebasto DrahtBot fanquake maflcko

Labels
Build system Needs rebase