While reviewing #31457#pullrequestreview-2690077410 I noticed that cloning qa-assets takes a lot of time - shallow cloning should suffice here.
I haven't checked the other clones in this file but suggestion are welcome.
doc: shallow clone `qa-assets` #32083
pull l0rinc wants to merge 1 commits into bitcoin:master from l0rinc:l0rinc/qa-assets-fuzz-shallow-clone changing 1 files +1 −1-
l0rinc commented at 12:07 PM on March 17, 2025: contributor
-
6f9f415a4f
doc: shallow clone qa-assets
While reviewing https://github.com/bitcoin/bitcoin/pull/31457#pullrequestreview-2690077410 I noticed that cloning `qa-assets` takes a lot of time - shallow cloning should suffice here. I haven't checked the other clones in this file.
-
DrahtBot commented at 12:07 PM on March 17, 2025: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32083.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
Type Reviewers ACK maflcko If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
- DrahtBot added the label Docs on Mar 17, 2025
- l0rinc renamed this:
doc: shallow clone qa-assets
doc: shallow clone `qa-assets
on Mar 17, 2025 - l0rinc renamed this:
doc: shallow clone `qa-assets
doc: shallow clone `qa-assets`
on Mar 17, 2025 -
maflcko commented at 8:45 PM on March 17, 2025: member
lgtm ACK 6f9f415a4fa3a3c1dc87c207b0192a5ed0a91e0f
- fanquake merged this on Mar 18, 2025
- fanquake closed this on Mar 18, 2025
Labels