build: Remove bitness suffix from Windows installer

hebasto commented at 2:20 pm on March 24, 2025: member

Since support for 32-bit Windows has been dropped, the suffix is no longer necessary.

Since support for 32-bit Windows has been dropped, the suffix is no
longer necessary.

fb2b05b125

hebasto added the label Windows on Mar 24, 2025

hebasto added the label Build system on Mar 24, 2025

DrahtBot commented at 2:20 pm on March 24, 2025: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32132.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	l0rinc, hodlinator, laanwj

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

in share/setup.nsi.in:1 in fb2b05b125

0@@ -1,4 +1,4 @@
1-Name "@CLIENT_NAME@ (64-bit)"
2+Name "@CLIENT_NAME@"

l0rinc commented at 2:34 pm on March 24, 2025:

Does the message below (written 11 years ago) still make sense now that there’s no “64 bit version Windows installer”, just a “Windows installer”?

  MessageBox MB_OK|MB_ICONSTOP "Cannot install 64-bit version on a 32-bit system."

hebasto commented at 2:49 pm on March 24, 2025:

Considering the condition that triggers this message, the latter is correct. However, the condition itself may now be outdated.

This code does not affect the UX, so there’s no harm in leaving it as is for now.

l0rinc commented at 2:34 pm on March 24, 2025: contributor

utACK fb2b05b1259d3e69e6e675adfa30b429424c7625

hodlinator approved

hodlinator commented at 8:20 pm on March 24, 2025: contributor

ACK fb2b05b1259d3e69e6e675adfa30b429424c7625

We still have things like x86_64-w64-mingw32/bitcoin-94967c353ed8-win64-setup-unsigned.exe in build output, but I understand wanting to defer those until later.

laanwj commented at 1:32 pm on March 25, 2025: member

We still have things like x86_64-w64-mingw32/bitcoin-94967c353ed8-win64-setup-unsigned.exe

i don’t think this is what you mean here, win64 could definitely just be win, but for completeness’s sake: architecture tuples like x86_64-w64-mingw32 are set in stone, there’s no leeway to remove bitness where those are directly included.

laanwj approved

laanwj commented at 1:35 pm on March 25, 2025: member

ACK fb2b05b1259d3e69e6e675adfa30b429424c7625 Thought we already made this change long ago, but apparently one was missed.

hodlinator commented at 1:45 pm on March 25, 2025: contributor

i don’t think this is what you mean here, win64 could definitely just be win, but for completeness’s sake: architecture tuples like x86_64-w64-mingw32 are set in stone, there’s no leeway to remove bitness where those are directly included.

Was thinking x86_64-windows-mingw would be sufficient, and on par with x86_64-linux-gnu. What sets them in stone?

laanwj commented at 1:58 pm on March 25, 2025: member

Was thinking x86_64-windows-mingw would be sufficient, and on par with x86_64-linux-gnu. What sets them in stone?

gcc (and the mingw project itself, in this case). The idea is that every OS-architecture combination has a unique, unambiguous tuple. In practice there is some ambiguity (this is the magic config.sub deals with, to “normalize” it) but it’s not a good thing to mess with in general.

fanquake merged this on Mar 27, 2025

fanquake closed this on Mar 27, 2025

hebasto deleted the branch on Mar 27, 2025

TheCharlatan referenced this in commit a9c46ce3c3 on Apr 24, 2025

stickies-v referenced this in commit 772a33e052 on May 23, 2025

yuvicc referenced this in commit 069643f094 on Jul 6, 2025

hebasto commented at 3:11 pm on September 17, 2025: member

This needs to be elaborated in Release Notes.

When upgrading to v30.0, it appears necessary to uninstall first in order to remove the “… (64-bit)” Start Menu entries. Otherwise, they remain lingering.

hebasto added the label Needs release note on Sep 17, 2025

hodlinator commented at 6:10 pm on September 17, 2025: contributor

When upgrading to v30.0, it appears necessary to uninstall first in order to remove the “… (64-bit)” Start Menu entries. Otherwise, they remain lingering.

Can confirm, I ended up having to remove the “… (64-bit)"-entry in the list of installed programs manually through Regedit - not ideal. :\

hodlinator commented at 8:45 pm on September 17, 2025: contributor

Maybe we could amend the .NSI-script to unregister versions with the old name. I plan to take a stab at this tomorrow unless something unexpected comes up or someone else wants to pick it up.

hodlinator referenced this in commit 1a4ad0ae50 on Sep 18, 2025

hodlinator commented at 8:03 am on September 18, 2025: contributor

My testing shows #33422 does the job. I’d say we should have it in the v30 release or we should do the less risky thing and revert this PR (#32132) from v30.

luke-jr referenced this in commit ba0bd1d3a9 on Sep 19, 2025

hebasto referenced this in commit df101c97c2 on Sep 19, 2025

hebasto removed the label Needs release note on Sep 21, 2025

build: Remove bitness suffix from Windows installer #32132

Code Coverage & Benchmarks

Reviews