Grammatical typos in benchmarking.md #32163

pull olaristo109 wants to merge 3 commits into bitcoin:master from olaristo109:grammatical_typos_in_benchmarking.md changing 3 files +39 −10
  1. olaristo109 commented at 9:30 pm on March 29, 2025: none

    docs: Corrected grammatical and stylistic errors in benchmarking.md

    This commit addresses several grammatical typos and improves the clarity and readability of the benchmarking.md documentation. It also standardizes terminology

    On branch grammatical_typos_in_benchmarking.md

    Changes to be committed:

    modified: doc/benchmarking.md

  2. doc: Fix typo in release-process.md ce840d2868
  3. Fix: Handle null legacy_spkm in GetDescriptorsForLegacy and add unit test. 3f9e31190e
  4. fixed grammatical typos in doc\benchmarking.md 0a06e1b728
  5. DrahtBot commented at 9:30 pm on March 29, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32163.

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

  6. DrahtBot added the label CI failed on Mar 29, 2025
  7. DrahtBot commented at 9:41 pm on March 29, 2025: contributor

    🚧 At least one of the CI tasks failed. Debug: https://github.com/bitcoin/bitcoin/runs/39641106993

    Try to run the tests locally, according to the documentation. However, a CI failure may still happen due to a number of reasons, for example:

    • Possibly due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.

    • A sanitizer issue, which can only be found by compiling with the sanitizer and running the affected test.

    • An intermittent issue.

    Leave a comment here, if you need help tracking down a confusing failure.

  8. pinheadmz commented at 9:50 pm on March 29, 2025: member

    Typo fixes are generally not accepted from new contributors because they are a burden on regular reviewers. I encourage you to find a more significant way to contribute to this code base and open a new PR.

    See contributing and developer-notes in our docs.

  9. pinheadmz closed this on Mar 29, 2025


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-04-19 06:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me