ci: Switch to dynamic library linkage in native Windows job #32182

1. 
   hebasto commented at 9:34 am on April 1, 2025: member

   This PR significantly reduces the vcpkg binary cache size, improving CI caching performance:

   Branch	Cache Size
   master	2.6 GB
   this PR	430 MB

   Also see #31176 (comment).

2. hebasto added the label Windows on Apr 1, 2025
3. hebasto added the label Tests on Apr 1, 2025
4. 
   DrahtBot commented at 9:34 am on April 1, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32182.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	maflcko

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   No conflicts as of last run.

5. 
   maflcko commented at 9:39 am on April 1, 2025: member

   Was there a reason to use static linking in this CI here before?
6. 
   hebasto commented at 10:02 am on April 1, 2025: member

   Was there a reason to use static linking in this CI here before?

   The static linking was inherited from the Cirrus task in #28173, which, in turn, used our custom Qt build instead of the vcpkg manager.

   My guess is that, back when we were using our custom MSVC project file, static linking worked seamlessly without needing to manage DLL locations.

   Maybe @sipsorcery could provide more details.

7. 
   sipsorcery commented at 10:05 am on April 1, 2025: contributor

   The msvc build was created with static linking because that’s what the non-msvc build does. Other than that no real reason.
8. DrahtBot added the label Needs rebase on Apr 1, 2025
9. hebasto force-pushed on Apr 2, 2025
10. 
    hebasto commented at 8:34 am on April 2, 2025: member

    Rebased due to a conflict with the merged bitcoin/bitcoin#32184.
11. DrahtBot removed the label Needs rebase on Apr 2, 2025
12. ci: Switch to dynamic library linkage in native Windows job

    This change significantly reduces the vcpkg binary cache size, improving
    CI caching performance.

    7967fe5bfd
13. hebasto force-pushed on Apr 2, 2025
14. hebasto marked this as ready for review on Apr 2, 2025
15. 
    hebasto commented at 4:50 pm on April 2, 2025: member

    Rebased and undrafted.
16. 
    maflcko commented at 5:32 pm on April 2, 2025: member

    lgtm ACK 7967fe5bfd3e881353db9a4428ea913ce4ea15a5
17. fanquake merged this on Apr 3, 2025
18. fanquake closed this on Apr 3, 2025

    ---

19. hebasto deleted the branch on Apr 3, 2025

Contributors
hebasto DrahtBot maflcko sipsorcery

Labels
Windows Tests