When parsing descriptors with multiple keys (tr, wsh, sh, miniscript), we might not have all the private keys but only few of them (rest being public keys).
listdescriptors(private=true) RPC should not
fail in such scenario and instead return those partial private keys,
using public keys for the rest.
Fixes #32078
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32186.
See the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
Reviewers, this pull request conflicts with the following ones:
StringType variants in Miniscriptdescriptor::ToString() by pythcoiner)If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
🚧 At least one of the CI tasks failed. Debug: https://github.com/bitcoin/bitcoin/runs/39778817034
Try to run the tests locally, according to the documentation. However, a CI failure may still happen due to a number of reasons, for example:
Possibly due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.
A sanitizer issue, which can only be found by compiling with the sanitizer and running the affected test.
An intermittent issue.
Leave a comment here, if you need help tracking down a confusing failure.
686+ if (is_taproot && type == StringType::PRIVATE) {
687+ if (!has_internal_key) {
688+ if (subscript.empty()) {
689+ return false;
690+ }
691+ // Atleast one key should be present in any of the Taproot spending paths
Approach NACK. There is no reason why this needs to be special cased for taproot.
listdescriptors true should always return all private keys that are present in the wallet, even if not all private keys are present. That can happen in taproot branches, but it also could happen for a simple multisig.
#24361 would have fixed this. Feel free to pick it up.
When parsing descriptors with multiple keys (tr, wsh, sh, miniscript),
we might not have all the private keys but only few of them
(rest being public keys).
`listdescriptors(private=true)` RPC should not
fail in such scenario and instead return those partial private keys,
using public keys for the rest.
🚧 At least one of the CI tasks failed. Debug: https://github.com/bitcoin/bitcoin/runs/40327848658
Try to run the tests locally, according to the documentation. However, a CI failure may still happen due to a number of reasons, for example:
Possibly due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.
A sanitizer issue, which can only be found by compiling with the sanitizer and running the affected test.
An intermittent issue.
Leave a comment here, if you need help tracking down a confusing failure.
I don’t like the way this diff has turned out, seems repetitive. I will take inspiration from #24361 and spend some time figuring out how to make it work for Miniscript expressions as well. The branch name is outdated too now.
Most likely will close this and open a new PR.