depends: Fix cross-compiling on macOS #32215

pull hebasto wants to merge 2 commits into bitcoin:master from hebasto:250403-objcxx changing 1 files +5 −1
  1. hebasto commented at 2:13 pm on April 3, 2025: member

    This PR:

    1. Specifies Objective C/C++ compilers for native_qt package.
    2. Removes the -t option, which is incompatible with mv on macOS.

    Fixes #32208.

  2. hebasto added the label macOS on Apr 3, 2025
  3. hebasto added the label Build system on Apr 3, 2025
  4. DrahtBot commented at 2:13 pm on April 3, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32215.

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

    Conflicts

    No conflicts as of last run.

  5. hebasto added this to the milestone 30.0 on Apr 3, 2025
  6. depends: Specify Objective C/C++ compilers for `native_qt` package
    This change fixes cross-compilation from macOS to macOS with another
    architecture.
    690f5da15a
  7. depends: Fix `mv` command compatibility with macOS d0cce4172c
  8. in depends/packages/native_qt.mk:155 in 0ac7f18e5a outdated
    149@@ -148,5 +150,5 @@ endef
    150 
    151 define $(package)_postprocess_cmds
    152   rm -rf doc/ && \
    153-  mv -t .. translations/
    154+  mv translations/ ..
    


    laanwj commented at 2:38 pm on April 3, 2025:
    Had to look this up, but apparently the only thing -t does is to set the target directory explicitly. So mv translations/ .. is equivalent.
  9. hebasto force-pushed on Apr 3, 2025
  10. DrahtBot added the label CI failed on Apr 3, 2025
  11. DrahtBot removed the label CI failed on Apr 4, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-04-16 15:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me