DRAFT: test: enabling wallet migration functional test on windows #32219

1. 
   m3dwards commented at 2:49 pm on April 4, 2025: contributor

   WIP - Not ready for review

   Creating draft PR to test on Cirrus CI

2. 
   DrahtBot commented at 2:49 pm on April 4, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32219.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   Concept ACK	hebasto

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   No conflicts as of last run.

3. in test/get_previous_releases.py:197 in 0e63de11bb outdated

   201+    archiveHash = hasher.hexdigest()
   202 
   203-    if tarballHash not in SHA256_SUMS or SHA256_SUMS[tarballHash]['tarball'] != tarball:
   204-        if tarball in [v['tarball'] for v in SHA256_SUMS.values()]:
   205+    if archiveHash not in SHA256_SUMS or SHA256_SUMS[archiveHash]['archive'] != archive:
   206+        if archive in [v['archive'] for v in SHA256_SUMS.values()]:
   

   ---

   ---

   

   hebasto commented at 3:15 pm on April 4, 2025:

   If this switch s/tarball/archive/ is needed, maybe separate it onto its own scripted-diff to make this commit diff smaller and more reviewable?

   ---

   

   m3dwards commented at 3:27 pm on April 4, 2025:

   Thanks for the tip. As it now deals with zip files too it felt wrong to call them all tarballs.
4. 
   hebasto commented at 3:16 pm on April 4, 2025: member

   Concept ACK.
5. m3dwards force-pushed on Apr 4, 2025
6. 
   maflcko commented at 3:27 pm on April 4, 2025: member

   Creating draft PR to test on Cirrus CI

   For reference, you can also test locally (or in a VM, or in the cloud) via https://github.com/bitcoin/bitcoin/blob/master/ci/README.md#running-a-stage-locally. But I just wanted to mention it. Using the CI here is also fine.

7. 
   m3dwards commented at 3:29 pm on April 4, 2025: contributor

   For reference, you can also test locally (or in a VM, or in the cloud)

   This will probably be better in this instance as it wasn’t a good test anyway as the get_previous_releases.py script just used cached versions of the downloads rather than downloading again.

8. laanwj added the label Wallet on Apr 7, 2025
9. laanwj added the label Tests on Apr 7, 2025
10. m3dwards force-pushed on Apr 10, 2025
11. m3dwards force-pushed on Apr 10, 2025
12. test: remove building from source from get prev releases script

    Using the get_previous_releases.py script to build from source would have
    broken with the move to cmake. As there were no complaints, it is
    assumed nobody uses this functionality.

    f10e0d1883
13. test: add windows support to get previous releases script

    Needed to allow the wallet migration functional test to run under native
    windows

    05d76bc62b
14. m3dwards force-pushed on Apr 10, 2025
15. m3dwards force-pushed on Apr 10, 2025
16. DrahtBot added the label CI failed on Apr 10, 2025
17. 
    DrahtBot commented at 2:58 pm on April 10, 2025: contributor

    🚧 At least one of the CI tasks failed. Debug: https://github.com/bitcoin/bitcoin/runs/40333073167

    Try to run the tests locally, according to the documentation. However, a CI failure may still happen due to a number of reasons, for example:

    • Possibly due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.

    • A sanitizer issue, which can only be found by compiling with the sanitizer and running the affected test.

    • An intermittent issue.

    Leave a comment here, if you need help tracking down a confusing failure.

18. m3dwards force-pushed on Apr 10, 2025
19. m3dwards force-pushed on Apr 10, 2025
20. DrahtBot removed the label CI failed on Apr 10, 2025
21. ci: run get_previous_releases as part of test cross win job

    This should enable wallet_migration functional test to run on Windows

    33e1764276
22. m3dwards force-pushed on Apr 11, 2025

Contributors
m3dwards DrahtBot hebasto maflcko

Labels
Wallet Tests