fix: #32098 #32232

1. 
   gap-editor commented at 6:02 pm on April 7, 2025: none

   closes #32098

   At present, only coinbase UTXOs that have matured by block height h are eligible for coin selection. This pull request extends eligibility to include UTXOs that will mature at block height h+1.

   Given that a transaction spending such outputs would be valid and accepted into the mempool, they should be considered for selection.

   This approach aligns with the logic implemented by BDK, which appears to be the correct and intended behavior.

    0$ bitcoin-cli -regtest createwallet wallet
    1{
    2  "name": "wallet"
    3}
    4
    5$ export ADDRESS=$(bitcoin-cli -regtest -rpcwallet=wallet getnewaddress)
    6
    7$ bitcoin-cli -regtest generatetoaddress 101 $ADDRESS
    8[
    9  "467fd440d0ed89d0cad64fa64d0320968b33a32c681b6c3f5a5ed1d1c016f45a",
   10  "1b2246eaa35689710acc5d1bb2923197993233fb9186f0bd561cb546c7667ca7",
   11  ...
   12  "5d5ee44ada395ab1d978a77596ed3893be750840229e7234a85a01984057798a",
   13  "7f8a573a6824edc5342cf86e5e7c0a6ea5664305ef21808456fc98b2621b41cf"
   14]
   15$ bitcoin-cli -regtest -rpcwallet=wallet getbalance
   16- 50.00000000
   17+ 100.00000000
   

2. Update spend_tests.cpp 17b5960fab
3. Update wallet_tests.cpp b5ed6d00dd
4. Update wallet.cpp 07a4e6627a
5. Update interface_bitcoin_cli.py 7ff74ee087
6. Update interface_bitcoin_cli.py 085444abe8
7. Update interface_bitcoin_cli.py 851b8c06fa
8. Update wallet_backup.py a64832ec8b
9. Update wallet_balance.py 41754cb82d
10. Update wallet_basic.py f04423636f
11. Update wallet_coinbase_category.py 83810afb30
12. Update wallet_labels.py 342a1e5194
13. Update wallet_multiwallet.py 48c7078705
14. Update wallet_simulaterawtx.py 6f0ee823d4
15. Update wallet_txn_clone.py 29709e44c5
16. Update wallet_txn_doublespend.py 5aa1adec3f
17. Update wallet_upgradewallet.py 4eda988841
18. 
    DrahtBot commented at 6:02 pm on April 7, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32232.

    Reviews

    See the guideline for information on the review process.

    Type	Reviewers
    Concept NACK	l0rinc

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

19. 
    l0rinc commented at 6:06 pm on April 7, 2025: contributor

    @gap-editor, your commits should tell a story, to help us guide through your work. Please look at other PRs before pushing.
20. Update spend_tests.cpp bbc8a0e538
21. DrahtBot added the label CI failed on Apr 7, 2025
22. 
    DrahtBot commented at 6:32 pm on April 7, 2025: contributor

    🚧 At least one of the CI tasks failed. Debug: https://github.com/bitcoin/bitcoin/runs/40122862258

    Try to run the tests locally, according to the documentation. However, a CI failure may still happen due to a number of reasons, for example:

    • Possibly due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.

    • A sanitizer issue, which can only be found by compiling with the sanitizer and running the affected test.

    • An intermittent issue.

    Leave a comment here, if you need help tracking down a confusing failure.

23. 
    l0rinc commented at 6:35 pm on April 7, 2025: contributor

    NACK
24. 
    glozow commented at 8:16 pm on April 7, 2025: member

    duplicate of #32123
25. glozow closed this on Apr 7, 2025

    ---

Contributors
gap-editor DrahtBot l0rinc glozow

Labels
CI failed