[29.x] 29.0 final changes #32241

pull glozow wants to merge 3 commits into bitcoin:29.x from glozow:2025-04-29-final changing 8 files +291 −26

glozow commented at 3:16 pm on April 9, 2025: member

There weren’t any reports from rc2 and rc3 binaries have been up since April 2 (1 week ago).
DrahtBot commented at 3:16 pm on April 9, 2025: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32241.

Reviews

See the guideline for information on the review process.

Type Reviewers

ACK hebasto, janb84, laanwj

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
DrahtBot added the label Backport on Apr 9, 2025
glozow added this to the milestone 29.0 on Apr 9, 2025
glozow force-pushed on Apr 9, 2025
DrahtBot added the label CI failed on Apr 9, 2025
DrahtBot commented at 3:26 pm on April 9, 2025: contributor
🚧 At least one of the CI tasks failed. Debug: https://github.com/bitcoin/bitcoin/runs/40261547070

Try to run the tests locally, according to the documentation. However, a CI failure may still happen due to a number of reasons, for example:
- Possibly due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.
- A sanitizer issue, which can only be found by compiling with the sanitizer and running the affected test.
- An intermittent issue.
Leave a comment here, if you need help tracking down a confusing failure.
in doc/release-notes.md:39 in 755758c7d2 outdated
35+ 36+Compatibility 37+============== 38+ 39+Bitcoin Core is supported and extensively tested on operating systems 40+using the Linux Kernel 3.17+, macOS 11.0+, and Windows 7 and newer. Bitcoin
maflcko commented at 3:30 pm on April 9, 2025:

Looks like those are wrong? See doc/release-notes-empty-template.md for the empty template to copy-paste from

glozow commented at 3:35 pm on April 9, 2025:

Thanks! fixed
[doc] copy over Release Notes draft from wiki 50108104d7
[build] bump to 29.0 final 190e718e83
[doc] update man pages for 29.0 977db54233
glozow force-pushed on Apr 9, 2025
DrahtBot removed the label CI failed on Apr 9, 2025
hebasto approved
hebasto commented at 10:17 am on April 10, 2025: member

ACK 977db54233ef06f70cf9723b46fbcd1936c95be0.

Switching between help2man versions is a bit confusing. I assume different build machines were used.

The native Windows task in the GHA CI is still vulnerable to images that provide CMake >= 4.0. Maybe backport #32184 here?
janb84 commented at 11:00 am on April 10, 2025: contributor

ACK 977db54
DrahtBot requested review from janb84 on Apr 10, 2025
maflcko commented at 11:50 am on April 10, 2025: member

The native Windows task in the GHA CI is still vulnerable to images that provide CMake >= 4.0. Maybe backport #32184 here?

CI is passing here and this is a CI-only fix at best, so doing it for 29.1 should also be more than sufficient.
glozow commented at 3:57 pm on April 10, 2025: member

Switching between help2man versions is a bit confusing. I assume different build machines were used.

Caught me! Yes, was having issues on my mac.
laanwj approved
laanwj commented at 9:28 am on April 11, 2025: member

ACK 977db54233ef06f70cf9723b46fbcd1936c95be0

The native Windows task in the GHA CI is still vulnerable to images that provide CMake >= 4.0. Maybe backport #32184 here?

Right, but it’s not relevant to the release so let’s backport that afterwards.
in doc/release-notes.md:14 in 977db54233
10+ 11+ <https://github.com/bitcoin/bitcoin/issues> 12+ 13+To receive security and update notifications, please subscribe to: 14+ 15+ <https://bitcoincore.org/en/list/announcements/join/>
fanquake commented at 9:37 am on April 11, 2025:

We should probably drop or update this, given the link to the mailing list on https://bitcoincore.org/en/list/announcements/join/ doesn’t work (https://github.com/bitcoin-core/bitcoincore.org/issues/1095).

laanwj commented at 9:42 am on April 11, 2025:

Oh right, that mailing list is dead too. And there’s no clear path forward here, probably better to remove it for now.

On the other hand that link is in all the other release notes. We need to update the site with a notice too.

See also bitcoin-core/bitcoincore.org#1114.

fanquake commented at 3:06 pm on April 11, 2025:

Hopefully we will shortly fix this on the website side.

glozow commented at 5:05 pm on April 11, 2025:

This wasn’t removed in #32252, do we want to do it before tag?

laanwj commented at 5:27 pm on April 11, 2025:

This wasn’t removed in #32252, do we want to do it before tag?

Given how many links like this already exist, and how long release notes stick around, nah, let’s leave it. It’s better to fix it on the site.

Type	Reviewers
ACK	hebasto, janb84, laanwj

in doc/release-notes.md:135 in 977db54233

131+
132+- Passing `-debug=0` or `-debug=none` now behaves like `-nodebug`: previously set debug categories will be cleared, but subsequent `-debug` options will still be applied.
133+
134+- The default for `-rpcthreads` has been changed from 4 to 16, and the default for `-rpcworkqueue` has been changed from 16 to 64. (#31215).
135+
136+### Wallet

fanquake commented at 9:39 am on April 11, 2025:

We should make sure to drop headers with no content.

glozow commented at 5:06 pm on April 11, 2025:

Thanks for doing this in #32252, marking resolved

fanquake merged this on Apr 11, 2025
fanquake closed this on Apr 11, 2025
fanquake commented at 3:05 pm on April 11, 2025: member

Minor followup in #32252.
glozow deleted the branch on Apr 11, 2025

Contributors
glozow DrahtBot maflcko hebasto janb84 laanwj fanquake

Review Requested
janb84

Labels
Backport

Milestone
29.0

[29.x] 29.0 final changes #32241

Code Coverage & Benchmarks

Reviews