guix: Remove no longer necessary `file` package

hebasto commented at 3:24 pm on April 9, 2025: member

The file package appears to no longer be in use, unless I’ve overlooked something. However, I haven’t investigated the exact commit in which it was last used.

My Guix build:

 05beab46b8f78851e9d0bced5fa20cc3153a9ba9ae70394135c4ce144f4cc36bd  guix-build-fb86cdcb21a3/output/aarch64-linux-gnu/SHA256SUMS.part
 1dc5b3d2e5f0c6457958f91bbc8d4ee92fbafc1fe3b5242536087a89b0888fa5e  guix-build-fb86cdcb21a3/output/aarch64-linux-gnu/bitcoin-fb86cdcb21a3-aarch64-linux-gnu-debug.tar.gz
 2c71bdd07812fd52038f01ac08c8102c754474c1d0bfd3da146956b6454a524ad  guix-build-fb86cdcb21a3/output/aarch64-linux-gnu/bitcoin-fb86cdcb21a3-aarch64-linux-gnu.tar.gz
 309a24828c668019979e342a6ef8c3f3f74a87d5b7d9de80edf1a3b195758001a  guix-build-fb86cdcb21a3/output/arm-linux-gnueabihf/SHA256SUMS.part
 42bcf85c464ab269e198961f2c79947e2fdb578c87de49602c23a89ee39c39978  guix-build-fb86cdcb21a3/output/arm-linux-gnueabihf/bitcoin-fb86cdcb21a3-arm-linux-gnueabihf-debug.tar.gz
 552168cfc310d586290eef49346caae69c7cda53b2fee5b4ef0e82f51feea8eef  guix-build-fb86cdcb21a3/output/arm-linux-gnueabihf/bitcoin-fb86cdcb21a3-arm-linux-gnueabihf.tar.gz
 65f572f053df27ee9330185792b4b1f4f41936b049aa1f802d9753b56227e8835  guix-build-fb86cdcb21a3/output/arm64-apple-darwin/SHA256SUMS.part
 70fb12a109bc50baae1b9aafe17238f415d1844acbc7514747a69eae6bf07402a  guix-build-fb86cdcb21a3/output/arm64-apple-darwin/bitcoin-fb86cdcb21a3-arm64-apple-darwin-codesigning.tar.gz
 8eb75c798717b523cb99da6592d2630dd79b92cfe982341a7ed52c629573c8621  guix-build-fb86cdcb21a3/output/arm64-apple-darwin/bitcoin-fb86cdcb21a3-arm64-apple-darwin-unsigned.tar.gz
 9df9a6a4d10233f10164a72e28a0e8f8aabf83f1b16c590620480194492abbc29  guix-build-fb86cdcb21a3/output/arm64-apple-darwin/bitcoin-fb86cdcb21a3-arm64-apple-darwin-unsigned.zip
109e47a427abd568faeeb94e62763db0698304d02a14742466a01805c1b243a2e0  guix-build-fb86cdcb21a3/output/dist-archive/bitcoin-fb86cdcb21a3.tar.gz
1103db60941b33c9c8d96b19313fbf57f663f52bf5f94dd1364b8fd2164408b019  guix-build-fb86cdcb21a3/output/powerpc64-linux-gnu/SHA256SUMS.part
12570f5e188acfdde27a9bb24469c2d8952e09f9e74581c6a50566769b62f9f3ae  guix-build-fb86cdcb21a3/output/powerpc64-linux-gnu/bitcoin-fb86cdcb21a3-powerpc64-linux-gnu-debug.tar.gz
13016db817655ac205c2f4c55779893444a56636c3fee033232d7024c3b218b7c5  guix-build-fb86cdcb21a3/output/powerpc64-linux-gnu/bitcoin-fb86cdcb21a3-powerpc64-linux-gnu.tar.gz
145162f86e602bb032b1dbb0c25682870f6e0240479d91515532cdc250a3cd4f41  guix-build-fb86cdcb21a3/output/riscv64-linux-gnu/SHA256SUMS.part
1578f5ee23aabf454900226bdc3ff6b7dcdd457ee33a7559bea7632c054b93c4ba  guix-build-fb86cdcb21a3/output/riscv64-linux-gnu/bitcoin-fb86cdcb21a3-riscv64-linux-gnu-debug.tar.gz
1678c2159a1598feedddcbe7d16bbc80bd9c0f11775c6bb5c6133903bd94e94871  guix-build-fb86cdcb21a3/output/riscv64-linux-gnu/bitcoin-fb86cdcb21a3-riscv64-linux-gnu.tar.gz
172a028b109ee7dd7c01af174d06964f952d7afedc2730b793d840e4849580bf5d  guix-build-fb86cdcb21a3/output/x86_64-apple-darwin/SHA256SUMS.part
186f8f7e7f1923a2b99f3d4cc655054f151fe7c527de9d4d537dccac5958374a9b  guix-build-fb86cdcb21a3/output/x86_64-apple-darwin/bitcoin-fb86cdcb21a3-x86_64-apple-darwin-codesigning.tar.gz
194aa96b10186ae13cf6abcde77dfdcf9e42b836fffeac7974cde092ea8f63ab8b  guix-build-fb86cdcb21a3/output/x86_64-apple-darwin/bitcoin-fb86cdcb21a3-x86_64-apple-darwin-unsigned.tar.gz
2087f2dda624ad93f1b6728d75f6e150daa4c6f82f3ee3889aca4c9ba7b4268c30  guix-build-fb86cdcb21a3/output/x86_64-apple-darwin/bitcoin-fb86cdcb21a3-x86_64-apple-darwin-unsigned.zip
21e6c1fe5641e31b22a5a02f2993cee07a8a342402e2d82a5bd94750e03cd1f213  guix-build-fb86cdcb21a3/output/x86_64-linux-gnu/SHA256SUMS.part
22eaa1f79b7684896d35d281d61db2961bb637e6a0fe3b7ed04e02ad0f4ab41ffd  guix-build-fb86cdcb21a3/output/x86_64-linux-gnu/bitcoin-fb86cdcb21a3-x86_64-linux-gnu-debug.tar.gz
23a4a5050ca18366660174c0612a6b592792ef92b1b4178e9b8405ca68dce8d6b5  guix-build-fb86cdcb21a3/output/x86_64-linux-gnu/bitcoin-fb86cdcb21a3-x86_64-linux-gnu.tar.gz
244316534b1f61e371a8cd146ea7f5f27b460b0e5193308bb5c8975316c96c70d4  guix-build-fb86cdcb21a3/output/x86_64-w64-mingw32/SHA256SUMS.part
256471aa475b588cec721c71076e1aae566ce02ac3c450fc195e2ca4a576641d79  guix-build-fb86cdcb21a3/output/x86_64-w64-mingw32/bitcoin-fb86cdcb21a3-win64-codesigning.tar.gz
266b758b579eaf3b336d7631c4bc9ebfff6cff43e4f3c76cfc58e02ed2d118cfa0  guix-build-fb86cdcb21a3/output/x86_64-w64-mingw32/bitcoin-fb86cdcb21a3-win64-debug.zip
277ec781f81c0a1acefb98c07fb817dbd4e72a5da203b9e026370bd896c1ef6856  guix-build-fb86cdcb21a3/output/x86_64-w64-mingw32/bitcoin-fb86cdcb21a3-win64-setup-unsigned.exe
28ac65b6fef62d3eed7296e5de8a0f2c546bec6ade1019d842d04e79f63f4ab95c  guix-build-fb86cdcb21a3/output/x86_64-w64-mingw32/bitcoin-fb86cdcb21a3-win64-unsigned.zip

guix: Remove no longer necessary `file` package fb86cdcb21

DrahtBot commented at 3:24 pm on April 9, 2025: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32242.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	laanwj

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

DrahtBot added the label Build system on Apr 9, 2025

laanwj commented at 12:33 pm on April 10, 2025: member

i vaguely remember that file was (or is) used in the signing process for MacOS. See discussion here: #31407 (review) @achow101

achow101 commented at 3:52 pm on April 10, 2025: member

i vaguely remember that file was (or is) used in the signing process for MacOS.

Previously it was being used in the script that the Mac code signer runs locally. Since it was to be run outside of Guix, it wouldn’t have mattered anyways.

file is no longer used in that script as well.

fanquake commented at 9:55 am on April 11, 2025: member

appears to no longer be in use, unless I’ve overlooked something. However, I haven’t investigated

Can you update the commit and PR description with some information, otherwise this reads like deleting things at random and opening a PR after it “compiled”.

laanwj commented at 9:59 am on April 11, 2025: member

Since it was to be run outside of Guix, it wouldn’t have mattered anyways.

Given that it wasn’t that mac signing script, it would be good to know what the last use of file was.

hebasto commented at 12:37 pm on April 14, 2025: member

Since it was to be run outside of Guix, it wouldn’t have mattered anyways.

Given that it wasn’t that mac signing script, it would be good to know what the last use of file was.

I haven’t found any file invocations, even on the master branch when the Guix scripts were introduced. Unfortunately, downgrading my Guix installation failed for some reason, so I can’t prove my point for that commit.

… otherwise this reads like deleting things at random and opening a PR after it “compiled”.

It’s quite the opposite — it deletes random things from the build environment. The discussion in #15277 provides no justification for including this tool in the build environment in the first place.

laanwj commented at 7:06 am on April 15, 2025: member

I haven’t found any file invocations, even on the master branch when the Guix scripts were introduced. Unfortunately, downgrading my Guix installation failed for some reason, so I can’t prove my point for that commit.

Strange. i can’t remember ever seeing the utility used in our build system code either (nor think of any rationale to do so). My only guess is that it was used by autotools detection code indirectly, somehow.

i’ll try building some old release to check.

laanwj commented at 7:25 pm on April 15, 2025: member

i’ll try building some old release to check.

i managed to build the oldest guix-built release, v22.0, with this patch applied, including codesigning, and get matching hashes with guix.sigs except for MacOS. This looks like a general non-determinism issue and not related to this PR.

Conclusion: the guix build never needed file in the first place.

laanwj approved

laanwj commented at 7:26 pm on April 15, 2025: member

Test and code review ACK fb86cdcb21a3a923536df153e49fac3fd1e00707

maflcko added the label DrahtBot Guix build requested on Apr 16, 2025

guix: Remove no longer necessary file package #32242

Code Coverage & Benchmarks

Reviews

guix: Remove no longer necessary `file` package #32242