guix: Remove unused file package #32242

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:250408-guix-file changing 2 files +1 −4
  1. hebasto commented at 3:24 pm on April 9, 2025: member

    The file utility has not been required since Guix builds were introduced in #15277.

    My Guix build:

     0feeb8da87994724878ac8a62a6e9bfb9b1ece855f336327c900214d84d0a2bb9  guix-build-513e2020a9ac/output/aarch64-linux-gnu/SHA256SUMS.part
 1216b287ffbff054a14e60e14b3376acb8cd41dd224223ecd508bd46efad020ba  guix-build-513e2020a9ac/output/aarch64-linux-gnu/bitcoin-513e2020a9ac-aarch64-linux-gnu-debug.tar.gz
 23e68be5a329cbf5f389ca0dde51c1b1dd16b63ec26f42b8aa97dbd455ee3f30e  guix-build-513e2020a9ac/output/aarch64-linux-gnu/bitcoin-513e2020a9ac-aarch64-linux-gnu.tar.gz
 3da2d239a78e7ceaa944bd20d15118577daf5cb3817cde4bfe39ea014707326bd  guix-build-513e2020a9ac/output/arm-linux-gnueabihf/SHA256SUMS.part
 40c05b2ab0cd048d4b3b66b97f433895ca0258a68485d641a1c7aaec198114a59  guix-build-513e2020a9ac/output/arm-linux-gnueabihf/bitcoin-513e2020a9ac-arm-linux-gnueabihf-debug.tar.gz
 58cf7ff862c9eccfa7ebfb573674485082b5b797f0a8e9ba058156d3131b144fd  guix-build-513e2020a9ac/output/arm-linux-gnueabihf/bitcoin-513e2020a9ac-arm-linux-gnueabihf.tar.gz
 69464457cb7832b1805a25bb86cdc7c8670dd3c02333e229470d5348c587a73b8  guix-build-513e2020a9ac/output/arm64-apple-darwin/SHA256SUMS.part
 721f0b343cfd5a85f5b563e92931b254874a6dfad21eec91d40b485320ea37a27  guix-build-513e2020a9ac/output/arm64-apple-darwin/bitcoin-513e2020a9ac-arm64-apple-darwin-codesigning.tar.gz
 8e34a91173eae3b5ebb6dfa5ca39aa5bb782a2bfd30331edfa0075edda766ac7b  guix-build-513e2020a9ac/output/arm64-apple-darwin/bitcoin-513e2020a9ac-arm64-apple-darwin-unsigned.tar.gz
 96c42015d14fb82f124450498299db15147ee3d93d5192f2fa45d700db9ef0fb9  guix-build-513e2020a9ac/output/arm64-apple-darwin/bitcoin-513e2020a9ac-arm64-apple-darwin-unsigned.zip
10ddd176d8fcf325c23cb1d9c17933f651b26ce3ef13d1c4962460b3bfdb9fd7ff  guix-build-513e2020a9ac/output/dist-archive/bitcoin-513e2020a9ac.tar.gz
1192af97145e0dbeac11a49da48e567f3ee6e08c88c17aa434f10dc4ae13125a57  guix-build-513e2020a9ac/output/powerpc64-linux-gnu/SHA256SUMS.part
12fe980f2d4a6a6c567f447bd86221887ea3f9dcceb14a42e20f9cb8682ff66efe  guix-build-513e2020a9ac/output/powerpc64-linux-gnu/bitcoin-513e2020a9ac-powerpc64-linux-gnu-debug.tar.gz
1341c9f8c46acafec1c80fc1727eddeb8e0373ef06ffc221b16af82b6d61b9c49a  guix-build-513e2020a9ac/output/powerpc64-linux-gnu/bitcoin-513e2020a9ac-powerpc64-linux-gnu.tar.gz
1442051e97efd6178630c65bd398db075342d2c4722f97ec774b4e506b28f7e83b  guix-build-513e2020a9ac/output/riscv64-linux-gnu/SHA256SUMS.part
15f136a82ee58d10db1360d3aa00e695c8e4017db483fe84080e8050efe4436042  guix-build-513e2020a9ac/output/riscv64-linux-gnu/bitcoin-513e2020a9ac-riscv64-linux-gnu-debug.tar.gz
1678d23a7b622e894fa150706a5981ef0bf5ec35b93caaaafdd4aa95c76689ca14  guix-build-513e2020a9ac/output/riscv64-linux-gnu/bitcoin-513e2020a9ac-riscv64-linux-gnu.tar.gz
177faaa7151d85482a48c73416f0efc124f92fdf26ef232ec0dc9aa131661b2aa8  guix-build-513e2020a9ac/output/x86_64-apple-darwin/SHA256SUMS.part
1813b1bb0026c2441903210f13e61be6220abb75f50dd775bb0bea3bc388ed047c  guix-build-513e2020a9ac/output/x86_64-apple-darwin/bitcoin-513e2020a9ac-x86_64-apple-darwin-codesigning.tar.gz
1980296525f4c797b24e0ac9617ef1e3d4edbce638be3dee823face9554ba9f373  guix-build-513e2020a9ac/output/x86_64-apple-darwin/bitcoin-513e2020a9ac-x86_64-apple-darwin-unsigned.tar.gz
2058a2a3f7335a61c68f7023aa6e2668a958ea2a4acf241c0c9968866ca5da1a21  guix-build-513e2020a9ac/output/x86_64-apple-darwin/bitcoin-513e2020a9ac-x86_64-apple-darwin-unsigned.zip
21511e2f63b1f25e7c4309d8328cd9fa09b8b65dbcce8124334f89445f127f1fd2  guix-build-513e2020a9ac/output/x86_64-linux-gnu/SHA256SUMS.part
226458af46a7960b668651c59a2a0fef9d44c3c17489fad06f92ca2c43a60b2b23  guix-build-513e2020a9ac/output/x86_64-linux-gnu/bitcoin-513e2020a9ac-x86_64-linux-gnu-debug.tar.gz
23f259a3364bcc3a35346498fb224e061d37d30555aa263fe74bc45e701fb4c9a6  guix-build-513e2020a9ac/output/x86_64-linux-gnu/bitcoin-513e2020a9ac-x86_64-linux-gnu.tar.gz
24246ea6cb2218518c490f9a92bcd1dcb5589ed50f11b3713e4d2721990e655e39  guix-build-513e2020a9ac/output/x86_64-w64-mingw32/SHA256SUMS.part
25beb17556e14916e2af8463090c4f0787e16721961a88ef54975b61dde36d1503  guix-build-513e2020a9ac/output/x86_64-w64-mingw32/bitcoin-513e2020a9ac-win64-codesigning.tar.gz
2685a46d84c0433a50410f1929babc1b22721e8ee7853e57ec5370a072c05146dc  guix-build-513e2020a9ac/output/x86_64-w64-mingw32/bitcoin-513e2020a9ac-win64-debug.zip
27b7191d93cb1524cfd610cee6844119739b9301550b99babb0cefe10546e53445  guix-build-513e2020a9ac/output/x86_64-w64-mingw32/bitcoin-513e2020a9ac-win64-setup-unsigned.exe
28f6615296b46fd064e02fa9b4007e5d59c255595530fc91a8303e417579a7fe80  guix-build-513e2020a9ac/output/x86_64-w64-mingw32/bitcoin-513e2020a9ac-win64-unsigned.zip
  2. DrahtBot commented at 3:24 pm on April 9, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32242.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK janb84, fanquake
    Stale ACK laanwj

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  3. DrahtBot added the label Build system on Apr 9, 2025
  4. laanwj commented at 12:33 pm on April 10, 2025: member
    i vaguely remember that file was (or is) used in the signing process for MacOS. See discussion here: #31407 (review) @achow101
  5. achow101 commented at 3:52 pm on April 10, 2025: member

    i vaguely remember that file was (or is) used in the signing process for MacOS.

    Previously it was being used in the script that the Mac code signer runs locally. Since it was to be run outside of Guix, it wouldn’t have mattered anyways.

    file is no longer used in that script as well.

  6. fanquake commented at 9:55 am on April 11, 2025: member

    appears to no longer be in use, unless I’ve overlooked something. However, I haven’t investigated

    Can you update the commit and PR description with some information, otherwise this reads like deleting things at random and opening a PR after it “compiled”.

  7. laanwj commented at 9:59 am on April 11, 2025: member

    Since it was to be run outside of Guix, it wouldn’t have mattered anyways.

    Given that it wasn’t that mac signing script, it would be good to know what the last use of file was.

  8. hebasto commented at 12:37 pm on April 14, 2025: member

    Since it was to be run outside of Guix, it wouldn’t have mattered anyways.

    Given that it wasn’t that mac signing script, it would be good to know what the last use of file was.

    I haven’t found any file invocations, even on the master branch when the Guix scripts were introduced. Unfortunately, downgrading my Guix installation failed for some reason, so I can’t prove my point for that commit.

    … otherwise this reads like deleting things at random and opening a PR after it “compiled”.

    It’s quite the opposite — it deletes random things from the build environment. The discussion in #15277 provides no justification for including this tool in the build environment in the first place.

  9. laanwj commented at 7:06 am on April 15, 2025: member

    I haven’t found any file invocations, even on the master branch when the Guix scripts were introduced. Unfortunately, downgrading my Guix installation failed for some reason, so I can’t prove my point for that commit.

    Strange. i can’t remember ever seeing the utility used in our build system code either (nor think of any rationale to do so). My only guess is that it was used by autotools detection code indirectly, somehow.

    i’ll try building some old release to check.

  10. laanwj commented at 7:25 pm on April 15, 2025: member

    i’ll try building some old release to check.

    i managed to build the oldest guix-built release, v22.0, with this patch applied, including codesigning, and get matching hashes with guix.sigs except for MacOS. This looks like a general non-determinism issue and not related to this PR.

    Conclusion: the guix build never needed file in the first place.

  11. laanwj approved
  12. laanwj commented at 7:26 pm on April 15, 2025: member
    Test and code review ACK fb86cdcb21a3a923536df153e49fac3fd1e00707
  13. maflcko added the label DrahtBot Guix build requested on Apr 16, 2025
  14. fanquake commented at 9:25 am on April 17, 2025: member

    My only guess is that it was used by autotools detection code indirectly, somehow.

    Yea, file was checked-for by Autotools, but maybe non of the related checks affected our build.

    If the conclusion is that this was never used, can the PR title, commit message, and PR description be fixed to reflect that.

  15. guix: Remove unused `file` package 
    The `file` utility has not been required since Guix builds were
introduced.
    513e2020a9
  16. hebasto force-pushed on Apr 17, 2025
  17. hebasto renamed this:
    guix: Remove no longer necessary `file` package
    guix: Remove unused `file` package
    on Apr 17, 2025
  18. hebasto commented at 9:35 am on April 17, 2025: member

    My only guess is that it was used by autotools detection code indirectly, somehow.

    Yea, file was checked-for by Autotools, but maybe non of the related checks affected our build.

    If the conclusion is that this was never used, can the PR title, commit message, and PR description be fixed to reflect that.

    Thanks! Done.

  19. DrahtBot commented at 3:27 pm on April 17, 2025: contributor

    Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

    File commit e66e30c9e5383a467789574e61114b57536193b9(master) commit c39c3a275e8964f4baf724b0b0826e70578a43c0(pull/32242/merge)
    *-aarch64-linux-gnu-debug.tar.gz 3f5126d84b70783c... 740a7e40ddea9110...
    *-aarch64-linux-gnu.tar.gz 411593b935c9ac76... a60492877ec545e0...
    *-arm-linux-gnueabihf-debug.tar.gz 60b42bf0ed0b2237... 98ab7a80b6da513f...
    *-arm-linux-gnueabihf.tar.gz 4d5eabab9c461b83... 074aff420ef5bc97...
    *-arm64-apple-darwin-codesigning.tar.gz 31897e69f8889abb... cbab47f1a3918335...
    *-arm64-apple-darwin-unsigned.tar.gz f065a20b8a9d5333... 0cfaa90389a5f18f...
    *-arm64-apple-darwin-unsigned.zip 6a5c08df07cdcb3e... b0fe809fc7a1858a...
    *-powerpc64-linux-gnu-debug.tar.gz 6f3a7c13f2fd57b5... 1600f36cb4d9ad2a...
    *-powerpc64-linux-gnu.tar.gz 95b24d85c35b2991... 38ff2ef3d45facbf...
    *-riscv64-linux-gnu-debug.tar.gz 8bde3a647e526d46... a9f00daef432a794...
    *-riscv64-linux-gnu.tar.gz a03a4a13813d3c08... f75ff98bdea014fe...
    *-x86_64-apple-darwin-codesigning.tar.gz 9737a3a4c4903c0e... bfa189b797b0e527...
    *-x86_64-apple-darwin-unsigned.tar.gz 51ac777ea667631b... 62550bb4c4d9d238...
    *-x86_64-apple-darwin-unsigned.zip e128698a2058ae4b... cb58a199a28a3ebb...
    *-x86_64-linux-gnu-debug.tar.gz 8517971aaad01e88... 1b47838ba797b3d9...
    *-x86_64-linux-gnu.tar.gz d67e47e641b36c1f... 388c4dbd02e8d76a...
    *.tar.gz aa0272a88084ff0f... 64f7c8b8ff48e225...
    SHA256SUMS.part a442dd58548d1f04... 920e9bad56bc6ee9...
    guix_build.log 30b8990ea5b49b8c... f636409fd48d21fe...
    guix_build.log.diff 25d5dff1844b3c39...
  20. DrahtBot removed the label DrahtBot Guix build requested on Apr 17, 2025
  21. janb84 commented at 7:54 pm on April 23, 2025: contributor

    Code review and Tested ACK 513e202

    • Did a code review
    • Full GUIX build under nixos on macos via UTM, works ! (signatures match hebasto’s)
  22. DrahtBot requested review from laanwj on Apr 23, 2025
  23. fanquake commented at 9:52 am on April 25, 2025: member

    Guix Build:

     0feeb8da87994724878ac8a62a6e9bfb9b1ece855f336327c900214d84d0a2bb9  guix-build-513e2020a9ac/output/aarch64-linux-gnu/SHA256SUMS.part
 1216b287ffbff054a14e60e14b3376acb8cd41dd224223ecd508bd46efad020ba  guix-build-513e2020a9ac/output/aarch64-linux-gnu/bitcoin-513e2020a9ac-aarch64-linux-gnu-debug.tar.gz
 23e68be5a329cbf5f389ca0dde51c1b1dd16b63ec26f42b8aa97dbd455ee3f30e  guix-build-513e2020a9ac/output/aarch64-linux-gnu/bitcoin-513e2020a9ac-aarch64-linux-gnu.tar.gz
 3da2d239a78e7ceaa944bd20d15118577daf5cb3817cde4bfe39ea014707326bd  guix-build-513e2020a9ac/output/arm-linux-gnueabihf/SHA256SUMS.part
 40c05b2ab0cd048d4b3b66b97f433895ca0258a68485d641a1c7aaec198114a59  guix-build-513e2020a9ac/output/arm-linux-gnueabihf/bitcoin-513e2020a9ac-arm-linux-gnueabihf-debug.tar.gz
 58cf7ff862c9eccfa7ebfb573674485082b5b797f0a8e9ba058156d3131b144fd  guix-build-513e2020a9ac/output/arm-linux-gnueabihf/bitcoin-513e2020a9ac-arm-linux-gnueabihf.tar.gz
 69464457cb7832b1805a25bb86cdc7c8670dd3c02333e229470d5348c587a73b8  guix-build-513e2020a9ac/output/arm64-apple-darwin/SHA256SUMS.part
 721f0b343cfd5a85f5b563e92931b254874a6dfad21eec91d40b485320ea37a27  guix-build-513e2020a9ac/output/arm64-apple-darwin/bitcoin-513e2020a9ac-arm64-apple-darwin-codesigning.tar.gz
 8e34a91173eae3b5ebb6dfa5ca39aa5bb782a2bfd30331edfa0075edda766ac7b  guix-build-513e2020a9ac/output/arm64-apple-darwin/bitcoin-513e2020a9ac-arm64-apple-darwin-unsigned.tar.gz
 96c42015d14fb82f124450498299db15147ee3d93d5192f2fa45d700db9ef0fb9  guix-build-513e2020a9ac/output/arm64-apple-darwin/bitcoin-513e2020a9ac-arm64-apple-darwin-unsigned.zip
10ddd176d8fcf325c23cb1d9c17933f651b26ce3ef13d1c4962460b3bfdb9fd7ff  guix-build-513e2020a9ac/output/dist-archive/bitcoin-513e2020a9ac.tar.gz
1192af97145e0dbeac11a49da48e567f3ee6e08c88c17aa434f10dc4ae13125a57  guix-build-513e2020a9ac/output/powerpc64-linux-gnu/SHA256SUMS.part
12fe980f2d4a6a6c567f447bd86221887ea3f9dcceb14a42e20f9cb8682ff66efe  guix-build-513e2020a9ac/output/powerpc64-linux-gnu/bitcoin-513e2020a9ac-powerpc64-linux-gnu-debug.tar.gz
1341c9f8c46acafec1c80fc1727eddeb8e0373ef06ffc221b16af82b6d61b9c49a  guix-build-513e2020a9ac/output/powerpc64-linux-gnu/bitcoin-513e2020a9ac-powerpc64-linux-gnu.tar.gz
1442051e97efd6178630c65bd398db075342d2c4722f97ec774b4e506b28f7e83b  guix-build-513e2020a9ac/output/riscv64-linux-gnu/SHA256SUMS.part
15f136a82ee58d10db1360d3aa00e695c8e4017db483fe84080e8050efe4436042  guix-build-513e2020a9ac/output/riscv64-linux-gnu/bitcoin-513e2020a9ac-riscv64-linux-gnu-debug.tar.gz
1678d23a7b622e894fa150706a5981ef0bf5ec35b93caaaafdd4aa95c76689ca14  guix-build-513e2020a9ac/output/riscv64-linux-gnu/bitcoin-513e2020a9ac-riscv64-linux-gnu.tar.gz
177faaa7151d85482a48c73416f0efc124f92fdf26ef232ec0dc9aa131661b2aa8  guix-build-513e2020a9ac/output/x86_64-apple-darwin/SHA256SUMS.part
1813b1bb0026c2441903210f13e61be6220abb75f50dd775bb0bea3bc388ed047c  guix-build-513e2020a9ac/output/x86_64-apple-darwin/bitcoin-513e2020a9ac-x86_64-apple-darwin-codesigning.tar.gz
1980296525f4c797b24e0ac9617ef1e3d4edbce638be3dee823face9554ba9f373  guix-build-513e2020a9ac/output/x86_64-apple-darwin/bitcoin-513e2020a9ac-x86_64-apple-darwin-unsigned.tar.gz
2058a2a3f7335a61c68f7023aa6e2668a958ea2a4acf241c0c9968866ca5da1a21  guix-build-513e2020a9ac/output/x86_64-apple-darwin/bitcoin-513e2020a9ac-x86_64-apple-darwin-unsigned.zip
21511e2f63b1f25e7c4309d8328cd9fa09b8b65dbcce8124334f89445f127f1fd2  guix-build-513e2020a9ac/output/x86_64-linux-gnu/SHA256SUMS.part
226458af46a7960b668651c59a2a0fef9d44c3c17489fad06f92ca2c43a60b2b23  guix-build-513e2020a9ac/output/x86_64-linux-gnu/bitcoin-513e2020a9ac-x86_64-linux-gnu-debug.tar.gz
23f259a3364bcc3a35346498fb224e061d37d30555aa263fe74bc45e701fb4c9a6  guix-build-513e2020a9ac/output/x86_64-linux-gnu/bitcoin-513e2020a9ac-x86_64-linux-gnu.tar.gz
24246ea6cb2218518c490f9a92bcd1dcb5589ed50f11b3713e4d2721990e655e39  guix-build-513e2020a9ac/output/x86_64-w64-mingw32/SHA256SUMS.part
25beb17556e14916e2af8463090c4f0787e16721961a88ef54975b61dde36d1503  guix-build-513e2020a9ac/output/x86_64-w64-mingw32/bitcoin-513e2020a9ac-win64-codesigning.tar.gz
2685a46d84c0433a50410f1929babc1b22721e8ee7853e57ec5370a072c05146dc  guix-build-513e2020a9ac/output/x86_64-w64-mingw32/bitcoin-513e2020a9ac-win64-debug.zip
27b7191d93cb1524cfd610cee6844119739b9301550b99babb0cefe10546e53445  guix-build-513e2020a9ac/output/x86_64-w64-mingw32/bitcoin-513e2020a9ac-win64-setup-unsigned.exe
28f6615296b46fd064e02fa9b4007e5d59c255595530fc91a8303e417579a7fe80  guix-build-513e2020a9ac/output/x86_64-w64-mingw32/bitcoin-513e2020a9ac-win64-unsigned.zip
  24. fanquake approved
  25. fanquake commented at 9:53 am on April 25, 2025: member
    ACK 513e2020a9acdd366d4933780b331f97bac85597
  26. fanquake merged this on Apr 25, 2025
  27. fanquake closed this on Apr 25, 2025
  28. hebasto deleted the branch on Apr 25, 2025


hebasto DrahtBot laanwj achow101 fanquake janb84


laanwj

Labels
Build system

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-05-11 18:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me