build: `--target deploy` failure on macOS #32267

macOS 15.4 master @ 51166559808c3528f148b5c0c38cb4481e536dd8 brew installed Qt 6.9.0

cmake -B build -DBUILD_GUI=ON
cmake --build build --target deploy
[  0%] Generating bitcoin-build-info.h
[  0%] Built target generate_build_info
[  5%] Built target bitcoin_wallet
[ 13%] Built target leveldb
[ 15%] Built target bitcoin_cli
[ 15%] Built target bitcoinqt_autogen_timestamp_deps
[ 15%] Built target bitcoinqt_autogen
[ 51%] Built target bitcoinqt
[ 69%] Built target bitcoin_node
[ 69%] Built target bitcoin-qt_autogen_timestamp_deps
[ 69%] Built target bitcoin-qt_autogen
[ 71%] Built target crc32c
[ 73%] Built target minisketch
[ 73%] Built target bitcoin_clientversion
[ 75%] Built target bitcoin_consensus
[ 84%] Built target bitcoin_common
[ 86%] Built target univalue
[ 86%] Built target secp256k1_precomputed
[ 88%] Built target secp256k1
[ 92%] Built target bitcoin_crypto
[ 98%] Built target bitcoin_util
[ 98%] Built target bitcoin_zmq
[100%] Built target bitcoin-qt
[100%] Generating Bitcoin-Core.zip
+ Removing existing dist folder +
+ Copying source bundle +
+ Deploying frameworks +
Processing QtWidgets.framework ...
<snip>
libglib-2.0.0.dylib
/Library/Developer/CommandLineTools/usr/bin/install_name_tool: warning: changes being made to the file will invalidate the code signature in: dist/Bitcoin-Qt.app/Contents/Frameworks/libglib-2.0.0.dylib
/Library/Developer/CommandLineTools/usr/bin/install_name_tool: warning: changes being made to the file will invalidate the code signature in: dist/Bitcoin-Qt.app/Contents/Frameworks/libglib-2.0.0.dylib
/Library/Developer/CommandLineTools/usr/bin/install_name_tool: warning: changes being made to the file will invalidate the code signature in: dist/Bitcoin-Qt.app/Contents/Frameworks/libglib-2.0.0.dylib
Processing QtDBus.framework ...
Error: No directory at [@rpath](/bitcoin-bitcoin/contributor/rpath/)/QtDBus.framework
gmake[3]: *** [CMakeFiles/deploydir.dir/build.make:73: Bitcoin-Core.zip] Error 1
gmake[2]: *** [CMakeFiles/Makefile2:663: CMakeFiles/deploydir.dir/all] Error 2
gmake[1]: *** [CMakeFiles/Makefile2:702: CMakeFiles/deploy.dir/rule] Error 2
gmake: *** [Makefile:225: deploy] Error 2

Works fine with qt@5! MacOS 15.3.2

Works fine with qt@5!

How could this possibly work fine, given that qt@6 is required?

brew list --versions qt@5
qt@5 5.15.13_1

How could this possibly work fine, given that qt@6 is required?

Is it? I thought that qt@6 is the recommended version.

[ 98%] Building CXX object src/qt/CMakeFiles/bitcoinqt.dir/walletcontroller.cpp.o
[ 98%] Building CXX object src/qt/CMakeFiles/bitcoinqt.dir/walletframe.cpp.o
[100%] Building CXX object src/qt/CMakeFiles/bitcoinqt.dir/walletmodel.cpp.o
[100%] Building CXX object src/qt/CMakeFiles/bitcoinqt.dir/walletmodeltransaction.cpp.o
[100%] Building CXX object src/qt/CMakeFiles/bitcoinqt.dir/walletview.cpp.o
[100%] Building CXX object src/qt/CMakeFiles/bitcoinqt.dir/bitcoinqt_autogen/EWIEGA46WW/qrc_bitcoin.cpp.o
[100%] Building CXX object src/qt/CMakeFiles/bitcoinqt.dir/bitcoinqt_autogen/EJRQKI7XPS/qrc_bitcoin_locale.cpp.o
[100%] Linking CXX static library ../lib/libbitcoin_node.a
[100%] Built target bitcoin_node
[100%] Linking CXX static library ../../lib/libbitcoinqt.a
[100%] Built target bitcoinqt
[100%] Automatic MOC and UIC for target bitcoin-qt
[100%] Built target bitcoin-qt_autogen
[100%] Building CXX object src/qt/CMakeFiles/bitcoin-qt.dir/main.cpp.o
[100%] Building CXX object src/qt/CMakeFiles/bitcoin-qt.dir/bitcoin-qt_autogen/mocs_compilation.cpp.o
[100%] Building CXX object src/qt/CMakeFiles/bitcoin-qt.dir/__/init/bitcoin-qt.cpp.o
[100%] Linking CXX executable ../../bin/bitcoin-qt
[100%] Built target bitcoin-qt
[100%] Generating Bitcoin-Qt.app/Contents/MacOS/Bitcoin-Qt
-- Installing: /Users/yuvrajchhetri/Desktop/bitcoin/build/Bitcoin-Qt.app/Contents/MacOS/bin/bitcoin-qt
-- Installing: /Users/yuvrajchhetri/Desktop/bitcoin/build/Bitcoin-Qt.app/Contents/MacOS/share/man/man1/bitcoin-qt.1
[100%] Generating Bitcoin-Core.zip
+ Copying source bundle +
+ Deploying frameworks +
Processing QtWidgets.framework ...
+ Adding Qt translations +
+ Installing qt.conf +
dist/Bitcoin-Qt.app: replacing existing signature
+ Done +
[100%] Built target deploydir
[100%] Built target deploy

@i-am-yuvi

brew list --versions qt@5
qt@5 5.15.13_1

How could this possibly work fine, given that qt@6 is required?

Is it? I thought that qt@6 is the recommended version.

Are you sure you are building the recent master branch?

On my machine:

% git rev-parse HEAD
cdc32994feadf3f15df3cfac5baae36b4b011462
% brew list | grep qt
qt@5
% rm -rf build && cmake -B build -DBUILD_GUI=ON
-- The CXX compiler identification is AppleClang 16.0.0.16000026
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Setting build type to "RelWithDebInfo" as none was specified
-- Performing Test CXX_SUPPORTS__WERROR
-- Performing Test CXX_SUPPORTS__WERROR - Success
-- Performing Test CXX_SUPPORTS__G3
-- Performing Test CXX_SUPPORTS__G3 - Success
-- Performing Test LINKER_SUPPORTS__G3
-- Performing Test LINKER_SUPPORTS__G3 - Success
-- Performing Test CXX_SUPPORTS__FTRAPV
-- Performing Test CXX_SUPPORTS__FTRAPV - Success
-- Performing Test LINKER_SUPPORTS__FTRAPV
-- Performing Test LINKER_SUPPORTS__FTRAPV - Success
-- Found SQLite3: /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include (found suitable version "3.43.2", minimum required is "3.7.17")
-- Found QRencode: /usr/local/lib/libqrencode.dylib
-- Could NOT find Qt6 (missing: Qt6_DIR)
CMake Error at /usr/local/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:227 (message):
  Could NOT find Qt (missing: Qt6_DIR) (Required is at least version "6.2")
Call Stack (most recent call first):
  /usr/local/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:591 (_FPHSA_FAILURE_MESSAGE)
  cmake/module/FindQt.cmake:38 (find_package_handle_standard_args)
  CMakeLists.txt:178 (find_package)


-- Configuring incomplete, errors occurred!

Are you sure you are building the recent master branch?

Ah, now I see I was in v29.0 and it worked fine as qt@5 works in v29.0, sorry for the confusion!

brew list --versions qt@6
qt 6.7.0_1

When running on master(cdc32994feadf3f15df3cfac5baae36b4b011462) branch, I'm getting the same error:

...
Processing QtDBus.framework ...
Error: No directory at [@rpath](/bitcoin-bitcoin/contributor/rpath/)/QtDBus.framework
gmake[3]: *** [CMakeFiles/deploydir.dir/build.make:73: Bitcoin-Core.zip] Error 1
gmake[2]: *** [CMakeFiles/Makefile2:538: CMakeFiles/deploydir.dir/all] Error 2
gmake[1]: *** [CMakeFiles/Makefile2:571: CMakeFiles/deploy.dir/rule] Error 2
gmake: *** [Makefile:218: deploy] Error 2keFiles/deploy.dir/rule] Error 2
gmake: *** [Makefile:225: deploy] Error 2