I had trouble building bitcoin core the way I wanted since now more features require a flag while building. IMO it makes sense to make it a bit more prominent in the build docs how to get the needed flags.
Related issue: https://github.com/bitcoin/bitcoin/issues/32258
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32269.
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | maflcko |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
6@@ -7,8 +7,15 @@ Some notes on how to build Bitcoin Core in Unix.
7 To Build
8 ---------------------
9
10+### 1. Configuration
11+
12 ```bash
13 cmake -B build
14+```
15+Run `cmake -B build -LH` to see the full list of available options.
It doesn’t seem to be unix related, but I don’t have a different suggestion.
You could also mention something along the lines
The CMake variables have fixed default values and are not auto-detected at runtime. Any CMake build that requires values different from the defaults must explicitly set them. CMake will print a configure summary, which can be used to verify the build configuration.
However, this is also not unix specific :shrug:
I noticed that this is shown in other build docs except for the unix one…
6@@ -7,8 +7,15 @@ Some notes on how to build Bitcoin Core in Unix.
7 To Build
8 ---------------------
9
10+### 1. Configuration
doc/build*.md files (doc/build-freebsd.md, doc/build-netbsd.md, doc/build-openbsd.md, doc/build-osx.md).