torcontrol: Fix addrOnion outdated comment #32282

1. 
   eval-exec commented at 5:18 am on April 16, 2025: contributor

   m_randomize_credentials is outdated name, remove it. Ref: #32176 (review)
2. 
   DrahtBot commented at 5:18 am on April 16, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32282.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	laanwj, w0xlt, jonatack, achow101

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

3. fanquake requested review from laanwj on Apr 16, 2025
4. in src/torcontrol.cpp:407 in d8a83463f4 outdated

   403@@ -404,7 +404,6 @@ void TorController::get_socks_cb(TorControlConnection& _conn, const TorControlRe
   404     Assume(resolved.IsValid());
   405     LogDebug(BCLog::TOR, "Configuring onion proxy for %s\n", resolved.ToStringAddrPort());
   406 
   407-    // With m_randomize_credentials = true, generates unique SOCKS credentials per proxy connection (e.g., Tor).
   408     // Prevents connection correlation and enhances privacy by forcing different Tor circuits.
   

   ---

   ---

   

   laanwj commented at 8:59 am on April 16, 2025:

   This looks weird out of context. If we’re going to update this yet again, maybe something like:

   0// Add Tor as proxy for .onion addresses.
   1// Enable stream isolation to prevent connection correlation and enhance privacy, by forcing a different Tor circuit for every connection.
   2// For this to work, the IsolateSOCKSAuth flag must be enabled on SOCKSPort (which is the default, see the IsolateSOCKSAuth section of Tor's manual page).
   

   The ugly, and probably temporary URL has been bothering me.

5. laanwj renamed this:
   torcontrol: Fix addrOnion outdate comment
   torcontrol: Fix addrOnion outdated comment
   on Apr 16, 2025
6. laanwj added the label Docs on Apr 16, 2025
7. laanwj requested review from ryanofsky on Apr 16, 2025
8. torcontrol: Fix addrOnion outdate comment

   Signed-off-by: Eval EXEC <execvy@gmail.com>

   bcaa23a2b7
9. eval-exec force-pushed on Apr 16, 2025
10. laanwj approved
11. 
    laanwj commented at 2:16 pm on April 17, 2025: member

    ACK bcaa23a2b7090c355f7b048ad8cae719c23dea43
12. 
    w0xlt commented at 6:34 pm on April 17, 2025: contributor

    ACK https://github.com/bitcoin/bitcoin/pull/32282/commits/bcaa23a2b7090c355f7b048ad8cae719c23dea43
13. 
    jonatack commented at 8:02 pm on April 17, 2025: member

    ACK bcaa23a2b7090c355f7b048ad8cae719c23dea43
14. 
    achow101 commented at 10:04 pm on April 18, 2025: member

    ACK bcaa23a2b7090c355f7b048ad8cae719c23dea43
15. achow101 merged this on Apr 18, 2025
16. achow101 closed this on Apr 18, 2025

    ---

Contributors
eval-exec DrahtBot laanwj w0xlt jonatack achow101

Review Requested
ryanofsky

Labels
Docs