Due to changes in CMake 4.0, building on macOS (Intel) no longer silences warnings from Homebrew-installed packages, such as boost or libevent.
This PR adds a note to the macOS Build Guide to work around this issue.
For technical background, see the following discussions:
See: https://gitlab.kitware.com/cmake/cmake/-/merge_requests/10636.
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32289.
<!--021abf342d371248e50ceaed478a90ca-->
See the guideline for information on the review process. A summary of reviews will appear here.
144 | @@ -145,6 +145,8 @@ It is required that you have `python` and `zip` installed. 145 | 146 | ### 1. Configuration 147 | 148 | +Note: On macOS (x86_64), users with CMake ≥ 4.0 and Homebrew installed in `/usr/local` should pass `-DCMAKE_OSX_SYSROOT=macosx` or `export SDKROOT=macosx` when not building with Homebrew-provided tools.
This says it applies to users with Homebrew installed, when not building with homebrew-provided tools? What are the "tools" here? This seems vauge, and as a user reading this I probably wouldn't know if it applies to me.
This says it applies to users with Homebrew installed, when not building with homebrew-provided tools? What are the "tools" here?
For example, LLVM toolchain.
Not sure. I see this is just copied from the CMake release notes, but it doesn't really explain anything, and it's not clear what warnings that were being supressed no-longer are. Also seems like the warnings are a sideeffect of some other issues, that should probably be fixed properly, in some way.
... that should probably be fixed properly, in some way.
I haven't found a way to do it that covers all use cases, is user-friendly, and doesn't introduce excessive complexity.
... that should probably be fixed properly, in some way.
I haven't found a way to do it that covers all use cases, is user-friendly, and doesn't introduce excessive complexity.
Maybe one "solution" is not to lean only on homebrew but offer also an alternative package manager e.g. nix ? (nix is still on cmake 3.31 so not sure what will happen when they are on 4.0 )
What's the status of this? CMake 4.x has been available on macOS via brew for > 3 months, and we haven't had any issues reported. I think we could just do nothing here.
apple will support intel machines for another three years, but this is just a warning, so should be fine to leave as-is?