ci: Temporarily disable `WalletMigration` benchmark #32306

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:250418-windows-bench changing 1 files +2 −1

hebasto commented at 9:47 PM on April 18, 2025: member

The WalletMigration benchmark is currently failing on CI.

This PR temporarily disables it until the issue is resolved.

An alternative to #32302.
ci: Temporarily disable `WalletMigration` benchmark 18a035145d
hebasto added the label Wallet on Apr 18, 2025
hebasto added the label Tests on Apr 18, 2025
DrahtBot commented at 9:47 PM on April 18, 2025: contributor


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32306.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK TheCharlatan, maflcko

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #32302 (ci: Temporarily revert "Drop bench -priority-level in win cross CI" by maflcko)
- #32296 (refactor: reenable implicit-integer-sign-change check for serialize.h by l0rinc)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
in .github/workflows/ci.yml:362 in 18a035145d
```
 357 | @@ -358,7 +358,8 @@ jobs:
 358 |            ./src/univalue/unitester.exe
 359 |  
 360 |        - name: Run benchmarks
 361 | -        run: ./bin/bench_bitcoin.exe -sanity-check
 362 | +        # TODO: Fix the `WalletMigration` benchmark and re-enable it.
 363 | +        run: ./bin/bench_bitcoin.exe -sanity-check -filter='^(?!WalletMigration$).+$'
```
l0rinc commented at 7:52 AM on April 19, 2025:

Yet another alternative would be to comment out BENCHMARK(WalletMigration, benchmark::PriorityLevel::LOW); instead (so that when we fix it, we won't need to touch ci workflows again)

hebasto commented at 7:55 AM on April 19, 2025:

Will it have a broader impact beyond the CI?

l0rinc commented at 10:17 AM on April 19, 2025:

I've pushed #32309 which seems to fix the build (based on https://github.com/l0rinc/bitcoin/pull/9)
TheCharlatan approved
TheCharlatan commented at 9:33 AM on April 19, 2025: contributor

ACK 18a035145d6abb41e49711de60c4feabe3ba31e9

Hope this gets fixed properly soon though.
maflcko commented at 11:43 AM on April 19, 2025: member

lgtm ACK 18a035145d6abb41e49711de60c4feabe3ba31e9

Makes sense to temporarily disable a single known-to-fail benchmark, until it is known to work.
hebasto merged this on Apr 19, 2025
hebasto closed this on Apr 19, 2025