This PR fetches the recent translation updates from Transifex.
Closes #32295.
Notes for reviewers:
“fr_CM” and “fr_LU” have been dropped as part of phasing out of territory-specific translations.
The translations for the following languages, which appear to be the result of a mistake or an act of vandalism, have been discarded (also see #32004):
Update for Silesian (szl) has been discarded as malicious.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32352.
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | laanwj |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
Closes #32295.
However, the Polish (pl) translation still have a couple of issues:
1. String 160: Mismatch between 'S&how' and '%Wyświetl' 2. String 452: Mismatch between 'Transaction broadcast successfully! Transaction ID: %1' and 'transakcja'
Friendly ping @jesterhodl :)
Transaction broadcast successfully
Both fixed in Transifex.
Transaction broadcast successfully
Both fixed in Transifex.
Thanks! Updated and undrafted.
So I rerun the script and found some more issues and updated Transifex. v29 is not translated 100% yet from what I see, but at least the worst offenders: spam, typos, gross errors should be fixed now.
Thank you! Updated.
The erroneous format specs still remain: #32295 (comment)
Ok, for Polish there was one. I just corrected it. I’m happy to correct other languages for this sort of issue, but I’m only granted access to Polish team in Transifex. If someone grants me temporary access I can fix others and go back to being just Polish Team.
check_translations shouldn’t complain for any polish labels as of now. I ran it.
Thanks. Just for reference, the script doesn’t need to report no complaints. Sometimes it complains about perfectly fine translations. Also, it may not even be deterministic if called several times with a cleared cache.
check_translations shouldn’t complain for any polish labels as of now. I ran it.
Thanks. Just for reference, the script doesn’t need to report no complaints. Sometimes it complains about perfectly fine translations. Also, it may not even be deterministic if called several times with a cleared cache.
OK. By the way I noticed it. It complained A should be B, and then B should be A. Neither form would make it happy. I opted for something else.
Fetched the updated Polish (pl) translation. Thanks to @jesterhodl ! @maflcko’s comment has also been addressed.
I believe that any further translation improvements should be made through communication with the language coordinators, which I’m currently trying to arrange.
Going forward:
cc @stickies-v @pablomartin4btc @johnny9 as regular reviewers of similar previous PRs.
cc @fanquake as the 29.1 release manager.
Going forward:
- who do I contact if there’s an issue with source labels?
Feel free to ping me.
- do I have to do anything when I just maintain new or updated labels? eg. when I align wording across the app
Mind clarifying please?
- do I have to do anything when I just maintain new or updated labels? eg. when I align wording across the app
Mind clarifying please?
Sure. I translate lots of apps on Transifex, Weblate, etc. I routinely revisit to check for new things to update or correct existing translations based on my experience or feedback. So I update the transifex translations.
When I do this, is it sufficient and github pulls the .ts files automatically, or would it be wise to ping someone?
- do I have to do anything when I just maintain new or updated labels? eg. when I align wording across the app
Mind clarifying please?
Sure. I translate lots of apps on Transifex, Weblate, etc. I routinely revisit to check for new things to update or correct existing translations based on my experience or feedback. So I update the transifex translations.
When I do this, is it sufficient and github pulls the .ts files automatically, or would it be wise to ping someone?
Yes, that is sufficient, provided no one else has modified your translations. In that case, marking translations as reviewed might help.
UPD. However, not “automatically”, rather in pull requests like this one.
164@@ -165,19 +165,19 @@ Solo es posible firmar con direcciones de tipo "legacy".</translation>
165 </message>
166 <message>
167 <source>Warning: If you encrypt your wallet and lose your passphrase, you will <b>LOSE ALL OF YOUR BITCOINS</b>!</source>
168- <translation type="unfinished">Atención: Si cifras el monedero y pierdes la frase de contraseña, <b>¡PERDERÁS TODOS TUS BITCOINS</b>!</translation>
169+ <translation type="unfinished">Atención: Si cifras el monedero y pierdes la frase de contraseña, <b>¡PERDERÁS TODOS TUS BITCOIN</b>!</translation>
1038@@ -1039,7 +1039,7 @@ Signing is only possible with addresses of the type 'legacy'.</source>
1039 <message>
1040 <source>Creating Wallet <b>%1</b>…</source>
1041 <extracomment>Descriptive text of the create wallet progress window which indicates to the user which wallet is currently being created.</extracomment>
1042- <translation type="unfinished">Създаване на уолет 1 1%1 1</translation>
1043+ <translation type="unfinished">Създаване на уолет <b>%1</b>…</translation>
%n substitutes combined with HTML make it doubly confusing for translators.
1175@@ -1148,7 +1176,7 @@ El proceso de migración creará un respaldo del monedero antes de migrar. Este
1176 </message>
1177 <message>
1178 <source>Are you sure you wish to close the wallet <i>%1</i>?</source>
Right! At some point we should refactor entries like this to
0box.setText(tr("Are you sure you wish to close the wallet %1?").arg("<i>" + GUIUtil::HtmlEscape(wallet_model->getDisplayName()) + "</i>"));
But not for this version ofc.
630@@ -607,7 +631,7 @@ Solo es posible firmar con direcciones de tipo "legacy".</translation>
631 </message>
632 <message>
633 <source>Last received block was generated %1 ago.</source>
634- <translation type="unfinished">El último bloque recibido fue generado hace %1 horas.</translation>
635+ <translation type="unfinished">El último bloque recibido fue generado hace %1 .</translation>
ACK fc60337733a9dffaa42e08fcbff0ab24b5f679a4
i looked over the changes and did some spot checks and found nothing that looks malicious or appears out of the ordinary.
2394 <message>
2395- <source>Restore Wallet…</source>
2396- <extracomment>Name of the menu item that restores wallet from a backup file.</extracomment>
2397- <translation type="unfinished">กู้คืนวอลเล็ต…</translation>
2398+ <source>Last Send</source>
2399+ <translation type="unfinished">ส่งสุดท้าย (Song Soot Thai)</translation>