depends: Fix cross-compiling `qt` package from macOS to Windows

hebasto commented at 5:03 pm on April 26, 2025: member

Native packages cannot be used during cross-compiling. However, Qt still unconditionally tries to find them, which causes issues in some cases, such as when cross-compiling from macOS to Windows.

This PR explicitly disables this unnecessary Qt behaviour.

Fixes #32346.

Here is a full workflow on my macOS Sequoia 15.4.1 (Intel):

0% brew install make cmake ninja mingw-w64 nsis
1% gmake -C depends -j 10 HOST=x86_64-w64-mingw32
2% cmake -B build --toolchain depends/x86_64-w64-mingw32/toolchain.cmake
3% cmake --build build -j 10 -t deploy

depends: Fix cross-compiling `qt` package from macOS to Windows 35e57fbe33

hebasto added the label Build system on Apr 26, 2025

DrahtBot commented at 5:03 pm on April 26, 2025: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32357.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	shahsb, fanquake

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

hebasto commented at 8:27 pm on April 26, 2025: member

My Guix build:

 0aarch64
 18ba76371ec4b297da8d29674c7ec31a01eead8131a8e0bbf9bc7e66fb4e1adff  guix-build-35e57fbe336c/output/aarch64-linux-gnu/SHA256SUMS.part
 2d16137ebd3ca5eabb9614a6d4c322e05c43727621d1b8eca98ef4321c5964f21  guix-build-35e57fbe336c/output/aarch64-linux-gnu/bitcoin-35e57fbe336c-aarch64-linux-gnu-debug.tar.gz
 33f0078d7df0a54497a52541f2252a52d5b50737b96b83f88d8f2aecd76b54cca  guix-build-35e57fbe336c/output/aarch64-linux-gnu/bitcoin-35e57fbe336c-aarch64-linux-gnu.tar.gz
 4778792dcea8b0e82840c8b50cc103557ecd40264919ceac1cfb94d91ab1497da  guix-build-35e57fbe336c/output/arm-linux-gnueabihf/SHA256SUMS.part
 50f11238007712bb6c06c38a77b3f801dd3872c643a3fba5b94a34c416d15abb9  guix-build-35e57fbe336c/output/arm-linux-gnueabihf/bitcoin-35e57fbe336c-arm-linux-gnueabihf-debug.tar.gz
 6e4718eabc7b1b3447790ab336bfefa31fbb394f0328f662fea01f93df1259658  guix-build-35e57fbe336c/output/arm-linux-gnueabihf/bitcoin-35e57fbe336c-arm-linux-gnueabihf.tar.gz
 7838497f52bf171b39f1a9146340172457eadefaab3756ea5b00355da57a9e110  guix-build-35e57fbe336c/output/arm64-apple-darwin/SHA256SUMS.part
 81f353d89fa8b27f7ca065cc3f1cf620087a14284740d4748c99db08fe6037992  guix-build-35e57fbe336c/output/arm64-apple-darwin/bitcoin-35e57fbe336c-arm64-apple-darwin-codesigning.tar.gz
 90b4d59a5a86ff0c43b70460aa8fd09ca1af581a940e9fbfee1a5583edbb9751d  guix-build-35e57fbe336c/output/arm64-apple-darwin/bitcoin-35e57fbe336c-arm64-apple-darwin-unsigned.tar.gz
10079803a3a1b964c4c6dd274de407ab9c59979684152cabba1d85923708e8328b  guix-build-35e57fbe336c/output/arm64-apple-darwin/bitcoin-35e57fbe336c-arm64-apple-darwin-unsigned.zip
117d1fdab64ddf657f5db4ed71c4dea08e5c09964bc9f582d2feef451aa86392d3  guix-build-35e57fbe336c/output/dist-archive/bitcoin-35e57fbe336c.tar.gz
12b4eb2c619c5f927d6bf02b4102a5b13da750acf537bdef0b36bee3310a359306  guix-build-35e57fbe336c/output/powerpc64-linux-gnu/SHA256SUMS.part
13737648d611f086127243e245dd2321966300103a2af21a38cfcafc73da2ea5bb  guix-build-35e57fbe336c/output/powerpc64-linux-gnu/bitcoin-35e57fbe336c-powerpc64-linux-gnu-debug.tar.gz
14070ee5ece7647441884b4b989ed69c929378c3e8b61ab2d736204e31b3b71c76  guix-build-35e57fbe336c/output/powerpc64-linux-gnu/bitcoin-35e57fbe336c-powerpc64-linux-gnu.tar.gz
15892c9c1b27f6eba085c25775dc8a7480c14c1b4bd3228e993dc442a3e6817642  guix-build-35e57fbe336c/output/riscv64-linux-gnu/SHA256SUMS.part
1649e8e9a205604eb8ca6684e63c0cea98737d962dbe845980aff7771ccafe6eb9  guix-build-35e57fbe336c/output/riscv64-linux-gnu/bitcoin-35e57fbe336c-riscv64-linux-gnu-debug.tar.gz
17ab7e9035369edd0ca4a342badb4cb0bbc4daa91b1bbdd072565ff442ef8a40c5  guix-build-35e57fbe336c/output/riscv64-linux-gnu/bitcoin-35e57fbe336c-riscv64-linux-gnu.tar.gz
181c0824eaf67a5ca65d508458ec10aeb6d4aedb299828edc2e7b4b47947d4d3a3  guix-build-35e57fbe336c/output/x86_64-apple-darwin/SHA256SUMS.part
19e629119e5a7a425efc851eaab123d46f0781ee8d74fac6f7a3766c9fc8f627bf  guix-build-35e57fbe336c/output/x86_64-apple-darwin/bitcoin-35e57fbe336c-x86_64-apple-darwin-codesigning.tar.gz
20b0ab5e8b778e21a01626b2208d15eafa8f6661fe6118be1122d029af0cb9258b  guix-build-35e57fbe336c/output/x86_64-apple-darwin/bitcoin-35e57fbe336c-x86_64-apple-darwin-unsigned.tar.gz
21ef47a05298262b65c7298aeacc57293b83ec52383ac1df7249ad7cb94661885c  guix-build-35e57fbe336c/output/x86_64-apple-darwin/bitcoin-35e57fbe336c-x86_64-apple-darwin-unsigned.zip
225ac871577849ef8ad5a1fcfb42cb3c34d55710f49697c2bde328bab6f4a38a4e  guix-build-35e57fbe336c/output/x86_64-linux-gnu/SHA256SUMS.part
2394330b47561d09d94bd9f6fa04a92ee9be4680774ef921653fbac3762ebd1aa2  guix-build-35e57fbe336c/output/x86_64-linux-gnu/bitcoin-35e57fbe336c-x86_64-linux-gnu-debug.tar.gz
243a72d4ed6bcbece378fd15bbc11737654bcf7bb50ac09f122c2144d4d14ee2c2  guix-build-35e57fbe336c/output/x86_64-linux-gnu/bitcoin-35e57fbe336c-x86_64-linux-gnu.tar.gz
2521d8e26c11ea0e95e7a8803b2f63477dc50d5aae7072aaf5ae8f1821c70abd16  guix-build-35e57fbe336c/output/x86_64-w64-mingw32/SHA256SUMS.part
260247ee31fe4cbdfb908b4a377cebe588d560990a29cb452601c6861c30429fd9  guix-build-35e57fbe336c/output/x86_64-w64-mingw32/bitcoin-35e57fbe336c-win64-codesigning.tar.gz
27bf3afc049b32e02aea1f238f09637c6b6d6614831fba7c78eea83b4b277b13e6  guix-build-35e57fbe336c/output/x86_64-w64-mingw32/bitcoin-35e57fbe336c-win64-debug.zip
28ebb562ea6b50dd0be97c175d3a0181cb1846cf44d00f622e058268df132a8d1b  guix-build-35e57fbe336c/output/x86_64-w64-mingw32/bitcoin-35e57fbe336c-win64-setup-unsigned.exe
29807d62370d2d8bb2771c2227f48300852459b9a313b49b9538018c6176817e51  guix-build-35e57fbe336c/output/x86_64-w64-mingw32/bitcoin-35e57fbe336c-win64-unsigned.zip

maflcko added the label DrahtBot Guix build requested on Apr 27, 2025

DrahtBot commented at 3:17 am on April 28, 2025: contributor

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

File	commit d2ac748e9e7a92503af1729f2397778979cdd240(master)	commit 15a7734682e91413ac1804fea0fbc0d76f57c781(pull/32357/merge)
*-aarch64-linux-gnu-debug.tar.gz	`a4024080f4ba963e...`	`55dfecc3220b4beb...`
*-aarch64-linux-gnu.tar.gz	`8be9fd8388335ba2...`	`6e5f5ff2ea430b9f...`
*-arm-linux-gnueabihf-debug.tar.gz	`57393ea8c1f3a173...`	`0e5731ed44539ec9...`
*-arm-linux-gnueabihf.tar.gz	`6cb5593d00e733df...`	`c97388b4c7b0b904...`
*-arm64-apple-darwin-codesigning.tar.gz	`7d4543658956be9b...`	`f8fbfced6f202eda...`
*-arm64-apple-darwin-unsigned.tar.gz	`3d7113bc9088e762...`	`feabcae9d7e28bb1...`
*-arm64-apple-darwin-unsigned.zip	`57a42d408a6c3029...`	`e6a0e6d5a37778d5...`
*-powerpc64-linux-gnu-debug.tar.gz	`aa786716689e0718...`	`7d0cb17471de1c12...`
*-powerpc64-linux-gnu.tar.gz	`48a3ec6f850df791...`	`a41ae5ac495bf0fb...`
*-riscv64-linux-gnu-debug.tar.gz	`030497333c0f1443...`	`f8733daa1903676d...`
*-riscv64-linux-gnu.tar.gz	`041e06b86ee3aaec...`	`f22a067646679141...`
*-x86_64-apple-darwin-codesigning.tar.gz	`cb0497a73f5c3914...`	`e734d640bc8db35d...`
*-x86_64-apple-darwin-unsigned.tar.gz	`7d06b35395a61cad...`	`6b2cc313bd9dbf19...`
*-x86_64-apple-darwin-unsigned.zip	`aefc94a3ce795ac3...`	`6618f6320dcd96ce...`
*-x86_64-linux-gnu-debug.tar.gz	`afbdbb52442172fa...`	`ad45a3ade80268a6...`
*-x86_64-linux-gnu.tar.gz	`8e04bd7386918c2a...`	`1fb16223dd38cbd1...`
*.tar.gz	`d6c1b8ffc8328d76...`	`de30a8ffba15890d...`
SHA256SUMS.part	`df8d088495bd4a48...`	`0d70fcc5b46322a9...`
guix_build.log	`ffe66eccb5ab0f27...`	`35c33bf657017995...`
guix_build.log.diff		`2777295b6ef63004...`

DrahtBot removed the label DrahtBot Guix build requested on Apr 28, 2025

bitcoin deleted a comment on Apr 28, 2025

shahsb commented at 10:48 am on April 28, 2025: none

ACK https://github.com/bitcoin/bitcoin/pull/32357/commits/35e57fbe336cdcb348ff088fc04216f1f5cf2742

fanquake commented at 3:07 pm on April 28, 2025: member

Guix Build:

 08ba76371ec4b297da8d29674c7ec31a01eead8131a8e0bbf9bc7e66fb4e1adff  guix-build-35e57fbe336c/output/aarch64-linux-gnu/SHA256SUMS.part
 1d16137ebd3ca5eabb9614a6d4c322e05c43727621d1b8eca98ef4321c5964f21  guix-build-35e57fbe336c/output/aarch64-linux-gnu/bitcoin-35e57fbe336c-aarch64-linux-gnu-debug.tar.gz
 23f0078d7df0a54497a52541f2252a52d5b50737b96b83f88d8f2aecd76b54cca  guix-build-35e57fbe336c/output/aarch64-linux-gnu/bitcoin-35e57fbe336c-aarch64-linux-gnu.tar.gz
 3778792dcea8b0e82840c8b50cc103557ecd40264919ceac1cfb94d91ab1497da  guix-build-35e57fbe336c/output/arm-linux-gnueabihf/SHA256SUMS.part
 40f11238007712bb6c06c38a77b3f801dd3872c643a3fba5b94a34c416d15abb9  guix-build-35e57fbe336c/output/arm-linux-gnueabihf/bitcoin-35e57fbe336c-arm-linux-gnueabihf-debug.tar.gz
 5e4718eabc7b1b3447790ab336bfefa31fbb394f0328f662fea01f93df1259658  guix-build-35e57fbe336c/output/arm-linux-gnueabihf/bitcoin-35e57fbe336c-arm-linux-gnueabihf.tar.gz
 6838497f52bf171b39f1a9146340172457eadefaab3756ea5b00355da57a9e110  guix-build-35e57fbe336c/output/arm64-apple-darwin/SHA256SUMS.part
 71f353d89fa8b27f7ca065cc3f1cf620087a14284740d4748c99db08fe6037992  guix-build-35e57fbe336c/output/arm64-apple-darwin/bitcoin-35e57fbe336c-arm64-apple-darwin-codesigning.tar.gz
 80b4d59a5a86ff0c43b70460aa8fd09ca1af581a940e9fbfee1a5583edbb9751d  guix-build-35e57fbe336c/output/arm64-apple-darwin/bitcoin-35e57fbe336c-arm64-apple-darwin-unsigned.tar.gz
 9079803a3a1b964c4c6dd274de407ab9c59979684152cabba1d85923708e8328b  guix-build-35e57fbe336c/output/arm64-apple-darwin/bitcoin-35e57fbe336c-arm64-apple-darwin-unsigned.zip
107d1fdab64ddf657f5db4ed71c4dea08e5c09964bc9f582d2feef451aa86392d3  guix-build-35e57fbe336c/output/dist-archive/bitcoin-35e57fbe336c.tar.gz
11b4eb2c619c5f927d6bf02b4102a5b13da750acf537bdef0b36bee3310a359306  guix-build-35e57fbe336c/output/powerpc64-linux-gnu/SHA256SUMS.part
12737648d611f086127243e245dd2321966300103a2af21a38cfcafc73da2ea5bb  guix-build-35e57fbe336c/output/powerpc64-linux-gnu/bitcoin-35e57fbe336c-powerpc64-linux-gnu-debug.tar.gz
13070ee5ece7647441884b4b989ed69c929378c3e8b61ab2d736204e31b3b71c76  guix-build-35e57fbe336c/output/powerpc64-linux-gnu/bitcoin-35e57fbe336c-powerpc64-linux-gnu.tar.gz
14892c9c1b27f6eba085c25775dc8a7480c14c1b4bd3228e993dc442a3e6817642  guix-build-35e57fbe336c/output/riscv64-linux-gnu/SHA256SUMS.part
1549e8e9a205604eb8ca6684e63c0cea98737d962dbe845980aff7771ccafe6eb9  guix-build-35e57fbe336c/output/riscv64-linux-gnu/bitcoin-35e57fbe336c-riscv64-linux-gnu-debug.tar.gz
16ab7e9035369edd0ca4a342badb4cb0bbc4daa91b1bbdd072565ff442ef8a40c5  guix-build-35e57fbe336c/output/riscv64-linux-gnu/bitcoin-35e57fbe336c-riscv64-linux-gnu.tar.gz
171c0824eaf67a5ca65d508458ec10aeb6d4aedb299828edc2e7b4b47947d4d3a3  guix-build-35e57fbe336c/output/x86_64-apple-darwin/SHA256SUMS.part
18e629119e5a7a425efc851eaab123d46f0781ee8d74fac6f7a3766c9fc8f627bf  guix-build-35e57fbe336c/output/x86_64-apple-darwin/bitcoin-35e57fbe336c-x86_64-apple-darwin-codesigning.tar.gz
19b0ab5e8b778e21a01626b2208d15eafa8f6661fe6118be1122d029af0cb9258b  guix-build-35e57fbe336c/output/x86_64-apple-darwin/bitcoin-35e57fbe336c-x86_64-apple-darwin-unsigned.tar.gz
20ef47a05298262b65c7298aeacc57293b83ec52383ac1df7249ad7cb94661885c  guix-build-35e57fbe336c/output/x86_64-apple-darwin/bitcoin-35e57fbe336c-x86_64-apple-darwin-unsigned.zip
215ac871577849ef8ad5a1fcfb42cb3c34d55710f49697c2bde328bab6f4a38a4e  guix-build-35e57fbe336c/output/x86_64-linux-gnu/SHA256SUMS.part
2294330b47561d09d94bd9f6fa04a92ee9be4680774ef921653fbac3762ebd1aa2  guix-build-35e57fbe336c/output/x86_64-linux-gnu/bitcoin-35e57fbe336c-x86_64-linux-gnu-debug.tar.gz
233a72d4ed6bcbece378fd15bbc11737654bcf7bb50ac09f122c2144d4d14ee2c2  guix-build-35e57fbe336c/output/x86_64-linux-gnu/bitcoin-35e57fbe336c-x86_64-linux-gnu.tar.gz
2421d8e26c11ea0e95e7a8803b2f63477dc50d5aae7072aaf5ae8f1821c70abd16  guix-build-35e57fbe336c/output/x86_64-w64-mingw32/SHA256SUMS.part
250247ee31fe4cbdfb908b4a377cebe588d560990a29cb452601c6861c30429fd9  guix-build-35e57fbe336c/output/x86_64-w64-mingw32/bitcoin-35e57fbe336c-win64-codesigning.tar.gz
26bf3afc049b32e02aea1f238f09637c6b6d6614831fba7c78eea83b4b277b13e6  guix-build-35e57fbe336c/output/x86_64-w64-mingw32/bitcoin-35e57fbe336c-win64-debug.zip
27ebb562ea6b50dd0be97c175d3a0181cb1846cf44d00f622e058268df132a8d1b  guix-build-35e57fbe336c/output/x86_64-w64-mingw32/bitcoin-35e57fbe336c-win64-setup-unsigned.exe
28807d62370d2d8bb2771c2227f48300852459b9a313b49b9538018c6176817e51  guix-build-35e57fbe336c/output/x86_64-w64-mingw32/bitcoin-35e57fbe336c-win64-unsigned.zip

fanquake approved

fanquake commented at 3:14 pm on April 28, 2025: member

ACK 35e57fbe336cdcb348ff088fc04216f1f5cf2742

fanquake merged this on Apr 28, 2025

fanquake closed this on Apr 28, 2025

hebasto deleted the branch on Apr 28, 2025

depends: Fix cross-compiling qt package from macOS to Windows #32357

Code Coverage & Benchmarks

Reviews

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

depends: Fix cross-compiling `qt` package from macOS to Windows #32357