test: Use the correct node for doubled keypath test #32369

pull achow101 wants to merge 1 commits into bitcoin:master from achow101:fix-double-keypath-test changing 1 files +1 −1
  1. achow101 commented at 9:56 pm on April 28, 2025: member
    #29124 had a silent merge conflict with #32350 which resulted in it using the wrong node. Fix the test to use the correct v22 node.
  2. test: Use the correct node for doubled keypath test 32d55e28af
  3. DrahtBot commented at 9:56 pm on April 28, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32369.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK maflcko, rkrux, BrandonOdiwuor

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. DrahtBot added the label Tests on Apr 28, 2025
  5. maflcko commented at 5:40 am on April 29, 2025: member

    lgtm ACK 32d55e28af69ef09094ba921289bf4d1ad79905a

    I saw the silent merge conflict in the two pulls and wanted to mention it as soon as one gets merged, but it looks like both got merged at the same time.

  6. maflcko added this to the milestone 30.0 on Apr 29, 2025
  7. maflcko added the label Bug on Apr 29, 2025
  8. maflcko assigned fanquake on Apr 29, 2025
  9. maflcko assigned hebasto on Apr 29, 2025
  10. rkrux approved
  11. rkrux commented at 6:35 am on April 29, 2025: contributor

    ACK 32d55e28af69ef09094ba921289bf4d1ad79905a

    Ah, I did message on IRC yesterday to get #29124 merged because I realised there’d be conflicts when I was reviewing #32350. Looks like the latter got merged first.

    Idk why the bot didn’t add the “Needs rebase” tag on #29124 when the other got merged, I can see a gap of around an hour between the two merges. I’m sensing the CI runs tests after merges that takes some time for the bot to update open PRs with the required tags.

    A silent merge conflict makes sense to me now.

  12. BrandonOdiwuor commented at 8:20 am on April 29, 2025: contributor

    Code Review ACK 32d55e28af69ef09094ba921289bf4d1ad79905a

    Confirmed that node 5(8-3) with the correct configs for v22.0 is being used https://github.com/bitcoin/bitcoin/blob/65714c162c169cee7d95cf1fb2a9decfa8f9f9ad/test/functional/wallet_backwards_compatibility.py#L42

  13. fanquake merged this on Apr 29, 2025
  14. fanquake closed this on Apr 29, 2025

  15. glozow commented at 1:50 pm on April 29, 2025: member
    My bad for not running this test, thanks @achow101!

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-05-05 12:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me