- harmonize function with GUIUtil::getOpenFileName()
- also make PNG Image singular (grammar)
[Qt] remove GUIUtil::getSaveFileName() default arguments #3238
pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:guiutil changing 5 files +9 −10-
Diapolo commented at 9:59 PM on November 11, 2013: none
-
4f7d496b82
[Qt] remove GUIUtil::getSaveFileName() default arguments
- harmonize function with GUIUtil::getOpenFileName() - also make PNG Image singular (grammar)
-
BitcoinPullTester commented at 10:17 PM on November 11, 2013: none
Automatic sanity-testing: FAILED BUILD/TEST, see http://jenkins.bluematt.me/pull-tester/4f7d496b82210bf3235c1f8b41bfa821bfbfc54f for binaries and test log.
This could happen for one of several reasons:
- It chanages paths in makefile.linux-mingw or otherwise changes build scripts in a way that made them incompatible with the automated testing scripts (please tweak those patches in qa/pull-tester)
- It adds/modifies tests which test network rules (thanks for doing that), which conflicts with a patch applied at test time
- It does not build on either Linux i386 or Win32 (via MinGW cross compile)
- The test suite fails on either Linux i386 or Win32
- The block test-cases failed (lookup the first bNN identifier which failed in https://github.com/TheBlueMatt/test-scripts/blob/master/FullBlockTestGenerator.java)
If you believe this to be in error, please ping BlueMatt on freenode or TheBlueMatt here.
This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
-
Diapolo commented at 10:24 PM on November 11, 2013: none
Seems unrelated:
<pre> tail: write error: Broken pipe tail: write error </pre>
-
Diapolo commented at 7:18 AM on November 12, 2013: none
@TheBlueMatt Can you take a look?
-
laanwj commented at 7:50 AM on November 12, 2013: member
Just curious: why not add a default arguments to getOpenFileName, that'd be a smaller change?
-
Diapolo commented at 7:53 AM on November 12, 2013: none
IMHO it's too easy to rely on default args, so I thought removing them would be better here.
-
laanwj commented at 8:37 AM on November 12, 2013: member
Meh, the default arguments also don't really make sense (why would you want to provide empty messages), except for the final output argument.
- laanwj referenced this in commit abf34606c0 on Nov 12, 2013
- laanwj merged this on Nov 12, 2013
- laanwj closed this on Nov 12, 2013
- Diapolo deleted the branch on Nov 12, 2013
- Bushstar referenced this in commit 7331d4edda on Apr 8, 2020
- DrahtBot locked this on Sep 8, 2021