Musig2 fields followups #32412

pull rkrux wants to merge 2 commits into bitcoin:master from rkrux:musig2-fields changing 2 files +6 −6
  1. rkrux commented at 8:59 AM on May 3, 2025: contributor

    <!-- *** Please remove the following help text before submitting: *** Pull requests without a rationale and clear improvement may be closed immediately. GUI-related pull requests should be opened against https://github.com/bitcoin-core/gui first. See CONTRIBUTING.md -->

    <!-- Please provide clear motivation for your patch and explain how it improves Bitcoin Core user experience or Bitcoin Core developer experience significantly: * Any test improvements or new tests that improve coverage are always welcome. * All other changes should have accompanying unit tests (see `src/test/`) or functional tests (see `test/`). Contributors should note which tests cover modified code. If no tests exist for a region of modified code, new tests should accompany the change. * Bug fixes are most welcome when they come with steps to reproduce or an explanation of the potential issue as well as reasoning for the way the bug was fixed. * Features are welcome, but might be rejected due to design or scope issues. If a feature is based on a lot of dependencies, contributors should first consider building the system outside of Bitcoin Core, if possible. * Refactoring changes are only accepted if they are required for a feature or bug fix or otherwise improve developer experience significantly. For example, most "code style" refactoring changes require a thorough explanation why they are useful, what downsides they have and why they *significantly* improve developer experience or avoid serious programming bugs. Note that code style is often a subjective matter. Unless they are explicitly mentioned to be preferred in the [developer notes](/doc/developer-notes.md), stylistic code changes are usually rejected. -->

    <!-- Bitcoin Core has a thorough review process and even the most trivial change needs to pass a lot of eyes and requires non-zero or even substantial time effort to review. There is a huge lack of active reviewers on the project, so patches often sit for a long time. -->

  2. psbt: improve musig2 partial sig & pubnonce key size check formatting
    Follow up from MuSig2 Fields PR - #31247
    Ref: https://github.com/bitcoin/bitcoin/pull/31247#discussion_r2050497355
    7ca186c510
  3. psbt: update invalid psbt error messages in functional test vectors
    The error messages related to Musig2 pubnonce & partial sig key sizes
    are updated to match the full error message so that there is more
    stringent error checking.
    
    The test passed earlier because `assert_raises_rpc_error` function in
    the functional tests checks for susbstring of the error messages as well.
    
    Follow up from previous PR #31247.
    Ref: https://github.com/bitcoin/bitcoin/pull/31247#discussion_r2050692514
    10fd2aeb62
  4. DrahtBot commented at 8:59 AM on May 3, 2025: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32412.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK theStack

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  5. theStack approved
  6. theStack commented at 1:47 PM on May 23, 2025: contributor

    ACK 10fd2aeb62469510c115362f801c08563421c304

  7. rkrux commented at 5:57 AM on July 31, 2025: contributor

    Closing this one now.

  8. rkrux closed this on Jul 31, 2025


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-24 12:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me