contrib: remove bdb exception from FORTIFY check #32448

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:remove_bdb_exception_stack_protector changing 1 files +1 −2

fanquake commented at 1:41 PM on May 8, 2025: member

BDB has been removed (#28710), so we no-longer need to ignore functions from BDB in this check.

Guix building this branch, and looking for *_chk functions across all binaries produces:

# nm -C * | grep -i _chk | sort | uniq
                 U __fdelt_chk@GLIBC_2.15
                 U __fprintf_chk@GLIBC_2.3.4
                 U __fread_chk@GLIBC_2.7
                 U __longjmp_chk@GLIBC_2.11
                 U __memcpy_chk@GLIBC_2.3.4
                 U __printf_chk@GLIBC_2.3.4
                 U __snprintf_chk@GLIBC_2.3.4
                 U __sprintf_chk@GLIBC_2.3.4
                 U __stack_chk_fail@GLIBC_2.4
                 U __vsnprintf_chk@GLIBC_2.3.4

contrib: remove bdb exception from FORTIFY check

BDB has been removed (#28710), so we no-longer need to ignore functions
from BDB in this check.

f9dfe8d5e0

DrahtBot commented at 1:41 PM on May 8, 2025: contributor



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32448.



Reviews

See the guideline for information on the review process.

Type Reviewers

ACK theuni, laanwj, achow101

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
DrahtBot added the label Scripts and tools on May 8, 2025
theuni approved
theuni commented at 2:35 PM on May 8, 2025: member

utACK f9dfe8d5e0d3f628659702ab781b7919505c829f
laanwj approved
laanwj commented at 3:04 PM on May 8, 2025: member

Code review ACK f9dfe8d5e0d3f628659702ab781b7919505c829f
achow101 commented at 6:06 PM on May 8, 2025: member

ACK f9dfe8d5e0d3f628659702ab781b7919505c829f
achow101 merged this on May 8, 2025
achow101 closed this on May 8, 2025
pablomartin4btc commented at 9:52 PM on May 8, 2025: member

cr ACK f9dfe8d5e0d3f628659702ab781b7919505c829f

FWIW: Tried to run the check on Ubuntu and it seems some lief symbols have changed previously to the latest released version (< 0.16.5 - eg lief.EXE_FORMATS.ELF => lief.ELF.Binary), corrected it locally and ran succesfully, then saw that the CI has 0.13.2, this works well too.
fanquake deleted the branch on May 9, 2025