Some netbase tests fail on WinXP #3245

I just tried running the test_bitcoin.exe as produced by the pull tester on a WXP VM. For some reasons, there are many failures in netbase_tests.

Running 103 test cases...
netbase_tests.cpp(16): error in "netbase_networks": check CNetAddr("2001::8888").GetNetwork() == NET_IPV6 failed
netbase_tests.cpp(17): error in "netbase_networks": check CNetAddr("FD87:D87E:EB43:edb1:8e4:3588:e546:35ca").GetNetwork() == NET_TOR failed
netbase_tests.cpp(23): error in "netbase_properties": check CNetAddr("::FFFF:192.168.1.1").IsIPv4() failed
netbase_tests.cpp(28): error in "netbase_properties": check CNetAddr("2001:0DB8::").IsRFC3849() failed
netbase_tests.cpp(30): error in "netbase_properties": check CNetAddr("2002::1").IsRFC3964() failed
netbase_tests.cpp(31): error in "netbase_properties": check CNetAddr("FC00::").IsRFC4193() failed
netbase_tests.cpp(32): error in "netbase_properties": check CNetAddr("2001::2"). IsRFC4380() failed
netbase_tests.cpp(33): error in "netbase_properties": check CNetAddr("2001:10::").IsRFC4843() failed
netbase_tests.cpp(34): error in "netbase_properties": check CNetAddr("FE80::").IsRFC4862() failed
netbase_tests.cpp(35): error in "netbase_properties": check CNetAddr("64:FF9B::").IsRFC6052() failed
netbase_tests.cpp(36): error in "netbase_properties": check CNetAddr("FD87:D87E:EB43:edb1:8e4:3588:e546:35ca").IsTor() failed
netbase_tests.cpp(38): error in "netbase_properties": check CNetAddr("::1").IsLocal() failed
netbase_tests.cpp(40): error in "netbase_properties": check CNetAddr("2001::1"). IsRoutable() failed
netbase_tests.cpp(83): error in "netbase_lookupnumeric": check TestParse("::ffff:127.0.0.1", "127.0.0.1:65535") failed
netbase_tests.cpp(84): error in "netbase_lookupnumeric": check TestParse("::", "[::]:65535") failed
netbase_tests.cpp(85): error in "netbase_lookupnumeric": checkTestParse("[::]:8333", "[::]:8333") failed
netbase_tests.cpp(95): error in "onioncat_test": check addr1 == addr2 failed

*** 17 failures detected in test suite "Bitcoin Test Suite"

@diapolo Can you please check if the same happens on windows7/8 whatever you're running, I only have XP VMs

AFAIK XP has no IPv6 stack, I'm not sure why the test fail though... I ran them also on Win7 x64 and got no errors.

Yes, AFAIK also XP has no IPv6 support either. But I wouldn't expect address parsing to fail due to that. Or maybe it's to be expected as we (and boost) simply use the OS provided functions.

Thanks for verifying that it works on newer Windows.

Closing the issue as we don't need IPv6 address parsing on XP. A "solution" may be to disable those tests on XP, but mehh this is more transparent.