build: Revert “Temporarily disable compiling fuzz/utxo_snapshot.cpp with MSVC #32525

1. 
   maflcko commented at 6:44 am on May 16, 2025: member

   Now that GitHub Actions has a fixed version and the Windows developers have updated their compiler, the workaround is no longer needed.
2. 
   DrahtBot commented at 6:44 am on May 16, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32525.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	davidgumberg, hodlinator
   Stale ACK	hebasto

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

3. DrahtBot added the label Build system on May 16, 2025
4. hebasto approved
5. 
   hebasto commented at 7:03 am on May 16, 2025: member

   ACK fa0a4473a88017e525829ecd3db47f536c35fb62.

   Should a note about the broken MSVC 17.12 be added to the build docs?

6. 
   davidgumberg commented at 7:10 am on May 16, 2025: contributor

   ACK https://github.com/bitcoin/bitcoin/pull/32525/commits/fa0a4473a88017e525829ecd3db47f536c35fb62.

   I would be partial to disabling this for MSVC 17.12 in the vein of #32499, I mean if it is known to be broken, and it’s documented that it’s broken, one might as well just disable it?

   But, edge case of an edge case, so this seems fine to me.

7. build: Revert "Temporarily disable compiling `fuzz/utxo_snapshot.cpp` with MSVC"

   This reverts commit b2d536100282bd901d3e0be7f7f4a6966e0ef817.
   
   Also, adjust the doc to reflect the new minimum version. Versions 17.6
   or 17.11 (or anything in between) may still work on a best-effor basis,
   but it is not checked by CI or by developers.

   fa2c662362
8. maflcko force-pushed on May 16, 2025
9. 
   davidgumberg commented at 7:13 am on May 16, 2025: contributor

   reACK https://github.com/bitcoin/bitcoin/pull/32525/commits/fa2c6623626719b338880f7bb097b902019d5956
10. DrahtBot requested review from hebasto on May 16, 2025
11. hodlinator approved
12. 
    hodlinator commented at 7:43 am on May 16, 2025: contributor

    ACK fa2c6623626719b338880f7bb097b902019d5956

    Confirmed at least later patch-versions of 17.13 work here: #32499 (comment)

    It’s possible that the regression in 17.12 never made it to any of the patch-versions of 17.13.

13. fanquake merged this on May 16, 2025
14. fanquake closed this on May 16, 2025

    ---

15. maflcko deleted the branch on May 16, 2025

Contributors
maflcko DrahtBot hebasto davidgumberg hodlinator

Review Requested
hebasto

Labels
Build system