miniscript, refactor: Make operator""_mst consteval (re-take) #32564

pull hebasto wants to merge 2 commits into bitcoin:master from hebasto:250519-msvc-consteval changing 3 files +31 −39
  1. hebasto commented at 1:47 pm on May 19, 2025: member

    Same as #28657, but without the refactoring required to work around fixed MSVC bugs.

    The second commit has been taken from #29167.

  2. Revert "miniscript: make operator_mst consteval"
    This reverts commit 63317103c9f2b0635558da814567bb79c17ae851.
    bc4fb79a4e
  3. miniscript: Make `operator""_mst` `consteval` b1f7877bb7
  4. hebasto added the label Refactoring on May 19, 2025
  5. DrahtBot commented at 1:47 pm on May 19, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32564.

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #31713 (miniscript refactor: Remove unique_ptr-indirection (#30866 follow-up) by hodlinator)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  6. DrahtBot added the label CI failed on May 19, 2025
  7. DrahtBot removed the label CI failed on May 20, 2025
  8. fanquake requested review from sipa on May 20, 2025
  9. fanquake assigned darosior on May 20, 2025
  10. fanquake unassigned darosior on May 20, 2025
  11. fanquake requested review from darosior on May 20, 2025


hebasto DrahtBot


sipa darosior

Labels
Refactoring


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-05-25 18:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me