subprocess: Backport upstream changes #32567

1. 
   hebasto commented at 10:56 am on May 20, 2025: member

   A list of the backported PRs:

   • https://github.com/arun11299/cpp-subprocess/pull/119

   The following PRs were skipped for backporting:

   • https://github.com/arun11299/cpp-subprocess/pull/118 because there is no changes in the header code.

   Required for #32566.

2. 
   DrahtBot commented at 10:56 am on May 20, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32567.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	laanwj

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

3. 
   hebasto commented at 10:56 am on May 20, 2025: member

   cc @laanwj
4. hebasto force-pushed on May 20, 2025
5. 
   fanquake commented at 11:03 am on May 20, 2025: member

   Can’t this just go in with #32566? Why does it need it’s own PR?
6. subprocess: Don't add an extra whitespace at end of Windows command line

   The windows code adds an unnecessary extra space to the command line.
   This can cause subtle issues, so avoid it.
   
   Github-Pull: arun11299/cpp-subprocess#119
   Rebased-From: 777cfa77d1f84bb08b3e445d5f7fc6c87282223b

   e63a7034f0
7. hebasto force-pushed on May 20, 2025
8. 
   hebasto commented at 11:11 am on May 20, 2025: member

   Can’t this just go in with #32566? Why does it need it’s own PR?

   It would be easier to track backports.

9. 
   laanwj commented at 10:39 am on May 21, 2025: member

   The change is important for #32566 because the functional test was failing for the wallet notification, due to the extra space ending up in the output of echo.

   i don’t particularly mind how it ends up in the repository.

10. laanwj approved
11. 
    laanwj commented at 10:52 am on May 21, 2025: member

    Code review ACK e63a7034f0386789628dcb940d99ec6436d21128
12. fanquake merged this on May 21, 2025
13. fanquake closed this on May 21, 2025

    ---

14. hebasto deleted the branch on May 21, 2025

Contributors
hebasto DrahtBot fanquake laanwj