depends: use “mkdir -p” when installing xproto #32568

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:alpine_MKDIRPROG changing 1 files +3 −1
  1. fanquake commented at 11:27 am on May 20, 2025: member

    It looks like the mkdir detection in xproto is broken on Alpine. Ensure we always use mkdir -p.

    Fixes #32494.

  2. DrahtBot commented at 11:27 am on May 20, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32568.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK hebasto, janb84, willcl-ark

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  3. DrahtBot added the label Build system on May 20, 2025
  4. in depends/packages/xproto.mk:27 in d7302498b1 outdated 
    21@@ -22,5 +22,5 @@ define $(package)_build_cmds
22 endef
23 
24 define $(package)_stage_cmds
25-  $(MAKE) DESTDIR=$($(package)_staging_dir) install
26+  $(MAKE) MKDIRPROG="mkdir -p" DESTDIR=$($(package)_staging_dir) install
    hebasto commented at 11:39 am on May 20, 2025:
    Perhaps include a comment explaining why MKDIRPROG being added?
    fanquake commented at 3:01 pm on May 20, 2025:
    Added a comment.
  5. hebasto commented at 12:56 pm on May 20, 2025: member

    It looks like the mkdir detection in xproto is broken on Alpine.

    Yeah, it seems so:

    0checking for a thread-safe mkdir -p... ./install-sh -c -d

    In that case, why not guide all build scripts with $($(package)_autoconf) MKDIR_P="mkdir -p"?

  6. fanquake commented at 12:58 pm on May 20, 2025: member

    In that case, why not guide all build scripts with $($(package)_autoconf) MKDIR_P=“mkdir -p”?

    Not sure what you mean, but I’m not planning on changing things globally to work around a single broken package on a single OS.

  7. hebasto commented at 1:03 pm on May 20, 2025: member

    In that case, why not guide all build scripts with $($(package)_autoconf) MKDIR_P=“mkdir -p”?

    Not sure what you mean, but I’m not planning on changing things globally…

    I mean nothing like that, but to configure the xproto package’s build system with the documented variable.

  8. fanquake commented at 1:05 pm on May 20, 2025: member
    MKDIRPROG is also documented. What’s the difference?
  9. hebasto commented at 1:22 pm on May 20, 2025: member

    MKDIRPROG is also documented.

    Mind sharing a link please?

  10. fanquake commented at 1:29 pm on May 20, 2025: member
    It’s documented in the install script.
  11. willcl-ark commented at 1:48 pm on May 20, 2025: member

    Concept ACK.

    Tested successfully @ d730249 using

     0$ docker run -it alpine:latest
 1
 2# On the guest
 3$ apk update
 4$ apk add git
 5$ git clone https://github.com/bitcoin/bitcoin --depth=1
 6$ git fetch origin pull/32568/head:pr-32568
 7$ git checkout pr-32568
 8$ apk add bash build-base cmake curl m4 make patch
 9$ apk add bison linux-headers ninja-build pkgconf python3 xz
10$ make -C depends -j14

    No strong opinion from me on MKDIRPROG vs MKDIR_P.

  12. depends: use "mkdir -p" when installing xproto 
    It looks like the mkdir detection in xproto is broken on Alpine. Ensure
we always use `mkdir -p`.

Fixes #32494.
    df9ebbf659
  13. fanquake force-pushed on May 20, 2025
  14. DrahtBot added the label CI failed on May 20, 2025
  15. hebasto approved
  16. hebasto commented at 3:40 pm on May 20, 2025: member
    ACK df9ebbf659d5d1282289f36d7f9ee7103aa33a17, I have reviewed the code and it looks OK.
  17. DrahtBot requested review from willcl-ark on May 20, 2025
  18. fanquake added the label Needs backport (29.x) on May 20, 2025
  19. fanquake commented at 4:39 pm on May 20, 2025: member

    Guix Build:

     0c07d19f1279ac1255fff06fff094eea425aa2d228b2cf4fef8ffa366fac344dc  guix-build-df9ebbf659d5/output/aarch64-linux-gnu/SHA256SUMS.part
 17a20ba73e966048d991d3d274c2a97575d47473befefe17e850760bc48cbbd9b  guix-build-df9ebbf659d5/output/aarch64-linux-gnu/bitcoin-df9ebbf659d5-aarch64-linux-gnu-debug.tar.gz
 2bf70710e4308ec852471510d9f6ddc301c0c083c74d49c208e935d8b72e26e1b  guix-build-df9ebbf659d5/output/aarch64-linux-gnu/bitcoin-df9ebbf659d5-aarch64-linux-gnu.tar.gz
 300fc3a52592fe07adfb67484bacbb5b9249d00b2902a1e2a66dd5e2f80a8826d  guix-build-df9ebbf659d5/output/arm-linux-gnueabihf/SHA256SUMS.part
 45723df0fdb0211a067bea0bac544fa6a7e7f4ddf66dc0d881588ba820b49d20f  guix-build-df9ebbf659d5/output/arm-linux-gnueabihf/bitcoin-df9ebbf659d5-arm-linux-gnueabihf-debug.tar.gz
 5cd896cafd744f12f3583fc1cfef70441ea3228693501fd1ca910cd61c0253981  guix-build-df9ebbf659d5/output/arm-linux-gnueabihf/bitcoin-df9ebbf659d5-arm-linux-gnueabihf.tar.gz
 6a19e9497847667ceebcd766cce9b15a843c6c6cd439059e7b5d8b14ae6136d87  guix-build-df9ebbf659d5/output/arm64-apple-darwin/SHA256SUMS.part
 7dbe32996dae88a0079a9d46a026913d881bf8d8411703c3fa0856dd53dad2d82  guix-build-df9ebbf659d5/output/arm64-apple-darwin/bitcoin-df9ebbf659d5-arm64-apple-darwin-codesigning.tar.gz
 8ffaf37757024beb6f3f321ab18d48c87c5c599eeb8db2fe101124f544d46efa0  guix-build-df9ebbf659d5/output/arm64-apple-darwin/bitcoin-df9ebbf659d5-arm64-apple-darwin-unsigned.tar.gz
 987f7c982493547d39e54dc41a981df8ad994d315beea2d5bd39ead074ec56d61  guix-build-df9ebbf659d5/output/arm64-apple-darwin/bitcoin-df9ebbf659d5-arm64-apple-darwin-unsigned.zip
10302a02a715fa2015c097b0c8bbe376822e8760f0a440adae9f1cc1df013667d1  guix-build-df9ebbf659d5/output/dist-archive/bitcoin-df9ebbf659d5.tar.gz
118ea9d874be0bfec1771d82f77a5501f4033a2d84ab54e940f229ccdf2aba8032  guix-build-df9ebbf659d5/output/powerpc64-linux-gnu/SHA256SUMS.part
12e07fda0b01dc65d2ad667f57c571daa62245b593f44c40b51e5f40d77ed52fe0  guix-build-df9ebbf659d5/output/powerpc64-linux-gnu/bitcoin-df9ebbf659d5-powerpc64-linux-gnu-debug.tar.gz
13dbcf034a85aeb2ee22c304cbd7cc9adcf907e9c779160a71f9b713f43d312a8c  guix-build-df9ebbf659d5/output/powerpc64-linux-gnu/bitcoin-df9ebbf659d5-powerpc64-linux-gnu.tar.gz
144fcdcf55c92a5a1b18d1d93cc29371e1a85d00738533ebd6eaa32461cf42a381  guix-build-df9ebbf659d5/output/riscv64-linux-gnu/SHA256SUMS.part
159d729d04f3417df6e60952329dedfee786feb09baf155fbc6a2e5f58d75b5c2f  guix-build-df9ebbf659d5/output/riscv64-linux-gnu/bitcoin-df9ebbf659d5-riscv64-linux-gnu-debug.tar.gz
16791e404b46601de2a79ab032fd2a74376e895173de0f30bc73e32d7c9e6f41e8  guix-build-df9ebbf659d5/output/riscv64-linux-gnu/bitcoin-df9ebbf659d5-riscv64-linux-gnu.tar.gz
1793adb2b7cc67b0600d535420e324a29c0bae71c8308251c52fcb82e10bac0264  guix-build-df9ebbf659d5/output/x86_64-apple-darwin/SHA256SUMS.part
1825c076c485ba28be1dfccb13f3217a9b3c56e2ed6cf9ee5140b03feb10d8aec5  guix-build-df9ebbf659d5/output/x86_64-apple-darwin/bitcoin-df9ebbf659d5-x86_64-apple-darwin-codesigning.tar.gz
19977f9d0122d936a2c97bc6c92d89a31eab8ad34b8408a57f17448bc77f373a97  guix-build-df9ebbf659d5/output/x86_64-apple-darwin/bitcoin-df9ebbf659d5-x86_64-apple-darwin-unsigned.tar.gz
2037bd4dafb2866cf326412030c542d1c63036ad453a48f1cac0ad355a8b6ab5cc  guix-build-df9ebbf659d5/output/x86_64-apple-darwin/bitcoin-df9ebbf659d5-x86_64-apple-darwin-unsigned.zip
21f674955d6902cfba397365558b0a0bbacd91bc661229fc2da21108504e89b552  guix-build-df9ebbf659d5/output/x86_64-linux-gnu/SHA256SUMS.part
2201e48f177e1112a0318a42f0702784cc8674d9f8249e490f2e856ce65a1c4f83  guix-build-df9ebbf659d5/output/x86_64-linux-gnu/bitcoin-df9ebbf659d5-x86_64-linux-gnu-debug.tar.gz
23abf48f8b214df8dc62f54e804f65f074a2e16810c30ec18059558551d44801c8  guix-build-df9ebbf659d5/output/x86_64-linux-gnu/bitcoin-df9ebbf659d5-x86_64-linux-gnu.tar.gz
24c73a2345dd6ed14d52656ad40ba1e742dba0de9cccfad21e26865f9849bd55de  guix-build-df9ebbf659d5/output/x86_64-w64-mingw32/SHA256SUMS.part
2526c2ed79b7a6c18c10c445590fed94c3e38875b5a630766e7af924a1354c02e4  guix-build-df9ebbf659d5/output/x86_64-w64-mingw32/bitcoin-df9ebbf659d5-win64-codesigning.tar.gz
269dd980745361847e8862c502e22db78354f09336905e7053aff2994378be5472  guix-build-df9ebbf659d5/output/x86_64-w64-mingw32/bitcoin-df9ebbf659d5-win64-debug.zip
27fcff8780dffac5a8e8b434a948d05ca4fe8527d4cca26cb39a1c0e8b1cd5299b  guix-build-df9ebbf659d5/output/x86_64-w64-mingw32/bitcoin-df9ebbf659d5-win64-setup-unsigned.exe
28f6a67d38010f0d9ab21d1a3eea05f233c637d8cefb5201a70075967d132212ad  guix-build-df9ebbf659d5/output/x86_64-w64-mingw32/bitcoin-df9ebbf659d5-win64-unsigned.zip
  20. DrahtBot removed the label CI failed on May 20, 2025
  21. willcl-ark commented at 7:59 pm on May 20, 2025: member

    Mismatching hashes on my build:

     0src/core/bitcoin on  alpine_MKDIRPROG:refs/pull/32568/head [$] via △ v3.31.6 via 🐍 v3.12.10 via ❄️  impure (nix-shell-env) took 1h13m42s
 1❯ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
 2
 3cb7dbe6112cdd38db9757af64cd4e617cdced8a6525db8a1469f3f35d29de9f6  guix-build-df9ebbf659d5/output/aarch64-linux-gnu/SHA256SUMS.part
 4a0b2b6c3fd30ae9aa7667b99f0ac2fe7d59725fff6fef547bd73f2cc5b50b1b3  guix-build-df9ebbf659d5/output/aarch64-linux-gnu/bitcoin-df9ebbf659d5-aarch64-linux-gnu-debug.tar.gz
 53015b81d14d9339a9fddf7b7feb8b36c6fcaeb3247dec38baece958fc24065c7  guix-build-df9ebbf659d5/output/aarch64-linux-gnu/bitcoin-df9ebbf659d5-aarch64-linux-gnu.tar.gz
 6d5333d546d6e2b6a696cbce2220ec217f835166d7a0c088634e6e268a96ba300  guix-build-df9ebbf659d5/output/arm-linux-gnueabihf/SHA256SUMS.part
 768031430cdcd6a2de5cb8ea523665367983b99c85825eefcbc2f6c8a630b099f  guix-build-df9ebbf659d5/output/arm-linux-gnueabihf/bitcoin-df9ebbf659d5-arm-linux-gnueabihf-debug.tar.gz
 899fbf0cd4e14abc0553d5ba7644646aa1d2b0cfa539c049dfb4ee868e6bf167c  guix-build-df9ebbf659d5/output/arm-linux-gnueabihf/bitcoin-df9ebbf659d5-arm-linux-gnueabihf.tar.gz
 98e2de487121792ba21e66b8671904a9d593da83c83416b2addc278b5d1da21c8  guix-build-df9ebbf659d5/output/arm64-apple-darwin/SHA256SUMS.part
1035728ce72fcfe5fa77b5fa7b228ae6bd001a8e55c7ae4cb21fe30b0ef73aba4c  guix-build-df9ebbf659d5/output/arm64-apple-darwin/bitcoin-df9ebbf659d5-arm64-apple-darwin-codesigning.tar.gz
113606445152cede8ac6a2417965b59be17b45856855e64e4505840d898ae5a311  guix-build-df9ebbf659d5/output/arm64-apple-darwin/bitcoin-df9ebbf659d5-arm64-apple-darwin-unsigned.tar.gz
1207a6e43006d91392777037692dd3333ca76f875a0fce31fb3766d2999b7b1e7d  guix-build-df9ebbf659d5/output/arm64-apple-darwin/bitcoin-df9ebbf659d5-arm64-apple-darwin-unsigned.zip
13302a02a715fa2015c097b0c8bbe376822e8760f0a440adae9f1cc1df013667d1  guix-build-df9ebbf659d5/output/dist-archive/bitcoin-df9ebbf659d5.tar.gz
147c41454b941cb247aa869319c7fe3821a356715babdba688cc90fbf8a73dd924  guix-build-df9ebbf659d5/output/powerpc64-linux-gnu/SHA256SUMS.part
15b5320e48ee7f21da24d9fe09df65a876da3a4a368695524d7cf78b4f07aea80e  guix-build-df9ebbf659d5/output/powerpc64-linux-gnu/bitcoin-df9ebbf659d5-powerpc64-linux-gnu-debug.tar.gz
16517eb21687c6047e53301c97d77c414caa56bd5ed7cdcfaf23f188e91a0a76e7  guix-build-df9ebbf659d5/output/powerpc64-linux-gnu/bitcoin-df9ebbf659d5-powerpc64-linux-gnu.tar.gz
17368d640618ef05cc4278886a39e706a25bc1f008039443a8540d91dd98372ac7  guix-build-df9ebbf659d5/output/riscv64-linux-gnu/SHA256SUMS.part
18fc2bdca01aa55f57bc3038ade9b59f514beb2a4fb9e5a82f75680cd2e4c5035e  guix-build-df9ebbf659d5/output/riscv64-linux-gnu/bitcoin-df9ebbf659d5-riscv64-linux-gnu-debug.tar.gz
19844bbea570fa22992aef28ba9c369164ead2b5b6d9223be23ba66444e857708f  guix-build-df9ebbf659d5/output/riscv64-linux-gnu/bitcoin-df9ebbf659d5-riscv64-linux-gnu.tar.gz
20dcc4c3ff5984c2216d6b5b6e5bdc20651d808f605fb3ef3b895277bc620aafe9  guix-build-df9ebbf659d5/output/x86_64-apple-darwin/SHA256SUMS.part
21793aedb951a9f1ba2df5c51ff2306e3c6f55334957457cb1a2ec064d559a73e4  guix-build-df9ebbf659d5/output/x86_64-apple-darwin/bitcoin-df9ebbf659d5-x86_64-apple-darwin-codesigning.tar.gz
22b830e5cf029ae6366be15af11f1772a812531c61fde71836c22a33eef5ed8db7  guix-build-df9ebbf659d5/output/x86_64-apple-darwin/bitcoin-df9ebbf659d5-x86_64-apple-darwin-unsigned.tar.gz
2336ad6470cf4d0c580f564c2cf11d6adba90d543529fbf7360e19c283979736af  guix-build-df9ebbf659d5/output/x86_64-apple-darwin/bitcoin-df9ebbf659d5-x86_64-apple-darwin-unsigned.zip
24b37096b3a3d59f275a0f5135aba1166046f5b4bb5d129439308e4c2d339462ed  guix-build-df9ebbf659d5/output/x86_64-linux-gnu/SHA256SUMS.part
25410ad822e7b74648c5005d13780c00f9c018b42ff36c94a7cd169166d8168938  guix-build-df9ebbf659d5/output/x86_64-linux-gnu/bitcoin-df9ebbf659d5-x86_64-linux-gnu-debug.tar.gz
263908e6b44103343751b1e8df25360f3e1b959b67188a62ef6ac897e039b7bc3d  guix-build-df9ebbf659d5/output/x86_64-linux-gnu/bitcoin-df9ebbf659d5-x86_64-linux-gnu.tar.gz
2759fcd11af18f578dff44e65dd2407782547a13c10df26130985ef863b4e1d61a  guix-build-df9ebbf659d5/output/x86_64-w64-mingw32/SHA256SUMS.part
28eeaa6d3a977e46d9c36c1e254737daff0624520b34f5d77e8e94c1f0c527b1e3  guix-build-df9ebbf659d5/output/x86_64-w64-mingw32/bitcoin-df9ebbf659d5-win64-codesigning.tar.gz
295d5543c1ca0556d7eb0ddd9200beeabd502879c24ba2035077e22e0d20ee55c4  guix-build-df9ebbf659d5/output/x86_64-w64-mingw32/bitcoin-df9ebbf659d5-win64-debug.zip
30fcff8780dffac5a8e8b434a948d05ca4fe8527d4cca26cb39a1c0e8b1cd5299b  guix-build-df9ebbf659d5/output/x86_64-w64-mingw32/bitcoin-df9ebbf659d5-win64-setup-unsigned.exe
31d6bf58025866ef957499604c30709f1cda5c372bae215599ade0d7eefe726bea  guix-build-df9ebbf659d5/output/x86_64-w64-mingw32/bitcoin-df9ebbf659d5-win64-unsigned.zip
  22. janb84 commented at 9:13 am on May 22, 2025: contributor

    ACK df9ebbf659d5d1282289f36d7f9ee7103aa33a17

    Breaks on master, builds with this commit

    0make[3]: Leaving directory '/bitcoin/depends/work/build/aarch64-unknown-linux-musl/xproto/7.0.31-fb91398a650'
1make[2]: *** [Makefile:838: install-am] Error 2
2make[2]: Leaving directory '/bitcoin/depends/work/build/aarch64-unknown-linux-musl/xproto/7.0.31-fb91398a650'
3make[1]: *** [Makefile:535: install-recursive] Error 1
4make[1]: Leaving directory '/bitcoin/depends/work/build/aarch64-unknown-linux-musl/xproto/7.0.31-fb91398a650'
5make: *** [funcs.mk:342: /bitcoin/depends/work/staging/aarch64-unknown-linux-musl/xproto/7.0.31-fb91398a650/.stamp_staged] Error 2
  23. willcl-ark commented at 9:40 am on May 22, 2025: member

    ok I just did a lazy rebuild of x86_64 only and got the same hashes again:

    0❯ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
1302a02a715fa2015c097b0c8bbe376822e8760f0a440adae9f1cc1df013667d1  guix-build-df9ebbf659d5/output/dist-archive/bitcoin-df9ebbf659d5.tar.gz
2b37096b3a3d59f275a0f5135aba1166046f5b4bb5d129439308e4c2d339462ed  guix-build-df9ebbf659d5/output/x86_64-linux-gnu/SHA256SUMS.part
3410ad822e7b74648c5005d13780c00f9c018b42ff36c94a7cd169166d8168938  guix-build-df9ebbf659d5/output/x86_64-linux-gnu/bitcoin-df9ebbf659d5-x86_64-linux-gnu-debug.tar.gz
43908e6b44103343751b1e8df25360f3e1b959b67188a62ef6ac897e039b7bc3d  guix-build-df9ebbf659d5/output/x86_64-linux-gnu/bitcoin-df9ebbf659d5-x86_64-linux-gnu.tar.gz

    I guess I’ll do a full run and see if everything matches my first run

  24. willcl-ark commented at 11:35 am on May 23, 2025: member

    OK a second full guix build got the same hashes as my first:

     0src/core/worktree-alpine-MKDIRPROG on  alpine_MKDIRPROG:refs/pull/32568/head [$] via △ v3.31.6 via 🐍 v3.12.10 via ❄️  impure (nix-shell-env) took 1h31m29s
 1❯ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
 2cb7dbe6112cdd38db9757af64cd4e617cdced8a6525db8a1469f3f35d29de9f6  guix-build-df9ebbf659d5/output/aarch64-linux-gnu/SHA256SUMS.part
 3a0b2b6c3fd30ae9aa7667b99f0ac2fe7d59725fff6fef547bd73f2cc5b50b1b3  guix-build-df9ebbf659d5/output/aarch64-linux-gnu/bitcoin-df9ebbf659d5-aarch64-linux-gnu-debug.tar.gz
 43015b81d14d9339a9fddf7b7feb8b36c6fcaeb3247dec38baece958fc24065c7  guix-build-df9ebbf659d5/output/aarch64-linux-gnu/bitcoin-df9ebbf659d5-aarch64-linux-gnu.tar.gz
 5d5333d546d6e2b6a696cbce2220ec217f835166d7a0c088634e6e268a96ba300  guix-build-df9ebbf659d5/output/arm-linux-gnueabihf/SHA256SUMS.part
 668031430cdcd6a2de5cb8ea523665367983b99c85825eefcbc2f6c8a630b099f  guix-build-df9ebbf659d5/output/arm-linux-gnueabihf/bitcoin-df9ebbf659d5-arm-linux-gnueabihf-debug.tar.gz
 799fbf0cd4e14abc0553d5ba7644646aa1d2b0cfa539c049dfb4ee868e6bf167c  guix-build-df9ebbf659d5/output/arm-linux-gnueabihf/bitcoin-df9ebbf659d5-arm-linux-gnueabihf.tar.gz
 88e2de487121792ba21e66b8671904a9d593da83c83416b2addc278b5d1da21c8  guix-build-df9ebbf659d5/output/arm64-apple-darwin/SHA256SUMS.part
 935728ce72fcfe5fa77b5fa7b228ae6bd001a8e55c7ae4cb21fe30b0ef73aba4c  guix-build-df9ebbf659d5/output/arm64-apple-darwin/bitcoin-df9ebbf659d5-arm64-apple-darwin-codesigning.tar.gz
103606445152cede8ac6a2417965b59be17b45856855e64e4505840d898ae5a311  guix-build-df9ebbf659d5/output/arm64-apple-darwin/bitcoin-df9ebbf659d5-arm64-apple-darwin-unsigned.tar.gz
1107a6e43006d91392777037692dd3333ca76f875a0fce31fb3766d2999b7b1e7d  guix-build-df9ebbf659d5/output/arm64-apple-darwin/bitcoin-df9ebbf659d5-arm64-apple-darwin-unsigned.zip
12302a02a715fa2015c097b0c8bbe376822e8760f0a440adae9f1cc1df013667d1  guix-build-df9ebbf659d5/output/dist-archive/bitcoin-df9ebbf659d5.tar.gz
137c41454b941cb247aa869319c7fe3821a356715babdba688cc90fbf8a73dd924  guix-build-df9ebbf659d5/output/powerpc64-linux-gnu/SHA256SUMS.part
14b5320e48ee7f21da24d9fe09df65a876da3a4a368695524d7cf78b4f07aea80e  guix-build-df9ebbf659d5/output/powerpc64-linux-gnu/bitcoin-df9ebbf659d5-powerpc64-linux-gnu-debug.tar.gz
15517eb21687c6047e53301c97d77c414caa56bd5ed7cdcfaf23f188e91a0a76e7  guix-build-df9ebbf659d5/output/powerpc64-linux-gnu/bitcoin-df9ebbf659d5-powerpc64-linux-gnu.tar.gz
16368d640618ef05cc4278886a39e706a25bc1f008039443a8540d91dd98372ac7  guix-build-df9ebbf659d5/output/riscv64-linux-gnu/SHA256SUMS.part
17fc2bdca01aa55f57bc3038ade9b59f514beb2a4fb9e5a82f75680cd2e4c5035e  guix-build-df9ebbf659d5/output/riscv64-linux-gnu/bitcoin-df9ebbf659d5-riscv64-linux-gnu-debug.tar.gz
18844bbea570fa22992aef28ba9c369164ead2b5b6d9223be23ba66444e857708f  guix-build-df9ebbf659d5/output/riscv64-linux-gnu/bitcoin-df9ebbf659d5-riscv64-linux-gnu.tar.gz
19dcc4c3ff5984c2216d6b5b6e5bdc20651d808f605fb3ef3b895277bc620aafe9  guix-build-df9ebbf659d5/output/x86_64-apple-darwin/SHA256SUMS.part
20793aedb951a9f1ba2df5c51ff2306e3c6f55334957457cb1a2ec064d559a73e4  guix-build-df9ebbf659d5/output/x86_64-apple-darwin/bitcoin-df9ebbf659d5-x86_64-apple-darwin-codesigning.tar.gz
21b830e5cf029ae6366be15af11f1772a812531c61fde71836c22a33eef5ed8db7  guix-build-df9ebbf659d5/output/x86_64-apple-darwin/bitcoin-df9ebbf659d5-x86_64-apple-darwin-unsigned.tar.gz
2236ad6470cf4d0c580f564c2cf11d6adba90d543529fbf7360e19c283979736af  guix-build-df9ebbf659d5/output/x86_64-apple-darwin/bitcoin-df9ebbf659d5-x86_64-apple-darwin-unsigned.zip
23b37096b3a3d59f275a0f5135aba1166046f5b4bb5d129439308e4c2d339462ed  guix-build-df9ebbf659d5/output/x86_64-linux-gnu/SHA256SUMS.part
24410ad822e7b74648c5005d13780c00f9c018b42ff36c94a7cd169166d8168938  guix-build-df9ebbf659d5/output/x86_64-linux-gnu/bitcoin-df9ebbf659d5-x86_64-linux-gnu-debug.tar.gz
253908e6b44103343751b1e8df25360f3e1b959b67188a62ef6ac897e039b7bc3d  guix-build-df9ebbf659d5/output/x86_64-linux-gnu/bitcoin-df9ebbf659d5-x86_64-linux-gnu.tar.gz
2659fcd11af18f578dff44e65dd2407782547a13c10df26130985ef863b4e1d61a  guix-build-df9ebbf659d5/output/x86_64-w64-mingw32/SHA256SUMS.part
27eeaa6d3a977e46d9c36c1e254737daff0624520b34f5d77e8e94c1f0c527b1e3  guix-build-df9ebbf659d5/output/x86_64-w64-mingw32/bitcoin-df9ebbf659d5-win64-codesigning.tar.gz
285d5543c1ca0556d7eb0ddd9200beeabd502879c24ba2035077e22e0d20ee55c4  guix-build-df9ebbf659d5/output/x86_64-w64-mingw32/bitcoin-df9ebbf659d5-win64-debug.zip
29fcff8780dffac5a8e8b434a948d05ca4fe8527d4cca26cb39a1c0e8b1cd5299b  guix-build-df9ebbf659d5/output/x86_64-w64-mingw32/bitcoin-df9ebbf659d5-win64-setup-unsigned.exe
30d6bf58025866ef957499604c30709f1cda5c372bae215599ade0d7eefe726bea  guix-build-df9ebbf659d5/output/x86_64-w64-mingw32/bitcoin-df9ebbf659d5-win64-unsigned.zip
  25. willcl-ark approved
  26. willcl-ark commented at 2:22 pm on June 3, 2025: member

    ACK df9ebbf659d5d1282289f36d7f9ee7103aa33a17

    Sorry, my guix setup was to blame here. This is now fixed and I finally get matching hashes:

     0src/core/bitcoin on  pr-32568 [$] via △ v3.31.6 via 🐍 v3.12.10 via ❄️  impure (nix-shell-env) took 1h13m34s
 1❯ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
 2c07d19f1279ac1255fff06fff094eea425aa2d228b2cf4fef8ffa366fac344dc  guix-build-df9ebbf659d5/output/aarch64-linux-gnu/SHA256SUMS.part
 37a20ba73e966048d991d3d274c2a97575d47473befefe17e850760bc48cbbd9b  guix-build-df9ebbf659d5/output/aarch64-linux-gnu/bitcoin-df9ebbf659d5-aarch64-linux-gnu-debug.tar.gz
 4bf70710e4308ec852471510d9f6ddc301c0c083c74d49c208e935d8b72e26e1b  guix-build-df9ebbf659d5/output/aarch64-linux-gnu/bitcoin-df9ebbf659d5-aarch64-linux-gnu.tar.gz
 500fc3a52592fe07adfb67484bacbb5b9249d00b2902a1e2a66dd5e2f80a8826d  guix-build-df9ebbf659d5/output/arm-linux-gnueabihf/SHA256SUMS.part
 65723df0fdb0211a067bea0bac544fa6a7e7f4ddf66dc0d881588ba820b49d20f  guix-build-df9ebbf659d5/output/arm-linux-gnueabihf/bitcoin-df9ebbf659d5-arm-linux-gnueabihf-debug.tar.gz
 7cd896cafd744f12f3583fc1cfef70441ea3228693501fd1ca910cd61c0253981  guix-build-df9ebbf659d5/output/arm-linux-gnueabihf/bitcoin-df9ebbf659d5-arm-linux-gnueabihf.tar.gz
 8a19e9497847667ceebcd766cce9b15a843c6c6cd439059e7b5d8b14ae6136d87  guix-build-df9ebbf659d5/output/arm64-apple-darwin/SHA256SUMS.part
 9dbe32996dae88a0079a9d46a026913d881bf8d8411703c3fa0856dd53dad2d82  guix-build-df9ebbf659d5/output/arm64-apple-darwin/bitcoin-df9ebbf659d5-arm64-apple-darwin-codesigning.tar.gz
10ffaf37757024beb6f3f321ab18d48c87c5c599eeb8db2fe101124f544d46efa0  guix-build-df9ebbf659d5/output/arm64-apple-darwin/bitcoin-df9ebbf659d5-arm64-apple-darwin-unsigned.tar.gz
1187f7c982493547d39e54dc41a981df8ad994d315beea2d5bd39ead074ec56d61  guix-build-df9ebbf659d5/output/arm64-apple-darwin/bitcoin-df9ebbf659d5-arm64-apple-darwin-unsigned.zip
12302a02a715fa2015c097b0c8bbe376822e8760f0a440adae9f1cc1df013667d1  guix-build-df9ebbf659d5/output/dist-archive/bitcoin-df9ebbf659d5.tar.gz
138ea9d874be0bfec1771d82f77a5501f4033a2d84ab54e940f229ccdf2aba8032  guix-build-df9ebbf659d5/output/powerpc64-linux-gnu/SHA256SUMS.part
14e07fda0b01dc65d2ad667f57c571daa62245b593f44c40b51e5f40d77ed52fe0  guix-build-df9ebbf659d5/output/powerpc64-linux-gnu/bitcoin-df9ebbf659d5-powerpc64-linux-gnu-debug.tar.gz
15dbcf034a85aeb2ee22c304cbd7cc9adcf907e9c779160a71f9b713f43d312a8c  guix-build-df9ebbf659d5/output/powerpc64-linux-gnu/bitcoin-df9ebbf659d5-powerpc64-linux-gnu.tar.gz
164fcdcf55c92a5a1b18d1d93cc29371e1a85d00738533ebd6eaa32461cf42a381  guix-build-df9ebbf659d5/output/riscv64-linux-gnu/SHA256SUMS.part
179d729d04f3417df6e60952329dedfee786feb09baf155fbc6a2e5f58d75b5c2f  guix-build-df9ebbf659d5/output/riscv64-linux-gnu/bitcoin-df9ebbf659d5-riscv64-linux-gnu-debug.tar.gz
18791e404b46601de2a79ab032fd2a74376e895173de0f30bc73e32d7c9e6f41e8  guix-build-df9ebbf659d5/output/riscv64-linux-gnu/bitcoin-df9ebbf659d5-riscv64-linux-gnu.tar.gz
1993adb2b7cc67b0600d535420e324a29c0bae71c8308251c52fcb82e10bac0264  guix-build-df9ebbf659d5/output/x86_64-apple-darwin/SHA256SUMS.part
2025c076c485ba28be1dfccb13f3217a9b3c56e2ed6cf9ee5140b03feb10d8aec5  guix-build-df9ebbf659d5/output/x86_64-apple-darwin/bitcoin-df9ebbf659d5-x86_64-apple-darwin-codesigning.tar.gz
21977f9d0122d936a2c97bc6c92d89a31eab8ad34b8408a57f17448bc77f373a97  guix-build-df9ebbf659d5/output/x86_64-apple-darwin/bitcoin-df9ebbf659d5-x86_64-apple-darwin-unsigned.tar.gz
2237bd4dafb2866cf326412030c542d1c63036ad453a48f1cac0ad355a8b6ab5cc  guix-build-df9ebbf659d5/output/x86_64-apple-darwin/bitcoin-df9ebbf659d5-x86_64-apple-darwin-unsigned.zip
23f674955d6902cfba397365558b0a0bbacd91bc661229fc2da21108504e89b552  guix-build-df9ebbf659d5/output/x86_64-linux-gnu/SHA256SUMS.part
2401e48f177e1112a0318a42f0702784cc8674d9f8249e490f2e856ce65a1c4f83  guix-build-df9ebbf659d5/output/x86_64-linux-gnu/bitcoin-df9ebbf659d5-x86_64-linux-gnu-debug.tar.gz
25abf48f8b214df8dc62f54e804f65f074a2e16810c30ec18059558551d44801c8  guix-build-df9ebbf659d5/output/x86_64-linux-gnu/bitcoin-df9ebbf659d5-x86_64-linux-gnu.tar.gz
26c73a2345dd6ed14d52656ad40ba1e742dba0de9cccfad21e26865f9849bd55de  guix-build-df9ebbf659d5/output/x86_64-w64-mingw32/SHA256SUMS.part
2726c2ed79b7a6c18c10c445590fed94c3e38875b5a630766e7af924a1354c02e4  guix-build-df9ebbf659d5/output/x86_64-w64-mingw32/bitcoin-df9ebbf659d5-win64-codesigning.tar.gz
289dd980745361847e8862c502e22db78354f09336905e7053aff2994378be5472  guix-build-df9ebbf659d5/output/x86_64-w64-mingw32/bitcoin-df9ebbf659d5-win64-debug.zip
29fcff8780dffac5a8e8b434a948d05ca4fe8527d4cca26cb39a1c0e8b1cd5299b  guix-build-df9ebbf659d5/output/x86_64-w64-mingw32/bitcoin-df9ebbf659d5-win64-setup-unsigned.exe
30f6a67d38010f0d9ab21d1a3eea05f233c637d8cefb5201a70075967d132212ad  guix-build-df9ebbf659d5/output/x86_64-w64-mingw32/bitcoin-df9ebbf659d5-win64-unsigned.zip
  27. fanquake commented at 7:19 pm on June 3, 2025: member
    @willcl-ark Thanks for circling back around. We can follow up with the build env leakage.
  28. fanquake merged this on Jun 3, 2025
  29. fanquake closed this on Jun 3, 2025
  30. fanquake deleted the branch on Jun 3, 2025
  31. fanquake referenced this in commit 4a1143b083 on Jun 3, 2025
  32. fanquake removed the label Needs backport (29.x) on Jun 3, 2025
  33. fanquake commented at 7:27 pm on June 3, 2025: member
    Backported to 29.x in #32589.
  34. fanquake referenced this in commit aef658601d on Jun 4, 2025
  35. fanquake referenced this in commit a6cbd33d1a on Jun 5, 2025
  36. fanquake commented at 1:52 pm on June 5, 2025: member
    Backported to 28.x in #32684.


fanquake DrahtBot hebasto willcl-ark janb84

Labels
Build system

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-06-16 00:13 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me