refactor: remove dump.h/cpp, wallet_bdb_parser.cpp #32569

1. 
   vicjuma commented at 2:12 pm on May 20, 2025: none

   This PR removes the following deprecated legacy wallet files:

   • src/wallet/dump.cpp
   • src/wallet/dump.h
   • src/wallet/test/fuzz/wallet_bdb_parse.cpp
   • Their associated references and usages

   These files were originally part of the legacy BerkeleyDB wallet backend and are no longer used in current functionality. They were retained for backward compatibility but are now fully obsolete due to ongoing deprecation tracked in #28710.

   Motivation

   • These files are no longer compiled or referenced in the build.
   • Their removal reduces dead code and maintenance burden.
   • This improves developer experience by simplifying the wallet codebase and removing distractions during review and navigation.

   Testing

   • The build completes successfully.
   • All existing unit and functional tests pass.

   Reference

   Refs #28710.

2. refactor: remove dump.h/cpp, wallet_bdb_parser.cpp

   This commit removes dump.cpp, dump.h, and wallet_bdb_parse.cpp files, along with all their references and usages in the codebase.
   
   These files were part of the legacy wallet code deprecated in Bitcoin Core especially after PR #28710, and are therefore not in use.
   
   All related references and includes have been cleaned up to ensure the project builds cleanly and all tests pass.

   eeef80f297
3. 
   DrahtBot commented at 2:12 pm on May 20, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32569.

   Reviews

   See the guideline for information on the review process. A summary of reviews will appear here.

4. DrahtBot added the label Refactoring on May 20, 2025
5. DrahtBot added the label CI failed on May 20, 2025
6. 
   DrahtBot commented at 2:18 pm on May 20, 2025: contributor

   🚧 At least one of the CI tasks failed. Task previous releases, depends DEBUG: https://github.com/bitcoin/bitcoin/runs/42560825482 LLM reason (✨ experimental): The CI failure is due to build errors related to unrecognized compiler options.

   Try to run the tests locally, according to the documentation. However, a CI failure may still happen due to a number of reasons, for example:

   • Possibly due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.

   • A sanitizer issue, which can only be found by compiling with the sanitizer and running the affected test.

   • An intermittent issue.

   Leave a comment here, if you need help tracking down a confusing failure.

7. 
   maflcko commented at 2:18 pm on May 20, 2025: member

   Please no AI slop
8. maflcko closed this on May 20, 2025

   ---

9. 
   hebasto commented at 2:18 pm on May 20, 2025: member

   Please do not touch automatically generated src/qt/bitcoinstrings.cpp.
10. vicjuma deleted the branch on May 20, 2025
11. bitcoin locked this on May 20, 2025

Contributors
vicjuma DrahtBot maflcko hebasto

Labels
Refactoring CI failed