wallet: Always set descriptor cache upgraded flag for new wallets #32597

pull achow101 wants to merge 3 commits into bitcoin:master from achow101:desc-cache-is-upgraded changing 5 files +53 −12
  1. achow101 commented at 0:39 am on May 23, 2025: member

    Newly created wallets will always have an upgraded descriptor cache, so set those.

    Also, to verify this behavior, add a new flags field to getwalletinfo and check that in the functional tests.

    Split from #32489

  2. wallet: Set upgraded descriptor cache flag for newly created wallets
    Although WalletBatch::LoadWallet performs the descriptor cache upgrade,
    because new wallets do not have the descriptor flag set yet, the upgrade
    does not run and set the flag.
    
    Since new wallets will always being using the upgraded cache, there's no
    reason to wait to set the flag, so set it when the wallet flags are
    being initialized for new wallets.
    69f588a99a
  3. wallet: Add GetWalletFlags bc2a26b296
  4. wallet, rpc: Output wallet flags in getwalletinfo 47237cd193
  5. DrahtBot commented at 0:39 am on May 23, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32597.

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

  6. DrahtBot added the label Wallet on May 23, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-05-25 18:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me