A new field warnings is added for each wallet in listwalletdir. If a legacy wallet is detected, the warning will contain a message that the wallet is a legacy wallet and will need to be migrated before it can be loaded.
In the GUI, the "Open Wallet" menu is changed to show legacy wallets greyed out with "(needs migration)" appended to their name to indicate to the user that the legacy wallet will need to be migrated.
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32619.
<!--021abf342d371248e50ceaed478a90ca-->
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | maflcko, furszy, w0xlt, adyshimony |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
552 | @@ -548,7 +553,7 @@ def test_default_wallet(self): 553 | assert_equal(info["format"], "sqlite") 554 | 555 | walletdir_list = wallet.listwalletdir() 556 | - assert {"name": info["walletname"]} in walletdir_list["wallets"] 557 | + assert {"name": info["walletname"]} in [{"name": w["name"]} for w in walletdir_list["wallets"]]
I also needed to change this to make wallet_multiwallet.py pass:
--- a/test/functional/wallet_multiwallet.py
+++ b/test/functional/wallet_multiwallet.py
@@ -72,7 +72,7 @@ class MultiWalletTest(BitcoinTestFramework):
return wallet_dir(name, "wallet.dat")
return wallet_dir(name)
- assert_equal(self.nodes[0].listwalletdir(), {'wallets': [{'name': self.default_wallet_name}]})
+ assert_equal(self.nodes[0].listwalletdir(), {'wallets': [{'name': self.default_wallet_name, 'warnings': []}]})
# check wallet.dat is created
self.stop_nodes()
Indeed, done.
Instead of allowing users to load a legacy wallet from the "Open Wallet"
menu, show the legacy wallet greyed out with a message that the wallet
needs to be migrated.
lgtm ACK f3a444c45fb4bf4e51d53ebf1cf4c2631ded481c
Code review ACK f3a444c45fb4bf4e51d53ebf1cf4c2631ded481c
Test ACK f3a444c
<details><summary>Details</summary> <p>
listwalletdir:
bitcoin-cli listwalletdir
{
"wallets": [
{
"name": "legacy_0.15_ver",
"warnings": [
"This wallet is a legacy wallet and will need to be migrated with migratewallet before it can be loaded"
]
},
{
"name": "test_32597_wallet",
"warnings": [
]
}
]
}
QT "Open Wallet" menu:
</p> </details>
