fs: use `ftruncate` on OpenBSD in `AllocateFileRange` #32643

issue fanquake opened this issue on May 30, 2025

fanquake commented at 9:17 AM on May 30, 2025: member

OpenBSD doesn't have fallocate or posix_fallocate, which means it's hitting our fallback. We should instead have it use ftruncate. See related discussion in #32460.

cc @theStack.
fanquake added the label Utils/log/libs on May 30, 2025
theStack referenced this in commit 9982d525c5 on May 30, 2025
HouseOfHufflepuff commented at 1:29 AM on September 8, 2026: contributor

Opened #36189 to address this.
hebasto commented at 3:02 PM on September 8, 2026: member

Related issue: #33128.
hebasto commented at 11:05 AM on September 9, 2026: member

OpenBSD doesn't have fallocate or posix_fallocate, which means it's hitting our fallback. We should instead have it use ftruncate.

I don't think ftruncate() is suitable here, as it does not guarantee that blocks are actually allocated on disk, and a subsequent write to the file may fail.

See also @winterrdog's comment.

I'd suggest closing this issue.
HouseOfHufflepuff commented at 4:42 PM on September 14, 2026: contributor

Agreed with the ftruncate() concerns raised on #36189 — @hebasto's suggestion to close this seems right, there's no OpenBSD equivalent to posix_fallocate() that gives the same guarantees.

Contributors

Labels