cmake, qt: Process `*.qrc` files manually #32648

pull hebasto wants to merge 2 commits into bitcoin:master from hebasto:250530-qt-rcc changing 1 files +35 −5

hebasto commented at 4:35 pm on May 30, 2025: member

The first commit enables modification of the properties of the source files produced by Qt Resource Compiler, which helps, for example, to silence compiler warnings.

The second commit makes use of this new capability to silence -Wtrailing-whitespace warnings and resolves #32482 (comment).
hebasto added the label Build system on May 30, 2025
DrahtBot commented at 4:35 pm on May 30, 2025: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32648.

Reviews

See the guideline for information on the review process. A summary of reviews will appear here.

Conflicts

No conflicts as of last run.
fanquake commented at 9:16 pm on May 30, 2025: member

Thanks for taking a look at this. I’m not sure the complexity of having to manually process, and then still having to suppress warnings anyway, is worth it. I was thinking the fix here would be to change the tools / Qt to just produce files that don’t have the issue. Seems like something we could fix upstream?
DrahtBot added the label Needs rebase on Jun 4, 2025

cmake, qt: Process `*.qrc` files manually

This change allows modification of the resulting source files’
properties, which helps, for example, to silence compiler warnings.

cbc8675b9c

cmake, qt: Process *.qrc files manually #32648