wallet: add codex32 argument to addhdkey #32652

1. 
   roconnor-blockstream commented at 10:05 pm on May 30, 2025: contributor

   Rebase of #27351 onto #29136.

   WIP

   This PR introduces the ability to import BIP 93/codex32 master seeds with the addhdkey command. It currently expects seeds to be provided in either as a single seed or as a list of shares which can be assembled via Shamir Secret Sharing.

2. descriptor: Add unused(KEY) descriptor

   unused() descriptors do not have scriptPubKeys. Instead, the wallet uses
   them to store keys without having any scripts to watch for.

   10b677530e
3. test: Simple test for importing unused(KEY) 92849bdd9b
4. 
   DrahtBot commented at 10:06 pm on May 30, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32652.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   Concept ACK	achow101

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #bitcoin-core/gui/872 (Menu action to export a watchonly wallet by achow101)
   • #33392 (wallet, rpc: add UTXO set check and incremental rescan to importdescriptors by musaHaruna)
   • #33135 (wallet: warn against accidental unsafe older() import by Sjors)
   • #33008 (wallet: support bip388 policy with external signer by Sjors)
   • #32861 (Have createwalletdescriptor auto-detect an unused(KEY) by Sjors)
   • #32489 (wallet: Add exportwatchonlywallet RPC to export a watchonly version of a wallet by achow101)
   • #30243 (descriptors: taproot partial descriptors by Eunovo)
   • #29136 (wallet: addhdkey RPC to add just keys to wallets via new unused(KEY) descriptor by achow101)
   • #28690 (build: Introduce internal kernel library by TheCharlatan)
   • #28333 (wallet: Construct ScriptPubKeyMans with all data rather than loaded progressively by achow101)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

   LLM Linter (✨ experimental)

   Possible typos and grammar issues:

   • In codex32.cpp comment: residue (“secretshare32” or “secretshare32ex”. → residue (“secretshare32” or “secretshare32ex”) [missing closing parenthesis]

   drahtbot_id_4_m

5. DrahtBot added the label Wallet on May 30, 2025
6. DrahtBot added the label CI failed on May 30, 2025
7. 
   DrahtBot commented at 10:38 pm on May 30, 2025: contributor

   🚧 At least one of the CI tasks failed. Task previous releases, depends DEBUG: https://github.com/bitcoin/bitcoin/runs/43216931922 LLM reason (✨ experimental): The CI failure is due to a compilation error caused by an invalid use of dynamic_cast on a non-pointer type.

   Try to run the tests locally, according to the documentation. However, a CI failure may still happen due to a number of reasons, for example:

   • Possibly due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.

   • A sanitizer issue, which can only be found by compiling with the sanitizer and running the affected test.

   • An intermittent issue.

   Leave a comment here, if you need help tracking down a confusing failure.

8. wallet: Add addhdkey RPC 0d24f0af7a
9. wallet, rpc: Disallow import of unused() if key already exists cba3bcb6a7
10. wallet, rpc: Disallow importing unused() to wallets without privkeys 6100108594
11. 
    achow101 commented at 8:48 pm on June 2, 2025: member

    Concept ACK-ish

    This is certainly better than the previous approach.

12. roconnor-blockstream force-pushed on Jun 24, 2025
13. Hack importdescriptors to look for private keys in the wallet dd83a96906
14. bech32: expose the character conversion functionality

    In the next commit we will implement a new checksum, codex32, which uses
    the same encoding and HRP rules as bech32 and bech32m, but has a
    substantially different checksum verification procedure. To minimize
    duplicated code, we expose the character conversion in a new
    bech32::internals module.

    1ecd034940
15. roconnor-blockstream force-pushed on Jul 4, 2025
16. codex32: implement encoding and decoding 5d504cb11b
17. codex32: introduce Lagrange interpolation and derived shares 139e8c15c1
18. codex32: provide user-readable error types 59777ef8dc
19. roconnor-blockstream force-pushed on Jul 5, 2025
20. maflcko removed the label CI failed on Sep 26, 2025
21. achow101 closed this on Oct 22, 2025

    ---

22. 
    roconnor-blockstream commented at 3:34 pm on October 22, 2025: contributor

    Can you elaborate?
23. 
    achow101 commented at 4:11 pm on October 22, 2025: member

    I suppose NACK is a bit too strong.

    While codex32 itself is interesting, it is not interesting enough that any contributors to this project is interested in reviewing PRs including it.

24. 
    Sjors commented at 10:06 am on October 24, 2025: member

    I still haven’t gotten around to trying the paper booklet instructions. If and when I do that, I’ll probably review this. But no idea when that is.
25. 
    BenWestgate commented at 1:21 pm on October 24, 2025: contributor

    I still haven’t gotten around to trying the paper booklet instructions. If and when I do that, I’ll probably review this. But no idea when that is.

    From BIP-0093:

    …hand computation is optional, … and implementers do not need to be concerned with this possibility.

    To encode some codex32 strings to import without the paper booklet there are libraries in Rust, Ruby and Python.

Contributors
roconnor-blockstream DrahtBot achow101 Sjors BenWestgate

Labels
Wallet