cmake: Replace file(GLOB ...) command with an explicit list of *.ts files #32653

issue hebasto openend this issue on May 31, 2025
  1. hebasto commented at 6:30 am on May 31, 2025: member

    From CMake docs:

    We do not recommend using GLOB to collect a list of source files from your source tree. If no CMakeLists.txt file changes when a source is added or removed then the generated build system cannot know when to ask CMake to regenerate.

    So the following case have to be reworked:https://github.com/bitcoin/bitcoin/blob/4b1d48a6866b24f0ed027334c6de642fc848d083/src/qt/CMakeLists.txt#L57-L60

  2. hebasto added the label Build system on May 31, 2025
  3. fanquake added the label GUI on Jun 2, 2025
  4. fanquake commented at 10:01 am on June 2, 2025: member
    What’s the actual blocker to just making this change?
  5. hebasto commented at 10:37 am on June 2, 2025: member

    What’s the actual blocker to just making this change?

    There are no blockers.

    However, bitcoin-maintainer-tools/update-translations.py should be updated first.

  6. laanwj commented at 11:15 am on June 2, 2025: member
    Concept ACK. Using a glob is kind of fragile here, harder to ensure the build matches git when there’s loose .ts files around.

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-06-09 06:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me