depends: sqlite 3.50.4; switch to autosetup

fanquake commented at 11:37 am on June 1, 2025: member

Migrate to SQLite 3.50.4 in depends; switching to its new Autosetup build system.

DrahtBot commented at 11:37 am on June 1, 2025: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32655.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	TheCharlatan, willcl-ark

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

No conflicts as of last run.

DrahtBot added the label Build system on Jun 1, 2025

DrahtBot added the label CI failed on Jun 1, 2025

fanquake force-pushed on Jun 2, 2025

DrahtBot removed the label CI failed on Jun 2, 2025

fanquake force-pushed on Jun 2, 2025

in contrib/guix/manifest.scm:22 in 37912de30d outdated

16@@ -17,6 +17,7 @@
17              ((gnu packages python) #:select (python-minimal))
18              ((gnu packages python-build) #:select (python-tomli python-poetry-core))
19              ((gnu packages python-crypto) #:select (python-asn1crypto))
20+             (gnu packages tcl)

hebasto commented at 12:18 pm on June 2, 2025:

How does this affect the overall dependency graph?

tobtoht commented at 12:36 pm on August 16, 2025:

tcl was already included in the build environment as a runtime dependency for python via ninja -> python-wrapper -> python.

With this change, no new runtime dependencies are included in the build environment. The only difference is that tclsh (and other helper binaries included in the tcl package) are now available on PATH.

fanquake force-pushed on Jun 7, 2025

fanquake renamed this:
~~depends: sqlite 3.50.0; switch to autosetup~~
depends: sqlite 3.50.1; switch to autosetup
on Jun 7, 2025

fanquake force-pushed on Jun 11, 2025

fanquake force-pushed on Jun 24, 2025

fanquake force-pushed on Jun 30, 2025

fanquake renamed this:
~~depends: sqlite 3.50.1; switch to autosetup~~
depends: sqlite 3.50.2; switch to autosetup
on Jul 2, 2025

fanquake force-pushed on Jul 24, 2025

fanquake renamed this:
~~depends: sqlite 3.50.2; switch to autosetup~~
depends: sqlite 3.50.3; switch to autosetup
on Jul 24, 2025

fanquake force-pushed on Jul 31, 2025

fanquake renamed this:
~~depends: sqlite 3.50.3; switch to autosetup~~
depends: sqlite 3.50.4; switch to autosetup
on Aug 18, 2025

fanquake force-pushed on Aug 18, 2025

fanquake force-pushed on Sep 1, 2025

fanquake added the label DrahtBot Guix build requested on Sep 1, 2025

DrahtBot commented at 1:40 pm on September 2, 2025: contributor

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

File	commit 7cc9a087069bfcdb79a08ce77eb3a60adf9483af(master)	commit c2a9c1e37e769020bb1507efc9467ecca5412488(pull/32655/merge)
*-aarch64-linux-gnu-debug.tar.gz	`d4d79e719716b3ec...`	`20c92fabd1199925...`
*-aarch64-linux-gnu.tar.gz	`a2d7668998cf5581...`	`4b2aa146050a8029...`
*-arm-linux-gnueabihf-debug.tar.gz	`7837b2ae895960f0...`	`2f1fd33810b76185...`
*-arm-linux-gnueabihf.tar.gz	`d5d7a18af35959f1...`	`55614f66cc351ac0...`
*-arm64-apple-darwin-codesigning.tar.gz	`ff2bc3fc9409522c...`	`570d8423465fbd2e...`
*-arm64-apple-darwin-unsigned.tar.gz	`3b10528036208e16...`	`690b462cad85ccea...`
*-arm64-apple-darwin-unsigned.zip	`3b1d6add242ef0d7...`	`a0cee2c2e56be433...`
*-powerpc64-linux-gnu-debug.tar.gz	`4c2b7de0dabcdd4a...`	`04c3d6963f358135...`
*-powerpc64-linux-gnu.tar.gz	`f3f972bc01c3ba2a...`	`b17a871a5803a445...`
*-riscv64-linux-gnu-debug.tar.gz	`89970d2c2338ca29...`	`dd100d36e72f5156...`
*-riscv64-linux-gnu.tar.gz	`0e9938e42a3374e8...`	`ae38d42c7b5b67d2...`
*-x86_64-apple-darwin-codesigning.tar.gz	`8efa84ef1754aeb0...`	`87af57d8277aba4d...`
*-x86_64-apple-darwin-unsigned.tar.gz	`cbe1699bdef1590b...`	`307de9435995544e...`
*-x86_64-apple-darwin-unsigned.zip	`279e63b23ff0ce08...`	`2aa38b4e83d0cf3f...`
*-x86_64-linux-gnu-debug.tar.gz	`512b5f4b222c4a46...`	`ead51e6a895c6508...`
*-x86_64-linux-gnu.tar.gz	`56b4aff66d9c4c2d...`	`df1492007a595bb7...`
*.tar.gz	`194017e760c3dc48...`	`b330567ac1dedd12...`
SHA256SUMS.part	`d6231a052dc6c762...`	`9492087f4469caac...`
guix_build.log	`c2e141d8220732a4...`	`437ab237dd78e1ac...`
guix_build.log.diff		`0c64eedb76778920...`

DrahtBot removed the label DrahtBot Guix build requested on Sep 2, 2025

fanquake force-pushed on Sep 3, 2025

fanquake force-pushed on Oct 10, 2025

fanquake force-pushed on Oct 15, 2025

fanquake force-pushed on Oct 23, 2025

fanquake force-pushed on Oct 28, 2025

fanquake marked this as ready for review on Oct 28, 2025

fanquake commented at 12:12 pm on October 28, 2025: member

Rebased for #33185 and dropped the [nomerge] --with-pic commit.

guix: sqlite wants tcl 286f3e49c8

depends: sqlite 3.50.4

Migrate to the new Autosetup build system (introduced in 3.48.0).
See https://msteveb.github.io/autosetup/.
Also: https://sqlite.org/releaselog/3_50_0.html.

1db7491470

fanquake force-pushed on Oct 29, 2025

fanquake added the label DrahtBot Guix build requested on Oct 29, 2025

fanquake commented at 11:59 am on October 30, 2025: member

Guix Build (aarch64)

 03e2443f9828f1541c02f5c33d29c78945bf218411bc35cf13894ad048495aad2  guix-build-1db74914706f/output/aarch64-linux-gnu/SHA256SUMS.part
 14a0f92a547fb3f94f930cbdb0575aaab16b1f7d95cd9172cce44068e1ec7ff62  guix-build-1db74914706f/output/aarch64-linux-gnu/bitcoin-1db74914706f-aarch64-linux-gnu-debug.tar.gz
 2c98f76eae0da3bf25774f5e8b25edac8d315bc428b2e21bf1d78cd8ebe9719b1  guix-build-1db74914706f/output/aarch64-linux-gnu/bitcoin-1db74914706f-aarch64-linux-gnu.tar.gz
 37d210acb8c5223f3db058ac509c1105717c15271c1e8076a9cce5048cc6bc2a7  guix-build-1db74914706f/output/arm-linux-gnueabihf/SHA256SUMS.part
 4d4c43805497c5923d47a1b6d6165060831e5709223f055aa2505f80ba03cf3ac  guix-build-1db74914706f/output/arm-linux-gnueabihf/bitcoin-1db74914706f-arm-linux-gnueabihf-debug.tar.gz
 53b71014183bc8f260ed17476610f02de4a5eb11cd482f48be00f3f4964e514f8  guix-build-1db74914706f/output/arm-linux-gnueabihf/bitcoin-1db74914706f-arm-linux-gnueabihf.tar.gz
 6746c14516fe132a91f5a34e27d54226b742a285c4390e15e67908dafb88886b9  guix-build-1db74914706f/output/arm64-apple-darwin/SHA256SUMS.part
 7c4416a98593b5b0543b8858f5a2f068ad38008ee49d80b062e4f4089d596dc03  guix-build-1db74914706f/output/arm64-apple-darwin/bitcoin-1db74914706f-arm64-apple-darwin-codesigning.tar.gz
 8ffe88f1539f66b7dec6e0d8ca70813a296badb6ffcced5c07031da0c255f7af3  guix-build-1db74914706f/output/arm64-apple-darwin/bitcoin-1db74914706f-arm64-apple-darwin-unsigned.tar.gz
 9338fb300ca4e550e7dd61bcba475af81f393ca19702a94931e591334d5bace83  guix-build-1db74914706f/output/arm64-apple-darwin/bitcoin-1db74914706f-arm64-apple-darwin-unsigned.zip
106bf8e8ef5c5c1293c604ab760d58fe3d3fce921a780778d978aff675f8c89c68  guix-build-1db74914706f/output/dist-archive/bitcoin-1db74914706f.tar.gz
11cbefa21cc7fdcbd5a411363a955c4285b5ba2f7656bd9ecd5dcfd3e34342f521  guix-build-1db74914706f/output/powerpc64-linux-gnu/SHA256SUMS.part
12eb359c520d238bc05bf36ad9ff442a0ac5a2cd91af06ee387e7168034f466d2b  guix-build-1db74914706f/output/powerpc64-linux-gnu/bitcoin-1db74914706f-powerpc64-linux-gnu-debug.tar.gz
1322e01cbd23538735bf750e2fd38d6c98e7c92f027f67c236be9887bab44cdf6e  guix-build-1db74914706f/output/powerpc64-linux-gnu/bitcoin-1db74914706f-powerpc64-linux-gnu.tar.gz
1436261b368ed1432fbb55465be9476bac31a400c6029f77939f1f93275fc67e4a  guix-build-1db74914706f/output/riscv64-linux-gnu/SHA256SUMS.part
15b4c2bb3de01caaa918b8e8e9d4f3343fbca49803c39384c035b2b8fbbd015360  guix-build-1db74914706f/output/riscv64-linux-gnu/bitcoin-1db74914706f-riscv64-linux-gnu-debug.tar.gz
165b54b0091ad8d52d882ea481f43ed4ad93a990e5073398aee96bca5ec50ae03a  guix-build-1db74914706f/output/riscv64-linux-gnu/bitcoin-1db74914706f-riscv64-linux-gnu.tar.gz
17b80fb138eca821a3bb365237cd8d3a31aa4709bbeb7971a62d77320671ddd7ca  guix-build-1db74914706f/output/x86_64-apple-darwin/SHA256SUMS.part
18116110489607ebe3f5b07157a9366157725b1d90a35ea74473e4f206891b4bcf  guix-build-1db74914706f/output/x86_64-apple-darwin/bitcoin-1db74914706f-x86_64-apple-darwin-codesigning.tar.gz
196ea89a6b75987515966d144fd3d78b03bcb431fa1a428d6e9181e983c31e55bf  guix-build-1db74914706f/output/x86_64-apple-darwin/bitcoin-1db74914706f-x86_64-apple-darwin-unsigned.tar.gz
20ed8d3b965d5f7f3d2c0087e9a83338d64f09248ec36546e2e30a93d95de9dd9f  guix-build-1db74914706f/output/x86_64-apple-darwin/bitcoin-1db74914706f-x86_64-apple-darwin-unsigned.zip
214086ae3a881a547e85310411cba567fa68fe844e34b73de418528cb17f2257c8  guix-build-1db74914706f/output/x86_64-linux-gnu/SHA256SUMS.part
2277d96e4b9131f5248320790bdf50c255c45ee1d221aa1100a40530b54e3f0060  guix-build-1db74914706f/output/x86_64-linux-gnu/bitcoin-1db74914706f-x86_64-linux-gnu-debug.tar.gz
23a6f813973f64264fca46b358278e37d214745b3b735df885bb69dcf6350f026c  guix-build-1db74914706f/output/x86_64-linux-gnu/bitcoin-1db74914706f-x86_64-linux-gnu.tar.gz
24185d34b9e002066afb05b67338cd2e34c86d50336f91d1d99327f82cc199151d  guix-build-1db74914706f/output/x86_64-w64-mingw32/SHA256SUMS.part
253b7724cac037edc467fda3f56e18a6731055a6d84995c541543f36536404f493  guix-build-1db74914706f/output/x86_64-w64-mingw32/bitcoin-1db74914706f-win64-codesigning.tar.gz
26008d9ee7f7bee762df0a8cae64b930e2c5accf2900c23d7b1ca5cec13dcf2a8e  guix-build-1db74914706f/output/x86_64-w64-mingw32/bitcoin-1db74914706f-win64-debug.zip
2757b57ea18b1b882a4d136bce679d6f576fb1939ff921c9828909a944d876db1e  guix-build-1db74914706f/output/x86_64-w64-mingw32/bitcoin-1db74914706f-win64-setup-unsigned.exe
284f43e811feb4a55b381acf381a8b0d90c2ced77e079bf9d2153e37c6446fce19  guix-build-1db74914706f/output/x86_64-w64-mingw32/bitcoin-1db74914706f-win64-unsigned.zip

DrahtBot commented at 6:52 pm on October 30, 2025: contributor

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

File	commit 72511fd02e72b74be11273e97bd7911786a82e54(master)	commit d3e26bc5ee7ba5c879cfd6f67a2206a2a8c476ca(pull/32655/merge)
*-aarch64-linux-gnu-debug.tar.gz	`a39e40869b172835...`	`55d74982d3b5fad8...`
*-aarch64-linux-gnu.tar.gz	`9c151c8756e38ff6...`	`c67aa841d18c6140...`
*-arm-linux-gnueabihf-debug.tar.gz	`b17c2aa84c16b85f...`	`bd479f31f588ede4...`
*-arm-linux-gnueabihf.tar.gz	`d92feff0b4d97d56...`	`999055b3480e5908...`
*-arm64-apple-darwin-codesigning.tar.gz	`a1c2e786f1e593ff...`	`9f1f4dcde7c9276e...`
*-arm64-apple-darwin-unsigned.tar.gz	`311840f1adcc829f...`	`c1be859a1fb87f96...`
*-arm64-apple-darwin-unsigned.zip	`43f3129420066e3a...`	`b30ba2e441dd30cb...`
*-powerpc64-linux-gnu-debug.tar.gz	`ade4f8452091572e...`	`a989fefb2edbbb92...`
*-powerpc64-linux-gnu.tar.gz	`6a0ff21800fb8d85...`	`6fae2c93aa169f2a...`
*-riscv64-linux-gnu-debug.tar.gz	`f222a21728341394...`	`b4ad5ce41cfb3c9f...`
*-riscv64-linux-gnu.tar.gz	`975b08bdf8089252...`	`f303022d19d7bfe7...`
*-x86_64-apple-darwin-codesigning.tar.gz	`b510af6eae5c0b4a...`	`1bdf978ac2d7fb91...`
*-x86_64-apple-darwin-unsigned.tar.gz	`0d006d2ebfbb8ac1...`	`038fa1f608abde5e...`
*-x86_64-apple-darwin-unsigned.zip	`1af9366647a9741c...`	`da98a3f9f7362256...`
*-x86_64-linux-gnu-debug.tar.gz	`5bbb87588c0ca164...`	`be22bf3e7cd411a7...`
*-x86_64-linux-gnu.tar.gz	`25acaed71e33010d...`	`ea7a6562181555ee...`
*.tar.gz	`b2f8b797153a84df...`	`3f12b585cd53ac1e...`
SHA256SUMS.part	`8fc79a058cfc1c2e...`	`ec38a51ce78aafbe...`
guix_build.log	`f1dbb9eb844ab679...`	`45711a04a4dfd95c...`
guix_build.log.diff		`3e1577733c066420...`

DrahtBot removed the label DrahtBot Guix build requested on Oct 30, 2025

fanquake renamed this:
~~depends: sqlite 3.50.4; switch to autosetup~~
depends: sqlite 3.51.0; switch to autosetup
on Nov 7, 2025

sedited approved

sedited commented at 10:03 am on November 14, 2025: contributor

ACK 1db74914706fcfafb22646288458604a4a7b6282

Guix build:

 03e2443f9828f1541c02f5c33d29c78945bf218411bc35cf13894ad048495aad2  guix-build-1db74914706f/output/aarch64-linux-gnu/SHA256SUMS.part
 14a0f92a547fb3f94f930cbdb0575aaab16b1f7d95cd9172cce44068e1ec7ff62  guix-build-1db74914706f/output/aarch64-linux-gnu/bitcoin-1db74914706f-aarch64-linux-gnu-debug.tar.gz
 2c98f76eae0da3bf25774f5e8b25edac8d315bc428b2e21bf1d78cd8ebe9719b1  guix-build-1db74914706f/output/aarch64-linux-gnu/bitcoin-1db74914706f-aarch64-linux-gnu.tar.gz
 37d210acb8c5223f3db058ac509c1105717c15271c1e8076a9cce5048cc6bc2a7  guix-build-1db74914706f/output/arm-linux-gnueabihf/SHA256SUMS.part
 4d4c43805497c5923d47a1b6d6165060831e5709223f055aa2505f80ba03cf3ac  guix-build-1db74914706f/output/arm-linux-gnueabihf/bitcoin-1db74914706f-arm-linux-gnueabihf-debug.tar.gz
 53b71014183bc8f260ed17476610f02de4a5eb11cd482f48be00f3f4964e514f8  guix-build-1db74914706f/output/arm-linux-gnueabihf/bitcoin-1db74914706f-arm-linux-gnueabihf.tar.gz
 6746c14516fe132a91f5a34e27d54226b742a285c4390e15e67908dafb88886b9  guix-build-1db74914706f/output/arm64-apple-darwin/SHA256SUMS.part
 7c4416a98593b5b0543b8858f5a2f068ad38008ee49d80b062e4f4089d596dc03  guix-build-1db74914706f/output/arm64-apple-darwin/bitcoin-1db74914706f-arm64-apple-darwin-codesigning.tar.gz
 8ffe88f1539f66b7dec6e0d8ca70813a296badb6ffcced5c07031da0c255f7af3  guix-build-1db74914706f/output/arm64-apple-darwin/bitcoin-1db74914706f-arm64-apple-darwin-unsigned.tar.gz
 9338fb300ca4e550e7dd61bcba475af81f393ca19702a94931e591334d5bace83  guix-build-1db74914706f/output/arm64-apple-darwin/bitcoin-1db74914706f-arm64-apple-darwin-unsigned.zip
106bf8e8ef5c5c1293c604ab760d58fe3d3fce921a780778d978aff675f8c89c68  guix-build-1db74914706f/output/dist-archive/bitcoin-1db74914706f.tar.gz
11cbefa21cc7fdcbd5a411363a955c4285b5ba2f7656bd9ecd5dcfd3e34342f521  guix-build-1db74914706f/output/powerpc64-linux-gnu/SHA256SUMS.part
12eb359c520d238bc05bf36ad9ff442a0ac5a2cd91af06ee387e7168034f466d2b  guix-build-1db74914706f/output/powerpc64-linux-gnu/bitcoin-1db74914706f-powerpc64-linux-gnu-debug.tar.gz
1322e01cbd23538735bf750e2fd38d6c98e7c92f027f67c236be9887bab44cdf6e  guix-build-1db74914706f/output/powerpc64-linux-gnu/bitcoin-1db74914706f-powerpc64-linux-gnu.tar.gz
1436261b368ed1432fbb55465be9476bac31a400c6029f77939f1f93275fc67e4a  guix-build-1db74914706f/output/riscv64-linux-gnu/SHA256SUMS.part
15b4c2bb3de01caaa918b8e8e9d4f3343fbca49803c39384c035b2b8fbbd015360  guix-build-1db74914706f/output/riscv64-linux-gnu/bitcoin-1db74914706f-riscv64-linux-gnu-debug.tar.gz
165b54b0091ad8d52d882ea481f43ed4ad93a990e5073398aee96bca5ec50ae03a  guix-build-1db74914706f/output/riscv64-linux-gnu/bitcoin-1db74914706f-riscv64-linux-gnu.tar.gz
17b80fb138eca821a3bb365237cd8d3a31aa4709bbeb7971a62d77320671ddd7ca  guix-build-1db74914706f/output/x86_64-apple-darwin/SHA256SUMS.part
18116110489607ebe3f5b07157a9366157725b1d90a35ea74473e4f206891b4bcf  guix-build-1db74914706f/output/x86_64-apple-darwin/bitcoin-1db74914706f-x86_64-apple-darwin-codesigning.tar.gz
196ea89a6b75987515966d144fd3d78b03bcb431fa1a428d6e9181e983c31e55bf  guix-build-1db74914706f/output/x86_64-apple-darwin/bitcoin-1db74914706f-x86_64-apple-darwin-unsigned.tar.gz
20ed8d3b965d5f7f3d2c0087e9a83338d64f09248ec36546e2e30a93d95de9dd9f  guix-build-1db74914706f/output/x86_64-apple-darwin/bitcoin-1db74914706f-x86_64-apple-darwin-unsigned.zip
214086ae3a881a547e85310411cba567fa68fe844e34b73de418528cb17f2257c8  guix-build-1db74914706f/output/x86_64-linux-gnu/SHA256SUMS.part
2277d96e4b9131f5248320790bdf50c255c45ee1d221aa1100a40530b54e3f0060  guix-build-1db74914706f/output/x86_64-linux-gnu/bitcoin-1db74914706f-x86_64-linux-gnu-debug.tar.gz
23a6f813973f64264fca46b358278e37d214745b3b735df885bb69dcf6350f026c  guix-build-1db74914706f/output/x86_64-linux-gnu/bitcoin-1db74914706f-x86_64-linux-gnu.tar.gz
24185d34b9e002066afb05b67338cd2e34c86d50336f91d1d99327f82cc199151d  guix-build-1db74914706f/output/x86_64-w64-mingw32/SHA256SUMS.part
253b7724cac037edc467fda3f56e18a6731055a6d84995c541543f36536404f493  guix-build-1db74914706f/output/x86_64-w64-mingw32/bitcoin-1db74914706f-win64-codesigning.tar.gz
26008d9ee7f7bee762df0a8cae64b930e2c5accf2900c23d7b1ca5cec13dcf2a8e  guix-build-1db74914706f/output/x86_64-w64-mingw32/bitcoin-1db74914706f-win64-debug.zip
2757b57ea18b1b882a4d136bce679d6f576fb1939ff921c9828909a944d876db1e  guix-build-1db74914706f/output/x86_64-w64-mingw32/bitcoin-1db74914706f-win64-setup-unsigned.exe
284f43e811feb4a55b381acf381a8b0d90c2ced77e079bf9d2153e37c6446fce19  guix-build-1db74914706f/output/x86_64-w64-mingw32/bitcoin-1db74914706f-win64-unsigned.zip

willcl-ark commented at 12:47 pm on November 14, 2025: member

Build:

 0❯ uname -m; find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
 1x86_64
 23e2443f9828f1541c02f5c33d29c78945bf218411bc35cf13894ad048495aad2  guix-build-1db74914706f/output/aarch64-linux-gnu/SHA256SUMS.part
 34a0f92a547fb3f94f930cbdb0575aaab16b1f7d95cd9172cce44068e1ec7ff62  guix-build-1db74914706f/output/aarch64-linux-gnu/bitcoin-1db74914706f-aarch64-linux-gnu-debug.tar.gz
 4c98f76eae0da3bf25774f5e8b25edac8d315bc428b2e21bf1d78cd8ebe9719b1  guix-build-1db74914706f/output/aarch64-linux-gnu/bitcoin-1db74914706f-aarch64-linux-gnu.tar.gz
 57d210acb8c5223f3db058ac509c1105717c15271c1e8076a9cce5048cc6bc2a7  guix-build-1db74914706f/output/arm-linux-gnueabihf/SHA256SUMS.part
 6d4c43805497c5923d47a1b6d6165060831e5709223f055aa2505f80ba03cf3ac  guix-build-1db74914706f/output/arm-linux-gnueabihf/bitcoin-1db74914706f-arm-linux-gnueabihf-debug.tar.gz
 73b71014183bc8f260ed17476610f02de4a5eb11cd482f48be00f3f4964e514f8  guix-build-1db74914706f/output/arm-linux-gnueabihf/bitcoin-1db74914706f-arm-linux-gnueabihf.tar.gz
 8746c14516fe132a91f5a34e27d54226b742a285c4390e15e67908dafb88886b9  guix-build-1db74914706f/output/arm64-apple-darwin/SHA256SUMS.part
 9c4416a98593b5b0543b8858f5a2f068ad38008ee49d80b062e4f4089d596dc03  guix-build-1db74914706f/output/arm64-apple-darwin/bitcoin-1db74914706f-arm64-apple-darwin-codesigning.tar.gz
10ffe88f1539f66b7dec6e0d8ca70813a296badb6ffcced5c07031da0c255f7af3  guix-build-1db74914706f/output/arm64-apple-darwin/bitcoin-1db74914706f-arm64-apple-darwin-unsigned.tar.gz
11338fb300ca4e550e7dd61bcba475af81f393ca19702a94931e591334d5bace83  guix-build-1db74914706f/output/arm64-apple-darwin/bitcoin-1db74914706f-arm64-apple-darwin-unsigned.zip
126bf8e8ef5c5c1293c604ab760d58fe3d3fce921a780778d978aff675f8c89c68  guix-build-1db74914706f/output/dist-archive/bitcoin-1db74914706f.tar.gz
13cbefa21cc7fdcbd5a411363a955c4285b5ba2f7656bd9ecd5dcfd3e34342f521  guix-build-1db74914706f/output/powerpc64-linux-gnu/SHA256SUMS.part
14eb359c520d238bc05bf36ad9ff442a0ac5a2cd91af06ee387e7168034f466d2b  guix-build-1db74914706f/output/powerpc64-linux-gnu/bitcoin-1db74914706f-powerpc64-linux-gnu-debug.tar.gz
1522e01cbd23538735bf750e2fd38d6c98e7c92f027f67c236be9887bab44cdf6e  guix-build-1db74914706f/output/powerpc64-linux-gnu/bitcoin-1db74914706f-powerpc64-linux-gnu.tar.gz
1636261b368ed1432fbb55465be9476bac31a400c6029f77939f1f93275fc67e4a  guix-build-1db74914706f/output/riscv64-linux-gnu/SHA256SUMS.part
17b4c2bb3de01caaa918b8e8e9d4f3343fbca49803c39384c035b2b8fbbd015360  guix-build-1db74914706f/output/riscv64-linux-gnu/bitcoin-1db74914706f-riscv64-linux-gnu-debug.tar.gz
185b54b0091ad8d52d882ea481f43ed4ad93a990e5073398aee96bca5ec50ae03a  guix-build-1db74914706f/output/riscv64-linux-gnu/bitcoin-1db74914706f-riscv64-linux-gnu.tar.gz
19b80fb138eca821a3bb365237cd8d3a31aa4709bbeb7971a62d77320671ddd7ca  guix-build-1db74914706f/output/x86_64-apple-darwin/SHA256SUMS.part
20116110489607ebe3f5b07157a9366157725b1d90a35ea74473e4f206891b4bcf  guix-build-1db74914706f/output/x86_64-apple-darwin/bitcoin-1db74914706f-x86_64-apple-darwin-codesigning.tar.gz
216ea89a6b75987515966d144fd3d78b03bcb431fa1a428d6e9181e983c31e55bf  guix-build-1db74914706f/output/x86_64-apple-darwin/bitcoin-1db74914706f-x86_64-apple-darwin-unsigned.tar.gz
22ed8d3b965d5f7f3d2c0087e9a83338d64f09248ec36546e2e30a93d95de9dd9f  guix-build-1db74914706f/output/x86_64-apple-darwin/bitcoin-1db74914706f-x86_64-apple-darwin-unsigned.zip
234086ae3a881a547e85310411cba567fa68fe844e34b73de418528cb17f2257c8  guix-build-1db74914706f/output/x86_64-linux-gnu/SHA256SUMS.part
2477d96e4b9131f5248320790bdf50c255c45ee1d221aa1100a40530b54e3f0060  guix-build-1db74914706f/output/x86_64-linux-gnu/bitcoin-1db74914706f-x86_64-linux-gnu-debug.tar.gz
25a6f813973f64264fca46b358278e37d214745b3b735df885bb69dcf6350f026c  guix-build-1db74914706f/output/x86_64-linux-gnu/bitcoin-1db74914706f-x86_64-linux-gnu.tar.gz
26185d34b9e002066afb05b67338cd2e34c86d50336f91d1d99327f82cc199151d  guix-build-1db74914706f/output/x86_64-w64-mingw32/SHA256SUMS.part
273b7724cac037edc467fda3f56e18a6731055a6d84995c541543f36536404f493  guix-build-1db74914706f/output/x86_64-w64-mingw32/bitcoin-1db74914706f-win64-codesigning.tar.gz
28008d9ee7f7bee762df0a8cae64b930e2c5accf2900c23d7b1ca5cec13dcf2a8e  guix-build-1db74914706f/output/x86_64-w64-mingw32/bitcoin-1db74914706f-win64-debug.zip
2957b57ea18b1b882a4d136bce679d6f576fb1939ff921c9828909a944d876db1e  guix-build-1db74914706f/output/x86_64-w64-mingw32/bitcoin-1db74914706f-win64-setup-unsigned.exe
304f43e811feb4a55b381acf381a8b0d90c2ced77e079bf9d2153e37c6446fce19  guix-build-1db74914706f/output/x86_64-w64-mingw32/bitcoin-1db74914706f-win64-unsigned.zip

fanquake renamed this:
~~depends: sqlite 3.51.0; switch to autosetup~~
depends: sqlite 3.50.4; switch to autosetup
on Nov 17, 2025

fanquake requested review from willcl-ark on Nov 20, 2025

in depends/packages/sqlite.mk:2 in 1db7491470

0@@ -1,35 +1,29 @@
1 package=sqlite
2-$(package)_version=3460100
3-$(package)_download_path=https://sqlite.org/2024/
4+$(package)_version=3500400

willcl-ark commented at 3:55 pm on November 24, 2025:

3.51 was released 04/11 and claims to have some performance improvements:

Performance enhancements:

Use fewer CPU cycles to commit a read transaction.
Early detection of joins that return no rows due to one or more of the tables containing no rows.
Avoid evaluation of scalar subqueries if the result of the subquery does not change the result of the overall expression.
Faster window function queries when using "BETWEEN :x FOLLOWING AND :y FOLLOWING" with a large :y.

Worth bumping to that version in this change?

fanquake commented at 3:59 pm on November 24, 2025:

I won’t be doing that update here. We’d likely want to wait for a few more point releases before that update in any case.

willcl-ark approved

willcl-ark commented at 9:26 am on November 25, 2025: member

tACK 1db74914706fcfafb22646288458604a4a7b6282

This looks good to me. Tested a few random wallet operations in addition to the tests, which all seem ok.

Noting that whilst --disable-dynamic-extensions was dropped from configure options it’s added as a preprocessor directive directly (although I think it could have been re-added to configure options as --disable-load-extension, but both are equivalent).

fanquake merged this on Nov 25, 2025

fanquake closed this on Nov 25, 2025

maflcko commented at 9:21 am on November 28, 2025: member

The depends fallback is down again?

0$ curl --show-headers 'https://bitcoincore.org/depends-sources/sqlite-autoconf-3500400.tar.gz'
1HTTP/2 404 
2server: nginx
3date: Fri, 28 Nov 2025 09:21:07 GMT
4content-type: text/html
5content-length: 146
6strict-transport-security: max-age=63072000; includeSubDomains; preload

fanquake deleted the branch on Nov 28, 2025

depends: sqlite 3.50.4; switch to autosetup #32655

Code Coverage & Benchmarks

Reviews

Conflicts

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]