depends: sqlite 3.50.4; switch to autosetup

fanquake commented at 11:37 am on June 1, 2025: member

We currently use SQLite 3.46.1 in depends. Migrating to any version after 3.49.0 (with our use of the amalgamation tarball), requires migrating to to building SQLite with autosetup, which is a replacement for Autoconf. This is what that will look like.

DrahtBot commented at 11:37 am on June 1, 2025: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32655.

Reviews

See the guideline for information on the review process. A summary of reviews will appear here.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#33185 (guix: update time-machine to 5cb84f2013c5b1e48a7d0e617032266f1e6059e2 by fanquake)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

DrahtBot added the label Build system on Jun 1, 2025

DrahtBot added the label CI failed on Jun 1, 2025

fanquake force-pushed on Jun 2, 2025

DrahtBot removed the label CI failed on Jun 2, 2025

fanquake force-pushed on Jun 2, 2025

in contrib/guix/manifest.scm:22 in 37912de30d outdated

16@@ -17,6 +17,7 @@
17              ((gnu packages python) #:select (python-minimal))
18              ((gnu packages python-build) #:select (python-tomli python-poetry-core))
19              ((gnu packages python-crypto) #:select (python-asn1crypto))
20+             (gnu packages tcl)

hebasto commented at 12:18 pm on June 2, 2025:

How does this affect the overall dependency graph?

tobtoht commented at 12:36 pm on August 16, 2025:

tcl was already included in the build environment as a runtime dependency for python via ninja -> python-wrapper -> python.

With this change, no new runtime dependencies are included in the build environment. The only difference is that tclsh (and other helper binaries included in the tcl package) are now available on PATH.

fanquake force-pushed on Jun 7, 2025

fanquake renamed this:
~~depends: sqlite 3.50.0; switch to autosetup~~
depends: sqlite 3.50.1; switch to autosetup
on Jun 7, 2025

fanquake force-pushed on Jun 11, 2025

fanquake force-pushed on Jun 24, 2025

fanquake force-pushed on Jun 30, 2025

fanquake renamed this:
~~depends: sqlite 3.50.1; switch to autosetup~~
depends: sqlite 3.50.2; switch to autosetup
on Jul 2, 2025

fanquake force-pushed on Jul 24, 2025

fanquake renamed this:
~~depends: sqlite 3.50.2; switch to autosetup~~
depends: sqlite 3.50.3; switch to autosetup
on Jul 24, 2025

fanquake force-pushed on Jul 31, 2025

fanquake renamed this:
~~depends: sqlite 3.50.3; switch to autosetup~~
depends: sqlite 3.50.4; switch to autosetup
on Aug 18, 2025

fanquake force-pushed on Aug 18, 2025

fanquake force-pushed on Sep 1, 2025

fanquake added the label DrahtBot Guix build requested on Sep 1, 2025

DrahtBot commented at 1:40 pm on September 2, 2025: contributor

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

File	commit 7cc9a087069bfcdb79a08ce77eb3a60adf9483af(master)	commit c2a9c1e37e769020bb1507efc9467ecca5412488(pull/32655/merge)
*-aarch64-linux-gnu-debug.tar.gz	`d4d79e719716b3ec...`	`20c92fabd1199925...`
*-aarch64-linux-gnu.tar.gz	`a2d7668998cf5581...`	`4b2aa146050a8029...`
*-arm-linux-gnueabihf-debug.tar.gz	`7837b2ae895960f0...`	`2f1fd33810b76185...`
*-arm-linux-gnueabihf.tar.gz	`d5d7a18af35959f1...`	`55614f66cc351ac0...`
*-arm64-apple-darwin-codesigning.tar.gz	`ff2bc3fc9409522c...`	`570d8423465fbd2e...`
*-arm64-apple-darwin-unsigned.tar.gz	`3b10528036208e16...`	`690b462cad85ccea...`
*-arm64-apple-darwin-unsigned.zip	`3b1d6add242ef0d7...`	`a0cee2c2e56be433...`
*-powerpc64-linux-gnu-debug.tar.gz	`4c2b7de0dabcdd4a...`	`04c3d6963f358135...`
*-powerpc64-linux-gnu.tar.gz	`f3f972bc01c3ba2a...`	`b17a871a5803a445...`
*-riscv64-linux-gnu-debug.tar.gz	`89970d2c2338ca29...`	`dd100d36e72f5156...`
*-riscv64-linux-gnu.tar.gz	`0e9938e42a3374e8...`	`ae38d42c7b5b67d2...`
*-x86_64-apple-darwin-codesigning.tar.gz	`8efa84ef1754aeb0...`	`87af57d8277aba4d...`
*-x86_64-apple-darwin-unsigned.tar.gz	`cbe1699bdef1590b...`	`307de9435995544e...`
*-x86_64-apple-darwin-unsigned.zip	`279e63b23ff0ce08...`	`2aa38b4e83d0cf3f...`
*-x86_64-linux-gnu-debug.tar.gz	`512b5f4b222c4a46...`	`ead51e6a895c6508...`
*-x86_64-linux-gnu.tar.gz	`56b4aff66d9c4c2d...`	`df1492007a595bb7...`
*.tar.gz	`194017e760c3dc48...`	`b330567ac1dedd12...`
SHA256SUMS.part	`d6231a052dc6c762...`	`9492087f4469caac...`
guix_build.log	`c2e141d8220732a4...`	`437ab237dd78e1ac...`
guix_build.log.diff		`0c64eedb76778920...`

DrahtBot removed the label DrahtBot Guix build requested on Sep 2, 2025

[nomerge] depends: --with-pic is incompatible with autosetup 5fb0c50311

guix: sqlite wants tcl efe87bb2d7

depends: sqlite 3.50.4

Migrate to the new Autosetup build system (introduced in 3.48.0).
See https://msteveb.github.io/autosetup/.
Also: https://sqlite.org/releaselog/3_50_0.html.

7b59e000fb

fanquake force-pushed on Sep 3, 2025

depends: sqlite 3.50.4; switch to autosetup #32655

Code Coverage & Benchmarks

Reviews

Conflicts

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]