depends: don't install & then delete sqlite pkgconf

fanquake commented at 11:42 am on June 1, 2025: member

depends: don't install & then delete sqlite pkgconf 72a5aa9b79

DrahtBot commented at 11:42 am on June 1, 2025: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32656.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	stickies-v, hebasto

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#32655 (depends: sqlite 3.50.0; switch to autosetup by fanquake)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

DrahtBot added the label Build system on Jun 1, 2025

maflcko added the label DrahtBot Guix build requested on Jun 2, 2025

fanquake commented at 10:24 am on June 2, 2025: member

Guix Build:

 0545db2ab3bf28143eda2307089bb7266ae64802ea4a15371bacccf4574ee2c67  guix-build-72a5aa9b791e/output/aarch64-linux-gnu/SHA256SUMS.part
 1660030fb8c70d09e11f35e2ccdde4187f6bd90009bc1da2826be1cf8a73e6f4b  guix-build-72a5aa9b791e/output/aarch64-linux-gnu/bitcoin-72a5aa9b791e-aarch64-linux-gnu-debug.tar.gz
 2e4a702b1d4f589cd9a1d6a0534eee7ddab725a9aa753b5a276510ee9b956ed94  guix-build-72a5aa9b791e/output/aarch64-linux-gnu/bitcoin-72a5aa9b791e-aarch64-linux-gnu.tar.gz
 3932b1525b03ed1ada4c148487ce5a81d9ec31a5cd1b2a516e2c0c0e2180abaa3  guix-build-72a5aa9b791e/output/arm-linux-gnueabihf/SHA256SUMS.part
 42dd2228cc4102af9f90c700647973f578848d3af3ec49027ade3eddad836af34  guix-build-72a5aa9b791e/output/arm-linux-gnueabihf/bitcoin-72a5aa9b791e-arm-linux-gnueabihf-debug.tar.gz
 5fe233069ab6bcca6530ce9cc38a59fbc635ce21d04cc97200498eb1dfad0168d  guix-build-72a5aa9b791e/output/arm-linux-gnueabihf/bitcoin-72a5aa9b791e-arm-linux-gnueabihf.tar.gz
 62f1227ff50f1df28ae2baf51c80ac4942880bbc964f8a71a8f4dde84abceb43d  guix-build-72a5aa9b791e/output/arm64-apple-darwin/SHA256SUMS.part
 79ba0698b5d72d79eb46283d4e4b339ac985c0893de381eb37e5191b15d73ccb8  guix-build-72a5aa9b791e/output/arm64-apple-darwin/bitcoin-72a5aa9b791e-arm64-apple-darwin-codesigning.tar.gz
 8c663093d1a4469bb4b1b6f97d46049933c6f7907179e41678d152fc7e2f63976  guix-build-72a5aa9b791e/output/arm64-apple-darwin/bitcoin-72a5aa9b791e-arm64-apple-darwin-unsigned.tar.gz
 970dcab6b6bcff534529163c594e81641b88e791b39739f940e322606f40cb477  guix-build-72a5aa9b791e/output/arm64-apple-darwin/bitcoin-72a5aa9b791e-arm64-apple-darwin-unsigned.zip
10e3ee49e0137cabb68c4729e7785fdb5413db12cc16939e0c4895bca22d826e4f  guix-build-72a5aa9b791e/output/dist-archive/bitcoin-72a5aa9b791e.tar.gz
11a710567c6dfd5a23b186b2bff2b83aa2b4d24341441809c2eb29d5e057fae699  guix-build-72a5aa9b791e/output/powerpc64-linux-gnu/SHA256SUMS.part
12d07a04f4ed1fa351149458a75968a375cbe8ebdd9f2c2ffa5e693e2def0e8b56  guix-build-72a5aa9b791e/output/powerpc64-linux-gnu/bitcoin-72a5aa9b791e-powerpc64-linux-gnu-debug.tar.gz
13379c4658237c4af0d6fda05370a2b91afa76a474d507c850467a4d2d06f6f971  guix-build-72a5aa9b791e/output/powerpc64-linux-gnu/bitcoin-72a5aa9b791e-powerpc64-linux-gnu.tar.gz
14936398a70a2295a8e09aaa680f373f1f0145b693bdfa546feed5cc03b7a7b660  guix-build-72a5aa9b791e/output/riscv64-linux-gnu/SHA256SUMS.part
15bcf10527a2570ba5e7092c0b221765c8c7bfe73e395e41dfeaf1d05fa5649c12  guix-build-72a5aa9b791e/output/riscv64-linux-gnu/bitcoin-72a5aa9b791e-riscv64-linux-gnu-debug.tar.gz
164524fe33bfa6cfae7ddbdf261cd8aac4d1f77209d91be8be8cdd0703f0baca30  guix-build-72a5aa9b791e/output/riscv64-linux-gnu/bitcoin-72a5aa9b791e-riscv64-linux-gnu.tar.gz
17a690c038b123c0e423ba13bc19b3f7b517af8a97e59a908fec59fc2ed489f65c  guix-build-72a5aa9b791e/output/x86_64-apple-darwin/SHA256SUMS.part
18067208849c2d8bb795324e240664263f6a5b6ffce6b51274ea2e3975b2689ff2  guix-build-72a5aa9b791e/output/x86_64-apple-darwin/bitcoin-72a5aa9b791e-x86_64-apple-darwin-codesigning.tar.gz
191b4fb21ddacae2f726e6269c3c7e0715e41df662a4f7a641012a65bb5d6aff56  guix-build-72a5aa9b791e/output/x86_64-apple-darwin/bitcoin-72a5aa9b791e-x86_64-apple-darwin-unsigned.tar.gz
200fd92858b06948bbf7dbbcd8212a3886919f6635955d093d050334fffe1fd094  guix-build-72a5aa9b791e/output/x86_64-apple-darwin/bitcoin-72a5aa9b791e-x86_64-apple-darwin-unsigned.zip
21886afc083f2c3d2c4a789ed0dd6f821b55160f12698ba0417777bd579d4d5972  guix-build-72a5aa9b791e/output/x86_64-linux-gnu/SHA256SUMS.part
225a950c6a5136d0dccb9873cb19c60bc5da809dd01bab1363513978a50a2fa1e1  guix-build-72a5aa9b791e/output/x86_64-linux-gnu/bitcoin-72a5aa9b791e-x86_64-linux-gnu-debug.tar.gz
233c8701c9eece02fdc493be0f158d254913dc9f7d3dcc744bbf0dc9fe260e5c16  guix-build-72a5aa9b791e/output/x86_64-linux-gnu/bitcoin-72a5aa9b791e-x86_64-linux-gnu.tar.gz
2424d116f4b39693a946e9d5375fa1569a74b7940ed656473f73ad2cb5eca6d89e  guix-build-72a5aa9b791e/output/x86_64-w64-mingw32/SHA256SUMS.part
258deb1c89c43a04e674989260a00356f7bbf952644d6a030d65bac5ecf2a27c25  guix-build-72a5aa9b791e/output/x86_64-w64-mingw32/bitcoin-72a5aa9b791e-win64-codesigning.tar.gz
260ac0e0772c6690448b96bb0f75c9e599835bb11a7b53c2c3a779f6194815bf94  guix-build-72a5aa9b791e/output/x86_64-w64-mingw32/bitcoin-72a5aa9b791e-win64-debug.zip
2755205c1943c1140c181dcf47f7535d9732f4b5066bea641783aac98fb1a1e2b9  guix-build-72a5aa9b791e/output/x86_64-w64-mingw32/bitcoin-72a5aa9b791e-win64-setup-unsigned.exe
2898e69fa9e113866fef39dfecd8c3578b57fbc126801035ab7aeaf7a730af95c7  guix-build-72a5aa9b791e/output/x86_64-w64-mingw32/bitcoin-72a5aa9b791e-win64-unsigned.zip

stickies-v approved

stickies-v commented at 11:02 am on June 2, 2025: contributor

ACK 72a5aa9b791e80a6204990c27c8165ce8aa81dd7

https://github.com/bitcoin/bitcoin/pull/31276/commits/319a4e82614283afb3dbc5d38ff3b9d17fb911b3 already removed the pkgconfig data (and as per my understanding, could have just removed the install-pkgconfigDATA target as an equivalent approach). Since the postprocess_cmds are executed right after the stage_cmds, my understanding is that nothing was done with the pkgconfig data, so simply not installing it makes sense.

Tested with depends build on arm macOS 15.4

hebasto commented at 11:33 am on June 2, 2025: member

My Guix build:

 0aarch64
 1545db2ab3bf28143eda2307089bb7266ae64802ea4a15371bacccf4574ee2c67  guix-build-72a5aa9b791e/output/aarch64-linux-gnu/SHA256SUMS.part
 2660030fb8c70d09e11f35e2ccdde4187f6bd90009bc1da2826be1cf8a73e6f4b  guix-build-72a5aa9b791e/output/aarch64-linux-gnu/bitcoin-72a5aa9b791e-aarch64-linux-gnu-debug.tar.gz
 3e4a702b1d4f589cd9a1d6a0534eee7ddab725a9aa753b5a276510ee9b956ed94  guix-build-72a5aa9b791e/output/aarch64-linux-gnu/bitcoin-72a5aa9b791e-aarch64-linux-gnu.tar.gz
 4932b1525b03ed1ada4c148487ce5a81d9ec31a5cd1b2a516e2c0c0e2180abaa3  guix-build-72a5aa9b791e/output/arm-linux-gnueabihf/SHA256SUMS.part
 52dd2228cc4102af9f90c700647973f578848d3af3ec49027ade3eddad836af34  guix-build-72a5aa9b791e/output/arm-linux-gnueabihf/bitcoin-72a5aa9b791e-arm-linux-gnueabihf-debug.tar.gz
 6fe233069ab6bcca6530ce9cc38a59fbc635ce21d04cc97200498eb1dfad0168d  guix-build-72a5aa9b791e/output/arm-linux-gnueabihf/bitcoin-72a5aa9b791e-arm-linux-gnueabihf.tar.gz
 72f1227ff50f1df28ae2baf51c80ac4942880bbc964f8a71a8f4dde84abceb43d  guix-build-72a5aa9b791e/output/arm64-apple-darwin/SHA256SUMS.part
 89ba0698b5d72d79eb46283d4e4b339ac985c0893de381eb37e5191b15d73ccb8  guix-build-72a5aa9b791e/output/arm64-apple-darwin/bitcoin-72a5aa9b791e-arm64-apple-darwin-codesigning.tar.gz
 9c663093d1a4469bb4b1b6f97d46049933c6f7907179e41678d152fc7e2f63976  guix-build-72a5aa9b791e/output/arm64-apple-darwin/bitcoin-72a5aa9b791e-arm64-apple-darwin-unsigned.tar.gz
1070dcab6b6bcff534529163c594e81641b88e791b39739f940e322606f40cb477  guix-build-72a5aa9b791e/output/arm64-apple-darwin/bitcoin-72a5aa9b791e-arm64-apple-darwin-unsigned.zip
11e3ee49e0137cabb68c4729e7785fdb5413db12cc16939e0c4895bca22d826e4f  guix-build-72a5aa9b791e/output/dist-archive/bitcoin-72a5aa9b791e.tar.gz
12a710567c6dfd5a23b186b2bff2b83aa2b4d24341441809c2eb29d5e057fae699  guix-build-72a5aa9b791e/output/powerpc64-linux-gnu/SHA256SUMS.part
13d07a04f4ed1fa351149458a75968a375cbe8ebdd9f2c2ffa5e693e2def0e8b56  guix-build-72a5aa9b791e/output/powerpc64-linux-gnu/bitcoin-72a5aa9b791e-powerpc64-linux-gnu-debug.tar.gz
14379c4658237c4af0d6fda05370a2b91afa76a474d507c850467a4d2d06f6f971  guix-build-72a5aa9b791e/output/powerpc64-linux-gnu/bitcoin-72a5aa9b791e-powerpc64-linux-gnu.tar.gz
15936398a70a2295a8e09aaa680f373f1f0145b693bdfa546feed5cc03b7a7b660  guix-build-72a5aa9b791e/output/riscv64-linux-gnu/SHA256SUMS.part
16bcf10527a2570ba5e7092c0b221765c8c7bfe73e395e41dfeaf1d05fa5649c12  guix-build-72a5aa9b791e/output/riscv64-linux-gnu/bitcoin-72a5aa9b791e-riscv64-linux-gnu-debug.tar.gz
174524fe33bfa6cfae7ddbdf261cd8aac4d1f77209d91be8be8cdd0703f0baca30  guix-build-72a5aa9b791e/output/riscv64-linux-gnu/bitcoin-72a5aa9b791e-riscv64-linux-gnu.tar.gz
18a690c038b123c0e423ba13bc19b3f7b517af8a97e59a908fec59fc2ed489f65c  guix-build-72a5aa9b791e/output/x86_64-apple-darwin/SHA256SUMS.part
19067208849c2d8bb795324e240664263f6a5b6ffce6b51274ea2e3975b2689ff2  guix-build-72a5aa9b791e/output/x86_64-apple-darwin/bitcoin-72a5aa9b791e-x86_64-apple-darwin-codesigning.tar.gz
201b4fb21ddacae2f726e6269c3c7e0715e41df662a4f7a641012a65bb5d6aff56  guix-build-72a5aa9b791e/output/x86_64-apple-darwin/bitcoin-72a5aa9b791e-x86_64-apple-darwin-unsigned.tar.gz
210fd92858b06948bbf7dbbcd8212a3886919f6635955d093d050334fffe1fd094  guix-build-72a5aa9b791e/output/x86_64-apple-darwin/bitcoin-72a5aa9b791e-x86_64-apple-darwin-unsigned.zip
22886afc083f2c3d2c4a789ed0dd6f821b55160f12698ba0417777bd579d4d5972  guix-build-72a5aa9b791e/output/x86_64-linux-gnu/SHA256SUMS.part
235a950c6a5136d0dccb9873cb19c60bc5da809dd01bab1363513978a50a2fa1e1  guix-build-72a5aa9b791e/output/x86_64-linux-gnu/bitcoin-72a5aa9b791e-x86_64-linux-gnu-debug.tar.gz
243c8701c9eece02fdc493be0f158d254913dc9f7d3dcc744bbf0dc9fe260e5c16  guix-build-72a5aa9b791e/output/x86_64-linux-gnu/bitcoin-72a5aa9b791e-x86_64-linux-gnu.tar.gz
2524d116f4b39693a946e9d5375fa1569a74b7940ed656473f73ad2cb5eca6d89e  guix-build-72a5aa9b791e/output/x86_64-w64-mingw32/SHA256SUMS.part
268deb1c89c43a04e674989260a00356f7bbf952644d6a030d65bac5ecf2a27c25  guix-build-72a5aa9b791e/output/x86_64-w64-mingw32/bitcoin-72a5aa9b791e-win64-codesigning.tar.gz
270ac0e0772c6690448b96bb0f75c9e599835bb11a7b53c2c3a779f6194815bf94  guix-build-72a5aa9b791e/output/x86_64-w64-mingw32/bitcoin-72a5aa9b791e-win64-debug.zip
2855205c1943c1140c181dcf47f7535d9732f4b5066bea641783aac98fb1a1e2b9  guix-build-72a5aa9b791e/output/x86_64-w64-mingw32/bitcoin-72a5aa9b791e-win64-setup-unsigned.exe
2998e69fa9e113866fef39dfecd8c3578b57fbc126801035ab7aeaf7a730af95c7  guix-build-72a5aa9b791e/output/x86_64-w64-mingw32/bitcoin-72a5aa9b791e-win64-unsigned.zip

hebasto approved

hebasto commented at 11:34 am on June 2, 2025: member

ACK 72a5aa9b791e80a6204990c27c8165ce8aa81dd7.

hebasto merged this on Jun 2, 2025

hebasto closed this on Jun 2, 2025

fanquake deleted the branch on Jun 2, 2025

DrahtBot commented at 4:13 pm on June 2, 2025: contributor

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

File	commit 4b1d48a6866b24f0ed027334c6de642fc848d083(master)	commit 4f94b079085cbefa386787d174a255c34de181d6(pull/32656/merge)
*-aarch64-linux-gnu-debug.tar.gz	`7dc7cb89e7bbf42d...`	`12de3b0082d078b8...`
*-aarch64-linux-gnu.tar.gz	`425126e4ccf5257f...`	`334b48912a194224...`
*-arm-linux-gnueabihf-debug.tar.gz	`3582ec369041e254...`	`08ee9a4fabd06a6d...`
*-arm-linux-gnueabihf.tar.gz	`f738338fcedc3ceb...`	`9ab7eec6f4bab9a1...`
*-arm64-apple-darwin-codesigning.tar.gz	`9eebcf700ff666a8...`	`07ff5f42fa9efcee...`
*-arm64-apple-darwin-unsigned.tar.gz	`bfddbbfbe355b1e9...`	`a662f8861d41cda0...`
*-arm64-apple-darwin-unsigned.zip	`2d6fda65a92b0e82...`	`2aa706f6e2f15ada...`
*-powerpc64-linux-gnu-debug.tar.gz	`00f95bc1c916660a...`	`e2d949c5575ecad6...`
*-powerpc64-linux-gnu.tar.gz	`f251ea1996713695...`	`3c0bf1f74fb19675...`
*-riscv64-linux-gnu-debug.tar.gz	`69dc8b9738b62d29...`	`e6d4783493d230e5...`
*-riscv64-linux-gnu.tar.gz	`43fc5a99a3eb80d2...`	`c3ab1a610db6c8c1...`
*-x86_64-apple-darwin-codesigning.tar.gz	`5cf98fd506507cda...`	`fd3456417e8d5d43...`
*-x86_64-apple-darwin-unsigned.tar.gz	`0ab847ab9d5b48be...`	`0ba03b0245ce285b...`
*-x86_64-apple-darwin-unsigned.zip	`a9d88cae658eec38...`	`0b3a95064e446d25...`
*-x86_64-linux-gnu-debug.tar.gz	`f5d87ca6b1711a44...`	`f0d6906802c6e7fd...`
*-x86_64-linux-gnu.tar.gz	`03d65ea0ccbbca10...`	`57c63f7926ca910e...`
*.tar.gz	`0448ee4c965fc375...`	`f16b49bc13326c78...`
SHA256SUMS.part	`7bd38f6418ed1d02...`	`4133132b9971f383...`
guix_build.log	`2422eedfaa000e1a...`	`760cadafd8341d36...`
guix_build.log.diff		`de8707e16add52f3...`

DrahtBot removed the label DrahtBot Guix build requested on Jun 2, 2025

depends: don’t install & then delete sqlite pkgconf #32656

Code Coverage & Benchmarks

Reviews

Conflicts

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]