depends: Bump boost to 1.88.0 and use new CMake buildsystem

fanquake commented at 4:46 pm on June 2, 2025: member

Originally #30434.

This has a few advantages over the old method of simply copying headers:

Installs proper CMake files which can be picked up by our buildsystem
Only installs necessary headers, not all of Boost

Pulls in upstreamed https://github.com/boostorg/test/pull/445.

DrahtBot commented at 4:46 pm on June 2, 2025: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32665.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	willcl-ark, hebasto
Concept ACK	yuvicc

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

DrahtBot added the label Build system on Jun 2, 2025

fanquake added the label DrahtBot Guix build requested on Jun 2, 2025

hebasto commented at 4:48 pm on June 2, 2025: member

Concept ACK.

theuni commented at 7:27 pm on June 2, 2025: member

Nice! Good work, @hebasto :)

in depends/packages/boost.mk:12 in 3a350c8a1b outdated

11+$(package)_build_subdir = build
12+
13+define $(package)_set_vars
14+  $(package)_config_opts = -DBOOST_INCLUDE_LIBRARIES="multi_index;signals2;test"
15+  $(package)_config_opts += -DBOOST_TEST_HEADERS_ONLY=ON
16+  $(package)_config_opts += -DBOOST_ENABLE_MPI=OFF

theuni commented at 7:28 pm on June 2, 2025:

Do these defines actually do anything in our case, or are they just here for the sake of being explicit?

hebasto commented at 8:41 pm on June 2, 2025:

The latter.

hebasto approved

hebasto commented at 8:23 pm on June 2, 2025: member

My Guix build:

 0aarch64
 132f567efe7c9d428083d9eab15e9fb215e2860132b3a31a60f288d21d3ed3644  guix-build-3a350c8a1b51/output/aarch64-linux-gnu/SHA256SUMS.part
 213bfeec126cef80d97a7b90f9cec32962cce8b3bbf445006f1233e1b45a74d43  guix-build-3a350c8a1b51/output/aarch64-linux-gnu/bitcoin-3a350c8a1b51-aarch64-linux-gnu-debug.tar.gz
 322b967a5fdcc39fb999e9e30ac74b18509048f8918ddf08ab8a1de47bd587565  guix-build-3a350c8a1b51/output/aarch64-linux-gnu/bitcoin-3a350c8a1b51-aarch64-linux-gnu.tar.gz
 43ce046806a4590d3b8f0b552e66b40e35bb863d91c71315a2298abc9c83ebc63  guix-build-3a350c8a1b51/output/arm-linux-gnueabihf/SHA256SUMS.part
 564a30da6f4adfb545a3a8494c41b9e9a8a9c67d1ccee10fe271e30cd9da4570a  guix-build-3a350c8a1b51/output/arm-linux-gnueabihf/bitcoin-3a350c8a1b51-arm-linux-gnueabihf-debug.tar.gz
 61389706705bf07a52d6dbaf4b3815c2ab8a5e176f4e0444055a972276c82e349  guix-build-3a350c8a1b51/output/arm-linux-gnueabihf/bitcoin-3a350c8a1b51-arm-linux-gnueabihf.tar.gz
 78e41056973a93c499909cff874f43f09a655c6de76f7819763c40284b7e98135  guix-build-3a350c8a1b51/output/arm64-apple-darwin/SHA256SUMS.part
 804cc76b71e5739a9bf68c4ee55d007c27b3fdbf6be9148a12cbc66ded4a69dfd  guix-build-3a350c8a1b51/output/arm64-apple-darwin/bitcoin-3a350c8a1b51-arm64-apple-darwin-codesigning.tar.gz
 92f989cd1c681670c95d60cdb911d229d9f6f3041ee2ae8f329e383a3de518023  guix-build-3a350c8a1b51/output/arm64-apple-darwin/bitcoin-3a350c8a1b51-arm64-apple-darwin-unsigned.tar.gz
10b24133186d97073d48b45337389fc1f01baf5cdd10468decef693244cc4ec08b  guix-build-3a350c8a1b51/output/arm64-apple-darwin/bitcoin-3a350c8a1b51-arm64-apple-darwin-unsigned.zip
11d9f039b22b2f453652b7e8f6442fb884b9a03e0130dda6dd313dcf0d65ebcf04  guix-build-3a350c8a1b51/output/dist-archive/bitcoin-3a350c8a1b51.tar.gz
12f3278d72bf43d088b2a8234e9f26d33e14fbe6ef372777d58fc61b81826d40d1  guix-build-3a350c8a1b51/output/powerpc64-linux-gnu/SHA256SUMS.part
1309167e1eb66f133e626811c9511892af2bc639b475c1dcf198fe914ddf74a6a2  guix-build-3a350c8a1b51/output/powerpc64-linux-gnu/bitcoin-3a350c8a1b51-powerpc64-linux-gnu-debug.tar.gz
146c39e3b9b0cf0bd5a77f72d4fa1049caeb72317e9d1a351159be79fcc531ec55  guix-build-3a350c8a1b51/output/powerpc64-linux-gnu/bitcoin-3a350c8a1b51-powerpc64-linux-gnu.tar.gz
15852c17d334284a44fbb51080e3aa02108025a1fc21121ee450287d99885d4063  guix-build-3a350c8a1b51/output/riscv64-linux-gnu/SHA256SUMS.part
1645f8d6be242775ffecbdb1629ed01064ac52b5840051922672b925d8a34d89a5  guix-build-3a350c8a1b51/output/riscv64-linux-gnu/bitcoin-3a350c8a1b51-riscv64-linux-gnu-debug.tar.gz
1792e83f8986e72029bd2516f47ccce1767afabd55e052103f3110634a89bf400a  guix-build-3a350c8a1b51/output/riscv64-linux-gnu/bitcoin-3a350c8a1b51-riscv64-linux-gnu.tar.gz
180ee78ec8edf3c8a5e25b46c7664735ccfeb7d1f97ff547193058eb29f222f2c0  guix-build-3a350c8a1b51/output/x86_64-apple-darwin/SHA256SUMS.part
191e107c772bd8dcebe4baad8171f9897b854d09a7c00c8e05cc1ca3c2f3f44b26  guix-build-3a350c8a1b51/output/x86_64-apple-darwin/bitcoin-3a350c8a1b51-x86_64-apple-darwin-codesigning.tar.gz
203ee342696262d82f9afa2e9d386c37b909323b83414e1190c8ecf43646cf1918  guix-build-3a350c8a1b51/output/x86_64-apple-darwin/bitcoin-3a350c8a1b51-x86_64-apple-darwin-unsigned.tar.gz
21ce5518781ee1b441d5474dca2b65976d23ede28bb6d5e12cb4065650faffc672  guix-build-3a350c8a1b51/output/x86_64-apple-darwin/bitcoin-3a350c8a1b51-x86_64-apple-darwin-unsigned.zip
2233f01de944f7d07fe170be6332ec5639caa94ef6d77648c92e9b3d48aee16d83  guix-build-3a350c8a1b51/output/x86_64-linux-gnu/SHA256SUMS.part
237ca28c6e18ced70ae24f29e6faa167df684c3aa3dc348890248db5f04434cffa  guix-build-3a350c8a1b51/output/x86_64-linux-gnu/bitcoin-3a350c8a1b51-x86_64-linux-gnu-debug.tar.gz
24afaedff91f66938e856c7a61e4bf992234cb9c68fbd2e9045ea0fd70c48938b9  guix-build-3a350c8a1b51/output/x86_64-linux-gnu/bitcoin-3a350c8a1b51-x86_64-linux-gnu.tar.gz
25bac68896acc74695d57cff927b022da6871e3ece6ca8c3b520b967932993f775  guix-build-3a350c8a1b51/output/x86_64-w64-mingw32/SHA256SUMS.part
261c96c852396554215df480dce868b208801f52da9dfd1a6df5642ce570351d19  guix-build-3a350c8a1b51/output/x86_64-w64-mingw32/bitcoin-3a350c8a1b51-win64-codesigning.tar.gz
274219ec869d94e8648f90d1831c50f350a2d39075b6e8ab7483320b69b6c26c75  guix-build-3a350c8a1b51/output/x86_64-w64-mingw32/bitcoin-3a350c8a1b51-win64-debug.zip
284cfa30516dd9afbdf4e8c7b62625dcc8afcfe4d7071aac0bad28274993df0cf6  guix-build-3a350c8a1b51/output/x86_64-w64-mingw32/bitcoin-3a350c8a1b51-win64-setup-unsigned.exe
29c95fe8d71ae65658a62bbc3e23bfcf86957222f84be2948fe1907302c2303284  guix-build-3a350c8a1b51/output/x86_64-w64-mingw32/bitcoin-3a350c8a1b51-win64-unsigned.zip

willcl-ark commented at 8:53 pm on June 2, 2025: member

Would we not want to bump the boost version in AddBoostIfNeeded.cmake too?

in depends/packages/boost.mk:10 in 3a350c8a1b outdated

 9+$(package)_sha256_hash = dcea50f40ba1ecfc448fdf886c0165cf3e525fef2c9e3e080b9804e8117b9694
10+$(package)_patches = skip_compiled_targets.patch
11+$(package)_build_subdir = build
12+
13+define $(package)_set_vars
14+  $(package)_config_opts = -DBOOST_INCLUDE_LIBRARIES="multi_index;signals2;test"

hebasto commented at 10:07 pm on June 2, 2025:

Did I forget to explicitly mention the tuple library?

See: https://github.com/bitcoin/bitcoin/blob/f999c3775c12ef732a1920dd52257a8cd34cdcc8/src/txrequest.cpp#L18

theuni commented at 11:06 pm on June 2, 2025:

multi_index drags in a ton of header-only libs, CMake takes care of installing its dependencies. Is tuple a problem for some reason?

theuni commented at 11:10 pm on June 2, 2025:

That include should be perfectly safe to remove, btw. It’s included by (at least) boost/multi_index/sequenced_index.hpp.

fanquake commented at 7:30 am on June 3, 2025:

multi_index drags in a ton of header-only libs,

Yea. We still end up with a huge amount of libraries. I’m guessing these some changes we could upstream to try and cut down the dependency graph.

hebasto commented at 10:33 pm on June 2, 2025: member

Would we not want to bump the boost version in AddBoostIfNeeded.cmake too?

The minimum supported Boost version is a separate concern from the Boost version used in depends.

It warrants its own PR, including an analysis of available packages on supported systems.

fanquake commented at 7:30 am on June 3, 2025: member

Would we not want to bump the boost version in AddBoostIfNeeded.cmake too?

Sure, we can look at doing that too, while making other related changes.

DrahtBot commented at 7:38 am on June 3, 2025: contributor

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

File	commit 2d819fa4dff977fe3f57ddacc28719c7247c7d6f(master)	commit 672627567d520cf10ec7415b0ce378b394f93faa(pull/32665/merge)
*-aarch64-linux-gnu-debug.tar.gz	`2aab5228fb09cac1...`	`0c690cb0ebab33b5...`
*-aarch64-linux-gnu.tar.gz	`ae04251340ab8b4d...`	`88ec6128462b5c34...`
*-arm-linux-gnueabihf-debug.tar.gz	`c7050ab4c3586f04...`	`e2b8986960de57e1...`
*-arm-linux-gnueabihf.tar.gz	`0970edde785d59ab...`	`109236c76ef76176...`
*-arm64-apple-darwin-codesigning.tar.gz	`b46384036ec92d9a...`	`117858eacb124d99...`
*-arm64-apple-darwin-unsigned.tar.gz	`c8c39cbb9838fad0...`	`df465dfb6e931c98...`
*-arm64-apple-darwin-unsigned.zip	`86e6781fc3a2db20...`	`83ab68e381833325...`
*-powerpc64-linux-gnu-debug.tar.gz	`fba4df5398cb8b5f...`	`34045d48e7ff6968...`
*-powerpc64-linux-gnu.tar.gz	`eab51da1676dc87f...`	`3d25bd3362887a77...`
*-riscv64-linux-gnu-debug.tar.gz	`6e72285b5a8b93c3...`	`dc1c2db7a302989b...`
*-riscv64-linux-gnu.tar.gz	`ae83088a81eaa56d...`	`04c0072922bcc12c...`
*-x86_64-apple-darwin-codesigning.tar.gz	`9aa55dcb66514cde...`	`378208dd21add050...`
*-x86_64-apple-darwin-unsigned.tar.gz	`d122b5473f497ba1...`	`f9de94f6cd9fdece...`
*-x86_64-apple-darwin-unsigned.zip	`5361ab85e4bd61a6...`	`fb5703693ce01a1f...`
*-x86_64-linux-gnu-debug.tar.gz	`94480edb5c34dc88...`	`55275ba50f553dc9...`
*-x86_64-linux-gnu.tar.gz	`4b78257576c959d2...`	`39a893b51bcd14c7...`
*.tar.gz	`6070851b67ef9063...`	`e05316bd374ffe8c...`
SHA256SUMS.part	`058e34ba7960a953...`	`4d76f82ce4a3555d...`
guix_build.log	`db0d49019c5a01ff...`	`d85efaaa3218ddcb...`
guix_build.log.diff		`1082f73cdedd8b29...`

DrahtBot removed the label DrahtBot Guix build requested on Jun 3, 2025

hebasto approved

hebasto commented at 8:05 am on June 3, 2025: member

ACK 3a350c8a1b51e140e2689e10dca338470e8deef2.

yuvicc commented at 12:21 pm on June 3, 2025: contributor

Concept ACK

willcl-ark approved

willcl-ark commented at 1:02 pm on June 3, 2025: member

ACK 3a350c8a1b51e140e2689e10dca338470e8deef2

Tested that this works. I additionally tested rebasing #32595 on it, where it also works well.

willcl-ark commented at 1:03 pm on June 3, 2025: member

guix hashes:

 0src/core/bitcoin on  pr-32665 [$] via △ v3.31.6 via 🐍 v3.12.10 via ❄️  impure (nix-shell-env) took 50m49s
 1❯ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
 232f567efe7c9d428083d9eab15e9fb215e2860132b3a31a60f288d21d3ed3644  guix-build-3a350c8a1b51/output/aarch64-linux-gnu/SHA256SUMS.part
 313bfeec126cef80d97a7b90f9cec32962cce8b3bbf445006f1233e1b45a74d43  guix-build-3a350c8a1b51/output/aarch64-linux-gnu/bitcoin-3a350c8a1b51-aarch64-linux-gnu-debug.tar.gz
 422b967a5fdcc39fb999e9e30ac74b18509048f8918ddf08ab8a1de47bd587565  guix-build-3a350c8a1b51/output/aarch64-linux-gnu/bitcoin-3a350c8a1b51-aarch64-linux-gnu.tar.gz
 53ce046806a4590d3b8f0b552e66b40e35bb863d91c71315a2298abc9c83ebc63  guix-build-3a350c8a1b51/output/arm-linux-gnueabihf/SHA256SUMS.part
 664a30da6f4adfb545a3a8494c41b9e9a8a9c67d1ccee10fe271e30cd9da4570a  guix-build-3a350c8a1b51/output/arm-linux-gnueabihf/bitcoin-3a350c8a1b51-arm-linux-gnueabihf-debug.tar.gz
 71389706705bf07a52d6dbaf4b3815c2ab8a5e176f4e0444055a972276c82e349  guix-build-3a350c8a1b51/output/arm-linux-gnueabihf/bitcoin-3a350c8a1b51-arm-linux-gnueabihf.tar.gz
 88e41056973a93c499909cff874f43f09a655c6de76f7819763c40284b7e98135  guix-build-3a350c8a1b51/output/arm64-apple-darwin/SHA256SUMS.part
 904cc76b71e5739a9bf68c4ee55d007c27b3fdbf6be9148a12cbc66ded4a69dfd  guix-build-3a350c8a1b51/output/arm64-apple-darwin/bitcoin-3a350c8a1b51-arm64-apple-darwin-codesigning.tar.gz
102f989cd1c681670c95d60cdb911d229d9f6f3041ee2ae8f329e383a3de518023  guix-build-3a350c8a1b51/output/arm64-apple-darwin/bitcoin-3a350c8a1b51-arm64-apple-darwin-unsigned.tar.gz
11b24133186d97073d48b45337389fc1f01baf5cdd10468decef693244cc4ec08b  guix-build-3a350c8a1b51/output/arm64-apple-darwin/bitcoin-3a350c8a1b51-arm64-apple-darwin-unsigned.zip
12d9f039b22b2f453652b7e8f6442fb884b9a03e0130dda6dd313dcf0d65ebcf04  guix-build-3a350c8a1b51/output/dist-archive/bitcoin-3a350c8a1b51.tar.gz
13f3278d72bf43d088b2a8234e9f26d33e14fbe6ef372777d58fc61b81826d40d1  guix-build-3a350c8a1b51/output/powerpc64-linux-gnu/SHA256SUMS.part
1409167e1eb66f133e626811c9511892af2bc639b475c1dcf198fe914ddf74a6a2  guix-build-3a350c8a1b51/output/powerpc64-linux-gnu/bitcoin-3a350c8a1b51-powerpc64-linux-gnu-debug.tar.gz
156c39e3b9b0cf0bd5a77f72d4fa1049caeb72317e9d1a351159be79fcc531ec55  guix-build-3a350c8a1b51/output/powerpc64-linux-gnu/bitcoin-3a350c8a1b51-powerpc64-linux-gnu.tar.gz
16852c17d334284a44fbb51080e3aa02108025a1fc21121ee450287d99885d4063  guix-build-3a350c8a1b51/output/riscv64-linux-gnu/SHA256SUMS.part
1745f8d6be242775ffecbdb1629ed01064ac52b5840051922672b925d8a34d89a5  guix-build-3a350c8a1b51/output/riscv64-linux-gnu/bitcoin-3a350c8a1b51-riscv64-linux-gnu-debug.tar.gz
1892e83f8986e72029bd2516f47ccce1767afabd55e052103f3110634a89bf400a  guix-build-3a350c8a1b51/output/riscv64-linux-gnu/bitcoin-3a350c8a1b51-riscv64-linux-gnu.tar.gz
190ee78ec8edf3c8a5e25b46c7664735ccfeb7d1f97ff547193058eb29f222f2c0  guix-build-3a350c8a1b51/output/x86_64-apple-darwin/SHA256SUMS.part
201e107c772bd8dcebe4baad8171f9897b854d09a7c00c8e05cc1ca3c2f3f44b26  guix-build-3a350c8a1b51/output/x86_64-apple-darwin/bitcoin-3a350c8a1b51-x86_64-apple-darwin-codesigning.tar.gz
213ee342696262d82f9afa2e9d386c37b909323b83414e1190c8ecf43646cf1918  guix-build-3a350c8a1b51/output/x86_64-apple-darwin/bitcoin-3a350c8a1b51-x86_64-apple-darwin-unsigned.tar.gz
22ce5518781ee1b441d5474dca2b65976d23ede28bb6d5e12cb4065650faffc672  guix-build-3a350c8a1b51/output/x86_64-apple-darwin/bitcoin-3a350c8a1b51-x86_64-apple-darwin-unsigned.zip
2333f01de944f7d07fe170be6332ec5639caa94ef6d77648c92e9b3d48aee16d83  guix-build-3a350c8a1b51/output/x86_64-linux-gnu/SHA256SUMS.part
247ca28c6e18ced70ae24f29e6faa167df684c3aa3dc348890248db5f04434cffa  guix-build-3a350c8a1b51/output/x86_64-linux-gnu/bitcoin-3a350c8a1b51-x86_64-linux-gnu-debug.tar.gz
25afaedff91f66938e856c7a61e4bf992234cb9c68fbd2e9045ea0fd70c48938b9  guix-build-3a350c8a1b51/output/x86_64-linux-gnu/bitcoin-3a350c8a1b51-x86_64-linux-gnu.tar.gz
26bac68896acc74695d57cff927b022da6871e3ece6ca8c3b520b967932993f775  guix-build-3a350c8a1b51/output/x86_64-w64-mingw32/SHA256SUMS.part
271c96c852396554215df480dce868b208801f52da9dfd1a6df5642ce570351d19  guix-build-3a350c8a1b51/output/x86_64-w64-mingw32/bitcoin-3a350c8a1b51-win64-codesigning.tar.gz
284219ec869d94e8648f90d1831c50f350a2d39075b6e8ab7483320b69b6c26c75  guix-build-3a350c8a1b51/output/x86_64-w64-mingw32/bitcoin-3a350c8a1b51-win64-debug.zip
294cfa30516dd9afbdf4e8c7b62625dcc8afcfe4d7071aac0bad28274993df0cf6  guix-build-3a350c8a1b51/output/x86_64-w64-mingw32/bitcoin-3a350c8a1b51-win64-setup-unsigned.exe
30c95fe8d71ae65658a62bbc3e23bfcf86957222f84be2948fe1907302c2303284  guix-build-3a350c8a1b51/output/x86_64-w64-mingw32/bitcoin-3a350c8a1b51-win64-unsigned.zip

hebasto commented at 10:18 am on June 9, 2025: member

cc @theuni

depends: Bump boost to 1.88.0 and use new CMake buildsystem

This has a few advantages over the old method of simply copying headers:
- Installs proper cmake files which can be picked up by our buildsystem
- Only installs necessary headers, not all of boost

Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>

6c2538d5bf

fanquake force-pushed on Jun 25, 2025

fanquake added this to the milestone 30.0 on Jun 25, 2025

willcl-ark approved

willcl-ark commented at 2:45 pm on June 25, 2025: member

tACK 6c2538d5bfe

Based on git range-diff 3a350c8a1b5...6c2538d5bfe (which just picks up recently-merged commits).

Tested that this builds from depends successfully on NixOS.

DrahtBot requested review from hebasto on Jun 25, 2025

hebasto approved

hebasto commented at 4:52 pm on June 25, 2025: member

re-ACK 6c2538d5bfeafe6f234e5382c151d173826d78f0, only rebased since my previous review.

hebasto commented at 6:29 pm on June 25, 2025: member

My Guix build:

 0aarch64
 1dcedbdafa5857dbbb7748e27bbbfadc57a5dc70eff9b565c1d30061e64027ca4  guix-build-6c2538d5bfea/output/aarch64-linux-gnu/SHA256SUMS.part
 2ccf56c678924e933ef46f306d0be509251d1920f17529e11f007a5c0b74a5282  guix-build-6c2538d5bfea/output/aarch64-linux-gnu/bitcoin-6c2538d5bfea-aarch64-linux-gnu-debug.tar.gz
 3550fa33f9e19c06cf4651abd4e69d813db6702461b6b59b717a719821c8b6495  guix-build-6c2538d5bfea/output/aarch64-linux-gnu/bitcoin-6c2538d5bfea-aarch64-linux-gnu.tar.gz
 4aab708c38da0b9e011613a9e473b2336a789863c8bdbb4cbf8f7a1639b8413ef  guix-build-6c2538d5bfea/output/arm-linux-gnueabihf/SHA256SUMS.part
 5f3be15e0cfc0d5523ed0935463d73e0e9bd1e3f15469b9fc8bf2cef40806e226  guix-build-6c2538d5bfea/output/arm-linux-gnueabihf/bitcoin-6c2538d5bfea-arm-linux-gnueabihf-debug.tar.gz
 655fc33fd0816ae21fd3434f558a5a237450d2d140bb594384d62b02560087c40  guix-build-6c2538d5bfea/output/arm-linux-gnueabihf/bitcoin-6c2538d5bfea-arm-linux-gnueabihf.tar.gz
 7194f28d6a7e4dc41be94ae0e2a641cd99e7ce65c120ba155d4862424ccd9064f  guix-build-6c2538d5bfea/output/arm64-apple-darwin/SHA256SUMS.part
 85f5de2ba99f5f78c1dc4e179d1cdb18459c1d9ac23c8261cc8ded3835f52b006  guix-build-6c2538d5bfea/output/arm64-apple-darwin/bitcoin-6c2538d5bfea-arm64-apple-darwin-codesigning.tar.gz
 9719b1b2cf2564905c2eee8d0158b67236b43901590c5f8e23856ce00bc5a3a84  guix-build-6c2538d5bfea/output/arm64-apple-darwin/bitcoin-6c2538d5bfea-arm64-apple-darwin-unsigned.tar.gz
1043a8b2949ca75f4f1a11405c1254208514b7f8bd10cb3b60bb7f5ddcc7fc1314  guix-build-6c2538d5bfea/output/arm64-apple-darwin/bitcoin-6c2538d5bfea-arm64-apple-darwin-unsigned.zip
118a3488b3a87529b8eedc5c995eca948c404e7675b051d1c420c52b8850d926c5  guix-build-6c2538d5bfea/output/dist-archive/bitcoin-6c2538d5bfea.tar.gz
12cd067c2fadb0dc319ce36eb9d74c59b7de3edd669bde3b3378fcfd60f9755f51  guix-build-6c2538d5bfea/output/powerpc64-linux-gnu/SHA256SUMS.part
13dfec7e31a665cb105c644d6a970de017005ab3981b0634f9b9b0b9d8f378d9b5  guix-build-6c2538d5bfea/output/powerpc64-linux-gnu/bitcoin-6c2538d5bfea-powerpc64-linux-gnu-debug.tar.gz
1486f9a231e72004173aceb9dbbe9a0150603b804f71aa9f84196e49d09d56d348  guix-build-6c2538d5bfea/output/powerpc64-linux-gnu/bitcoin-6c2538d5bfea-powerpc64-linux-gnu.tar.gz
157c346668d1883657993801b203315b6a0f8a6ee6053a3d67c973d4fbee4c3e30  guix-build-6c2538d5bfea/output/riscv64-linux-gnu/SHA256SUMS.part
16cb0f43cdb631e6bc6942dfe98015de715e3af4ce5c188f9bfcff4a14e65b7943  guix-build-6c2538d5bfea/output/riscv64-linux-gnu/bitcoin-6c2538d5bfea-riscv64-linux-gnu-debug.tar.gz
1717460975b7f544c08b3e1a4db5395b5121835c8af6aee735dc6ca6004844e999  guix-build-6c2538d5bfea/output/riscv64-linux-gnu/bitcoin-6c2538d5bfea-riscv64-linux-gnu.tar.gz
18b0250a70578b73f8df85c56e1cda24bc5588533b6d6dacf64813874d6f34f894  guix-build-6c2538d5bfea/output/x86_64-apple-darwin/SHA256SUMS.part
196a3d22119375590bf13daf74ad906bc975eb97ded1c7fe7a7b5c1aed856f3aeb  guix-build-6c2538d5bfea/output/x86_64-apple-darwin/bitcoin-6c2538d5bfea-x86_64-apple-darwin-codesigning.tar.gz
20684fccb02f87b2051dd5be4505d35746fa97aa2fdb266a86ea16089734afc05e  guix-build-6c2538d5bfea/output/x86_64-apple-darwin/bitcoin-6c2538d5bfea-x86_64-apple-darwin-unsigned.tar.gz
21144b5a6cdfe0f55de97c8aa267f1e4f7cfacb16ea263bf0ef8a3c57c3e3a2ebc  guix-build-6c2538d5bfea/output/x86_64-apple-darwin/bitcoin-6c2538d5bfea-x86_64-apple-darwin-unsigned.zip
2266b0ba4a510b572d227deb34a89d87d918ea9d0b4bc21376327d84686082e925  guix-build-6c2538d5bfea/output/x86_64-linux-gnu/SHA256SUMS.part
2374a18d40bd76cd6ebc20334171ecb7871371755f843184fd0be4427c6a9ee2db  guix-build-6c2538d5bfea/output/x86_64-linux-gnu/bitcoin-6c2538d5bfea-x86_64-linux-gnu-debug.tar.gz
24688274471e566ce932a6f96161ee52373ff0e31a8d438f6a1c4f49c52612fa11  guix-build-6c2538d5bfea/output/x86_64-linux-gnu/bitcoin-6c2538d5bfea-x86_64-linux-gnu.tar.gz
251e04b38dbdbf40349f7a53ebebb66c730431a6d5b4be0080b733437371956243  guix-build-6c2538d5bfea/output/x86_64-w64-mingw32/SHA256SUMS.part
262a9aa57169de2e2ad4354bc00bf798e42dc7d673e68de03b2392296765965445  guix-build-6c2538d5bfea/output/x86_64-w64-mingw32/bitcoin-6c2538d5bfea-win64-codesigning.tar.gz
27c1b5d0fa9514bd91815fc2b223967ce585f9311fbf3ecdf132bf4ad8f9de9d21  guix-build-6c2538d5bfea/output/x86_64-w64-mingw32/bitcoin-6c2538d5bfea-win64-debug.zip
284f4970a4d9645b42f1ec572325e96f0840e6f8bc773dd7b41074201b7e3848ab  guix-build-6c2538d5bfea/output/x86_64-w64-mingw32/bitcoin-6c2538d5bfea-win64-setup-unsigned.exe
2911954cea6ea7f218e0c9d7373286c950e84d0b2dd9e18b7c7ca3321314ccc101  guix-build-6c2538d5bfea/output/x86_64-w64-mingw32/bitcoin-6c2538d5bfea-win64-unsigned.zip

fanquake commented at 9:14 am on June 26, 2025: member

Guix Build:

 0dcedbdafa5857dbbb7748e27bbbfadc57a5dc70eff9b565c1d30061e64027ca4  guix-build-6c2538d5bfea/output/aarch64-linux-gnu/SHA256SUMS.part
 1ccf56c678924e933ef46f306d0be509251d1920f17529e11f007a5c0b74a5282  guix-build-6c2538d5bfea/output/aarch64-linux-gnu/bitcoin-6c2538d5bfea-aarch64-linux-gnu-debug.tar.gz
 2550fa33f9e19c06cf4651abd4e69d813db6702461b6b59b717a719821c8b6495  guix-build-6c2538d5bfea/output/aarch64-linux-gnu/bitcoin-6c2538d5bfea-aarch64-linux-gnu.tar.gz
 3aab708c38da0b9e011613a9e473b2336a789863c8bdbb4cbf8f7a1639b8413ef  guix-build-6c2538d5bfea/output/arm-linux-gnueabihf/SHA256SUMS.part
 4f3be15e0cfc0d5523ed0935463d73e0e9bd1e3f15469b9fc8bf2cef40806e226  guix-build-6c2538d5bfea/output/arm-linux-gnueabihf/bitcoin-6c2538d5bfea-arm-linux-gnueabihf-debug.tar.gz
 555fc33fd0816ae21fd3434f558a5a237450d2d140bb594384d62b02560087c40  guix-build-6c2538d5bfea/output/arm-linux-gnueabihf/bitcoin-6c2538d5bfea-arm-linux-gnueabihf.tar.gz
 6194f28d6a7e4dc41be94ae0e2a641cd99e7ce65c120ba155d4862424ccd9064f  guix-build-6c2538d5bfea/output/arm64-apple-darwin/SHA256SUMS.part
 75f5de2ba99f5f78c1dc4e179d1cdb18459c1d9ac23c8261cc8ded3835f52b006  guix-build-6c2538d5bfea/output/arm64-apple-darwin/bitcoin-6c2538d5bfea-arm64-apple-darwin-codesigning.tar.gz
 8719b1b2cf2564905c2eee8d0158b67236b43901590c5f8e23856ce00bc5a3a84  guix-build-6c2538d5bfea/output/arm64-apple-darwin/bitcoin-6c2538d5bfea-arm64-apple-darwin-unsigned.tar.gz
 943a8b2949ca75f4f1a11405c1254208514b7f8bd10cb3b60bb7f5ddcc7fc1314  guix-build-6c2538d5bfea/output/arm64-apple-darwin/bitcoin-6c2538d5bfea-arm64-apple-darwin-unsigned.zip
108a3488b3a87529b8eedc5c995eca948c404e7675b051d1c420c52b8850d926c5  guix-build-6c2538d5bfea/output/dist-archive/bitcoin-6c2538d5bfea.tar.gz
11cd067c2fadb0dc319ce36eb9d74c59b7de3edd669bde3b3378fcfd60f9755f51  guix-build-6c2538d5bfea/output/powerpc64-linux-gnu/SHA256SUMS.part
12dfec7e31a665cb105c644d6a970de017005ab3981b0634f9b9b0b9d8f378d9b5  guix-build-6c2538d5bfea/output/powerpc64-linux-gnu/bitcoin-6c2538d5bfea-powerpc64-linux-gnu-debug.tar.gz
1386f9a231e72004173aceb9dbbe9a0150603b804f71aa9f84196e49d09d56d348  guix-build-6c2538d5bfea/output/powerpc64-linux-gnu/bitcoin-6c2538d5bfea-powerpc64-linux-gnu.tar.gz
147c346668d1883657993801b203315b6a0f8a6ee6053a3d67c973d4fbee4c3e30  guix-build-6c2538d5bfea/output/riscv64-linux-gnu/SHA256SUMS.part
15cb0f43cdb631e6bc6942dfe98015de715e3af4ce5c188f9bfcff4a14e65b7943  guix-build-6c2538d5bfea/output/riscv64-linux-gnu/bitcoin-6c2538d5bfea-riscv64-linux-gnu-debug.tar.gz
1617460975b7f544c08b3e1a4db5395b5121835c8af6aee735dc6ca6004844e999  guix-build-6c2538d5bfea/output/riscv64-linux-gnu/bitcoin-6c2538d5bfea-riscv64-linux-gnu.tar.gz
17b0250a70578b73f8df85c56e1cda24bc5588533b6d6dacf64813874d6f34f894  guix-build-6c2538d5bfea/output/x86_64-apple-darwin/SHA256SUMS.part
186a3d22119375590bf13daf74ad906bc975eb97ded1c7fe7a7b5c1aed856f3aeb  guix-build-6c2538d5bfea/output/x86_64-apple-darwin/bitcoin-6c2538d5bfea-x86_64-apple-darwin-codesigning.tar.gz
19684fccb02f87b2051dd5be4505d35746fa97aa2fdb266a86ea16089734afc05e  guix-build-6c2538d5bfea/output/x86_64-apple-darwin/bitcoin-6c2538d5bfea-x86_64-apple-darwin-unsigned.tar.gz
20144b5a6cdfe0f55de97c8aa267f1e4f7cfacb16ea263bf0ef8a3c57c3e3a2ebc  guix-build-6c2538d5bfea/output/x86_64-apple-darwin/bitcoin-6c2538d5bfea-x86_64-apple-darwin-unsigned.zip
2166b0ba4a510b572d227deb34a89d87d918ea9d0b4bc21376327d84686082e925  guix-build-6c2538d5bfea/output/x86_64-linux-gnu/SHA256SUMS.part
2274a18d40bd76cd6ebc20334171ecb7871371755f843184fd0be4427c6a9ee2db  guix-build-6c2538d5bfea/output/x86_64-linux-gnu/bitcoin-6c2538d5bfea-x86_64-linux-gnu-debug.tar.gz
23688274471e566ce932a6f96161ee52373ff0e31a8d438f6a1c4f49c52612fa11  guix-build-6c2538d5bfea/output/x86_64-linux-gnu/bitcoin-6c2538d5bfea-x86_64-linux-gnu.tar.gz
241e04b38dbdbf40349f7a53ebebb66c730431a6d5b4be0080b733437371956243  guix-build-6c2538d5bfea/output/x86_64-w64-mingw32/SHA256SUMS.part
252a9aa57169de2e2ad4354bc00bf798e42dc7d673e68de03b2392296765965445  guix-build-6c2538d5bfea/output/x86_64-w64-mingw32/bitcoin-6c2538d5bfea-win64-codesigning.tar.gz
26c1b5d0fa9514bd91815fc2b223967ce585f9311fbf3ecdf132bf4ad8f9de9d21  guix-build-6c2538d5bfea/output/x86_64-w64-mingw32/bitcoin-6c2538d5bfea-win64-debug.zip
274f4970a4d9645b42f1ec572325e96f0840e6f8bc773dd7b41074201b7e3848ab  guix-build-6c2538d5bfea/output/x86_64-w64-mingw32/bitcoin-6c2538d5bfea-win64-setup-unsigned.exe
2811954cea6ea7f218e0c9d7373286c950e84d0b2dd9e18b7c7ca3321314ccc101  guix-build-6c2538d5bfea/output/x86_64-w64-mingw32/bitcoin-6c2538d5bfea-win64-unsigned.zip

fanquake merged this on Jun 26, 2025

fanquake closed this on Jun 26, 2025

fanquake deleted the branch on Jun 27, 2025

depends: Bump boost to 1.88.0 and use new CMake buildsystem #32665

Code Coverage & Benchmarks

Reviews

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]