guix: warn and abort when SOURCE_DATE

willcl-ark commented at 11:28 am on June 4, 2025: member

Current behaviour will by-default use SOURCE_DATE_EPOCH from the environment without warning. This breaks the default reproducibility from a guix build.

Warn when and exit when this variable is set, and FORCE_SOURCE_DATE_EPOCH is unset.

guix: warn and abort when SOURCE_DATE_EPOCH is set

Current behaviour will by-default use SOURCE_DATE_EPOCH from the
environment without warning. This breaks the default reproducibility
from a guix build.

Warn when and exit when this variable is set, and
FORCE_SOURCE_DATE_EPOCH is unset.

5c4a0f8009

DrahtBot commented at 11:28 am on June 4, 2025: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32678.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	maflcko, fanquake

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

DrahtBot added the label Build system on Jun 4, 2025

maflcko commented at 1:09 pm on June 4, 2025: member

lgtm ACK 5c4a0f8009cef758be9412428515bfed57b0c923

maflcko added the label DrahtBot Guix build requested on Jun 4, 2025

hebasto commented at 4:21 pm on June 4, 2025: member

My Guix build:

 0aarch64
 113c339d8340af9456ad236a76bdd7faaed0f694849e6ad15da328d17d0c87ede  guix-build-5c4a0f8009ce/output/aarch64-linux-gnu/SHA256SUMS.part
 2afc24aab271148828178b89379a4e518664415163601c7628e93d9cf53616314  guix-build-5c4a0f8009ce/output/aarch64-linux-gnu/bitcoin-5c4a0f8009ce-aarch64-linux-gnu-debug.tar.gz
 37bba24165e6924ec1acddb0cc4e29c708dbb1b98f2e30405d06668f1d16c71ff  guix-build-5c4a0f8009ce/output/aarch64-linux-gnu/bitcoin-5c4a0f8009ce-aarch64-linux-gnu.tar.gz
 40be9eb9ab5f44e3094aaf2edba550c9839e823ea14209436d7c0ab15ccb61288  guix-build-5c4a0f8009ce/output/arm-linux-gnueabihf/SHA256SUMS.part
 58b6084fcba3a2bf18a671e9cc4f5939f0fab0d9775a5f65738d134900c8d891a  guix-build-5c4a0f8009ce/output/arm-linux-gnueabihf/bitcoin-5c4a0f8009ce-arm-linux-gnueabihf-debug.tar.gz
 6141fe2c5f3f1a318038b245352291c8bd6cbd315b60e1fc421d91b109328c521  guix-build-5c4a0f8009ce/output/arm-linux-gnueabihf/bitcoin-5c4a0f8009ce-arm-linux-gnueabihf.tar.gz
 798f60ebf2eb26836cf3bc61d0ab5a45a6facf6ec128565bfdfefcef8d2fbebc0  guix-build-5c4a0f8009ce/output/arm64-apple-darwin/SHA256SUMS.part
 8438b59e711c1c46e73e0c28e8522de623ef12e3b64e51858f0efbc0cdf47fd1c  guix-build-5c4a0f8009ce/output/arm64-apple-darwin/bitcoin-5c4a0f8009ce-arm64-apple-darwin-codesigning.tar.gz
 9ea3ae9e568c2504f175b72b8e1713c538ca9774278958a34d89582b48b469040  guix-build-5c4a0f8009ce/output/arm64-apple-darwin/bitcoin-5c4a0f8009ce-arm64-apple-darwin-unsigned.tar.gz
103792f6185dfe60c80a3c1b47e512ca82815bb395bfac0ef55844f4aba1d4a6e5  guix-build-5c4a0f8009ce/output/arm64-apple-darwin/bitcoin-5c4a0f8009ce-arm64-apple-darwin-unsigned.zip
11980cc359840b1cf984a480aff2cb1e21743968d2b68ec3187277d92e0f7c0998  guix-build-5c4a0f8009ce/output/dist-archive/bitcoin-5c4a0f8009ce.tar.gz
12a94f15c88a113710244c0e2f78b6f813e795785cdea188048436365673f16c09  guix-build-5c4a0f8009ce/output/powerpc64-linux-gnu/SHA256SUMS.part
1348de6809a45ba1b88f50610ea7b919e1f37d0fdc5c0dca8835190635e6fb37ee  guix-build-5c4a0f8009ce/output/powerpc64-linux-gnu/bitcoin-5c4a0f8009ce-powerpc64-linux-gnu-debug.tar.gz
141077745f28fedb0b62e416bbe4851647ff5cdb4c3b6f5cee742b748cd5e48328  guix-build-5c4a0f8009ce/output/powerpc64-linux-gnu/bitcoin-5c4a0f8009ce-powerpc64-linux-gnu.tar.gz
15feba736d3b055aaa9fef1441e5f5b86f3b2f4f549641f50f1e2e565e2e01f213  guix-build-5c4a0f8009ce/output/riscv64-linux-gnu/SHA256SUMS.part
1668f0abd201aac8fd9a4770baa64e12ee7983527801d22bee848d6e562569573d  guix-build-5c4a0f8009ce/output/riscv64-linux-gnu/bitcoin-5c4a0f8009ce-riscv64-linux-gnu-debug.tar.gz
1738c20e022294c22ab1c1795e84619d3c2c10495c4f23ac35237d04b97a2521bb  guix-build-5c4a0f8009ce/output/riscv64-linux-gnu/bitcoin-5c4a0f8009ce-riscv64-linux-gnu.tar.gz
186e3dbf52ce40fb8c2618506a77bc0f205c8ebac50053e1a287e4e52b23092b82  guix-build-5c4a0f8009ce/output/x86_64-apple-darwin/SHA256SUMS.part
1906efe9a3b49b04783070a3e4cf298ae21e5924cfe7bd9f7eeb9b0b06d53f6a86  guix-build-5c4a0f8009ce/output/x86_64-apple-darwin/bitcoin-5c4a0f8009ce-x86_64-apple-darwin-codesigning.tar.gz
20b6be21da9d0dccbb507875f65cf682a2911a47fe05e07e9f78ab9ff0bfa546fd  guix-build-5c4a0f8009ce/output/x86_64-apple-darwin/bitcoin-5c4a0f8009ce-x86_64-apple-darwin-unsigned.tar.gz
214d481619ff9a50214218e0188a357fa23402292f6b16823d6f4e1fe5487e3dbe  guix-build-5c4a0f8009ce/output/x86_64-apple-darwin/bitcoin-5c4a0f8009ce-x86_64-apple-darwin-unsigned.zip
223a3c68e4ab91bc3a8f61f1bd951b797a23648821a05300fbddc2ff44cc4d0a3f  guix-build-5c4a0f8009ce/output/x86_64-linux-gnu/SHA256SUMS.part
23fb3c3ab79edeb722c3e0432d5b36ba9f8f28e7745104daee5496e923fe715c71  guix-build-5c4a0f8009ce/output/x86_64-linux-gnu/bitcoin-5c4a0f8009ce-x86_64-linux-gnu-debug.tar.gz
24e9b278097671294baa7de48acb347b27742182f0fd58a88d7c503bd06751b537  guix-build-5c4a0f8009ce/output/x86_64-linux-gnu/bitcoin-5c4a0f8009ce-x86_64-linux-gnu.tar.gz
254fa48294ebb76daf9f4a220bdef318f9dd43dc6e91292c59dc79db16633c47f5  guix-build-5c4a0f8009ce/output/x86_64-w64-mingw32/SHA256SUMS.part
2636bf124faed2e75f43ed5b17ab31a05dda8e43f87d4d8b8798be0a47247592a6  guix-build-5c4a0f8009ce/output/x86_64-w64-mingw32/bitcoin-5c4a0f8009ce-win64-codesigning.tar.gz
27b90fe9de351f2bc7d0aa2c52c69cd248f930ead2dbac918434ebcb4e5d71a13d  guix-build-5c4a0f8009ce/output/x86_64-w64-mingw32/bitcoin-5c4a0f8009ce-win64-debug.zip
28b72b6524932fef07b29bc382a50a9fdf3c3960788c282969d8a9534455555411  guix-build-5c4a0f8009ce/output/x86_64-w64-mingw32/bitcoin-5c4a0f8009ce-win64-setup-unsigned.exe
297d0c2f8811eb8af227c1f15828905b05b99aff671f0d8844ea809a0d6ebb5428  guix-build-5c4a0f8009ce/output/x86_64-w64-mingw32/bitcoin-5c4a0f8009ce-win64-unsigned.zip

willcl-ark commented at 7:42 pm on June 4, 2025: member

My guix hashes

 0src/core/bitcoin on  source-date-epoch [$] via △ v3.31.6 via 🐍 v3.12.10 via ❄️  impure (nix-shell-env) took 52m9s
 1❯ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
 213c339d8340af9456ad236a76bdd7faaed0f694849e6ad15da328d17d0c87ede  guix-build-5c4a0f8009ce/output/aarch64-linux-gnu/SHA256SUMS.part
 3afc24aab271148828178b89379a4e518664415163601c7628e93d9cf53616314  guix-build-5c4a0f8009ce/output/aarch64-linux-gnu/bitcoin-5c4a0f8009ce-aarch64-linux-gnu-debug.tar.gz
 47bba24165e6924ec1acddb0cc4e29c708dbb1b98f2e30405d06668f1d16c71ff  guix-build-5c4a0f8009ce/output/aarch64-linux-gnu/bitcoin-5c4a0f8009ce-aarch64-linux-gnu.tar.gz
 50be9eb9ab5f44e3094aaf2edba550c9839e823ea14209436d7c0ab15ccb61288  guix-build-5c4a0f8009ce/output/arm-linux-gnueabihf/SHA256SUMS.part
 68b6084fcba3a2bf18a671e9cc4f5939f0fab0d9775a5f65738d134900c8d891a  guix-build-5c4a0f8009ce/output/arm-linux-gnueabihf/bitcoin-5c4a0f8009ce-arm-linux-gnueabihf-debug.tar.gz
 7141fe2c5f3f1a318038b245352291c8bd6cbd315b60e1fc421d91b109328c521  guix-build-5c4a0f8009ce/output/arm-linux-gnueabihf/bitcoin-5c4a0f8009ce-arm-linux-gnueabihf.tar.gz
 898f60ebf2eb26836cf3bc61d0ab5a45a6facf6ec128565bfdfefcef8d2fbebc0  guix-build-5c4a0f8009ce/output/arm64-apple-darwin/SHA256SUMS.part
 9438b59e711c1c46e73e0c28e8522de623ef12e3b64e51858f0efbc0cdf47fd1c  guix-build-5c4a0f8009ce/output/arm64-apple-darwin/bitcoin-5c4a0f8009ce-arm64-apple-darwin-codesigning.tar.gz
10ea3ae9e568c2504f175b72b8e1713c538ca9774278958a34d89582b48b469040  guix-build-5c4a0f8009ce/output/arm64-apple-darwin/bitcoin-5c4a0f8009ce-arm64-apple-darwin-unsigned.tar.gz
113792f6185dfe60c80a3c1b47e512ca82815bb395bfac0ef55844f4aba1d4a6e5  guix-build-5c4a0f8009ce/output/arm64-apple-darwin/bitcoin-5c4a0f8009ce-arm64-apple-darwin-unsigned.zip
12980cc359840b1cf984a480aff2cb1e21743968d2b68ec3187277d92e0f7c0998  guix-build-5c4a0f8009ce/output/dist-archive/bitcoin-5c4a0f8009ce.tar.gz
13a94f15c88a113710244c0e2f78b6f813e795785cdea188048436365673f16c09  guix-build-5c4a0f8009ce/output/powerpc64-linux-gnu/SHA256SUMS.part
1448de6809a45ba1b88f50610ea7b919e1f37d0fdc5c0dca8835190635e6fb37ee  guix-build-5c4a0f8009ce/output/powerpc64-linux-gnu/bitcoin-5c4a0f8009ce-powerpc64-linux-gnu-debug.tar.gz
151077745f28fedb0b62e416bbe4851647ff5cdb4c3b6f5cee742b748cd5e48328  guix-build-5c4a0f8009ce/output/powerpc64-linux-gnu/bitcoin-5c4a0f8009ce-powerpc64-linux-gnu.tar.gz
16feba736d3b055aaa9fef1441e5f5b86f3b2f4f549641f50f1e2e565e2e01f213  guix-build-5c4a0f8009ce/output/riscv64-linux-gnu/SHA256SUMS.part
1768f0abd201aac8fd9a4770baa64e12ee7983527801d22bee848d6e562569573d  guix-build-5c4a0f8009ce/output/riscv64-linux-gnu/bitcoin-5c4a0f8009ce-riscv64-linux-gnu-debug.tar.gz
1838c20e022294c22ab1c1795e84619d3c2c10495c4f23ac35237d04b97a2521bb  guix-build-5c4a0f8009ce/output/riscv64-linux-gnu/bitcoin-5c4a0f8009ce-riscv64-linux-gnu.tar.gz
196e3dbf52ce40fb8c2618506a77bc0f205c8ebac50053e1a287e4e52b23092b82  guix-build-5c4a0f8009ce/output/x86_64-apple-darwin/SHA256SUMS.part
2006efe9a3b49b04783070a3e4cf298ae21e5924cfe7bd9f7eeb9b0b06d53f6a86  guix-build-5c4a0f8009ce/output/x86_64-apple-darwin/bitcoin-5c4a0f8009ce-x86_64-apple-darwin-codesigning.tar.gz
21b6be21da9d0dccbb507875f65cf682a2911a47fe05e07e9f78ab9ff0bfa546fd  guix-build-5c4a0f8009ce/output/x86_64-apple-darwin/bitcoin-5c4a0f8009ce-x86_64-apple-darwin-unsigned.tar.gz
224d481619ff9a50214218e0188a357fa23402292f6b16823d6f4e1fe5487e3dbe  guix-build-5c4a0f8009ce/output/x86_64-apple-darwin/bitcoin-5c4a0f8009ce-x86_64-apple-darwin-unsigned.zip
233a3c68e4ab91bc3a8f61f1bd951b797a23648821a05300fbddc2ff44cc4d0a3f  guix-build-5c4a0f8009ce/output/x86_64-linux-gnu/SHA256SUMS.part
24fb3c3ab79edeb722c3e0432d5b36ba9f8f28e7745104daee5496e923fe715c71  guix-build-5c4a0f8009ce/output/x86_64-linux-gnu/bitcoin-5c4a0f8009ce-x86_64-linux-gnu-debug.tar.gz
25e9b278097671294baa7de48acb347b27742182f0fd58a88d7c503bd06751b537  guix-build-5c4a0f8009ce/output/x86_64-linux-gnu/bitcoin-5c4a0f8009ce-x86_64-linux-gnu.tar.gz
264fa48294ebb76daf9f4a220bdef318f9dd43dc6e91292c59dc79db16633c47f5  guix-build-5c4a0f8009ce/output/x86_64-w64-mingw32/SHA256SUMS.part
2736bf124faed2e75f43ed5b17ab31a05dda8e43f87d4d8b8798be0a47247592a6  guix-build-5c4a0f8009ce/output/x86_64-w64-mingw32/bitcoin-5c4a0f8009ce-win64-codesigning.tar.gz
28b90fe9de351f2bc7d0aa2c52c69cd248f930ead2dbac918434ebcb4e5d71a13d  guix-build-5c4a0f8009ce/output/x86_64-w64-mingw32/bitcoin-5c4a0f8009ce-win64-debug.zip
29b72b6524932fef07b29bc382a50a9fdf3c3960788c282969d8a9534455555411  guix-build-5c4a0f8009ce/output/x86_64-w64-mingw32/bitcoin-5c4a0f8009ce-win64-setup-unsigned.exe
307d0c2f8811eb8af227c1f15828905b05b99aff671f0d8844ea809a0d6ebb5428  guix-build-5c4a0f8009ce/output/x86_64-w64-mingw32/bitcoin-5c4a0f8009ce-win64-unsigned.zip

DrahtBot commented at 0:41 am on June 5, 2025: contributor

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

File	commit 4af72d8b08925ecebf2ce15c9f2b76092c2cf2e3(master)	commit 2e742a3e2b3e436b0153e68f7bf150477f969375(pull/32678/merge)
*-aarch64-linux-gnu-debug.tar.gz	`43197881402cbc9d...`	`c4cd1c27aa4379ad...`
*-aarch64-linux-gnu.tar.gz	`b89187292ac990d0...`	`061d93ff96535b4b...`
*-arm-linux-gnueabihf-debug.tar.gz	`4b531a1257091007...`	`5e44781869fa94c9...`
*-arm-linux-gnueabihf.tar.gz	`008b155f73f160b2...`	`87913000841588c2...`
*-arm64-apple-darwin-codesigning.tar.gz	`92e7332b09f4660e...`	`22cb08e472cc9c10...`
*-arm64-apple-darwin-unsigned.tar.gz	`20d74aa8b478700d...`	`de686f8c5382ee65...`
*-arm64-apple-darwin-unsigned.zip	`85f89b36ff279fc9...`	`d7d1cce001ed9232...`
*-powerpc64-linux-gnu-debug.tar.gz	`79697cd07f0e65bd...`	`d23f4c5da9073db4...`
*-powerpc64-linux-gnu.tar.gz	`6e674ec1fa08b67d...`	`d313f310505b0193...`
*-riscv64-linux-gnu-debug.tar.gz	`b091383357f6e68a...`	`b5bcf4b128b69878...`
*-riscv64-linux-gnu.tar.gz	`9e3f2b5c20fa5ca4...`	`0182fb5b9130a583...`
*-x86_64-apple-darwin-codesigning.tar.gz	`e73ca89122d914f4...`	`a81a94091501e496...`
*-x86_64-apple-darwin-unsigned.tar.gz	`be5bb4a78dd78025...`	`83bd8ff4511dd0e5...`
*-x86_64-apple-darwin-unsigned.zip	`eafb268a6861d070...`	`9979db75d009457f...`
*-x86_64-linux-gnu-debug.tar.gz	`b61272cfbc4f6e97...`	`97a10b52354f2aee...`
*-x86_64-linux-gnu.tar.gz	`9669eca7e1e917af...`	`04deae0d8a855751...`
*.tar.gz	`12d4c4c3b0d7b7b0...`	`ef45c10594015589...`
SHA256SUMS.part	`dd6c899644f2651f...`	`51874adbb21fd45c...`
guix_build.log	`73f208765b337673...`	`7f74d42cb784e193...`
guix_build.log.diff		`d2943571b6c85c51...`

DrahtBot removed the label DrahtBot Guix build requested on Jun 5, 2025

fanquake commented at 12:57 pm on June 6, 2025: member

Concept ACK

fanquake approved

fanquake commented at 2:21 pm on June 10, 2025: member

ACK 5c4a0f8009cef758be9412428515bfed57b0c923

fanquake merged this on Jun 10, 2025

fanquake closed this on Jun 10, 2025

fanquake referenced this in commit 23e76ef520 on Jun 10, 2025

fanquake commented at 2:24 pm on June 10, 2025: member

Backported to 29.x in #32589.

guix: warn and abort when SOURCE_DATE_EPOCH is set #32678

Code Coverage & Benchmarks

Reviews

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]