doc: add release notes for #32425 #32727
pull vasild wants to merge 1 commits into bitcoin:master from vasild:release_notes_32425 changing 1 files +14 −0-
vasild commented at 11:00 am on June 11, 2025: contributorAdd release notes for #32425.
-
DrahtBot commented at 11:01 am on June 11, 2025: contributor
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32727.
Reviews
See the guideline for information on the review process.
Type Reviewers ACK janb84 If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
-
DrahtBot added the label Docs on Jun 11, 2025
-
in doc/release-notes-32425.md:4 in 8a30551de9 outdated
0@@ -0,0 +1,11 @@ 1+Updated settings 2+---------------- 3+ 4+- Previously `-proxy=addr:port` specified the proxy for all networks (except
1440000bytes commented at 7:28 pm on June 11, 2025:A suggestion based on https://github.com/bitcoin/bitcoin/pull/30529/commits/490c8fa17829c3f8ae4da739f526531c91f3ed87
0Configuration 1---------------- 2 3Previously `-proxy=addr:port` specified the proxy for all networks (except
vasild commented at 11:21 am on June 13, 2025:I useddoc/release-notes-empty-template.md
as a template. It containsUpdated settings
section but does not containConfiguration
section. I prefer to follow the template and not invent own sections. If everybody comes up with their own section then we may end up with “Configuration”, “Config”, “Configuration settings”, “Changed configuration”, “Updated config”, etc.in doc/release-notes-32425.md:11 in 8a30551de9 outdated
6+ `-onion=addr:port`. Now the syntax of `-proxy` has been extended and it is 7+ possible to specify separately the proxy for IPv4, IPv6, Tor and CJDNS by 8+ appending `=` followed by the network name, for example 9+ `-proxy=addr:port=ipv6` would configure a proxy only for IPv6. It is also made 10+ possible to remove the proxy and use direct connections for a given network 11+ only, e.g. `-proxy=0=cjdns`. (#32425)
janb84 commented at 8:31 am on June 12, 2025:0 `-proxy=addr:port=ipv6` would configure a proxy only for IPv6. The -proxy option can be used multiple times to define different proxies for different networks, such as `-proxy=addr1:port1=ipv4 -proxy=addr2:port2=ipv6`. It is also made 1 possible to remove the proxy and use direct connections for a given network 2 only, e.g. `-proxy=0=cjdns`. (#32425)
NIT, it was unclear to me how to specify multiple different proxy’s. My suggestion is to make it more explicit in the text how to specify multiple different proxy’s for the different networks.
vasild commented at 11:16 am on June 13, 2025:Done, thanks!janb84 commented at 8:32 am on June 12, 2025: contributorconcept ACK 8a30551de9944d5896a85fa68a25741f7a00c051
Small NIT to be more explicit in how to use the option for different networks (not comma separated but use the -proxy option multiple times)
doc: add release notes for https://github.com/bitcoin/bitcoin/pull/32425
Co-authored-by: Jan B <608446+janb84@users.noreply.github.com>
vasild force-pushed on Jun 13, 2025vasild commented at 11:16 am on June 13, 2025: contributor8a30551de9...8264d3c0b3
: address suggestionjanb84 commented at 11:29 am on June 13, 2025: contributorACK 8264d3c0b35880e3a7068a0717f4b98a79708660
Changes sinds last (concept) ACK:
- textual changes in the release note to give a more in-depth explanation of how to use the flag.
vasild
DrahtBot
1440000bytes
janb84
Labels
Docs
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-06-15 06:13 UTC
More mirrored repositories can be found on mirror.b10c.me