doc: add release notes for #32425

vasild commented at 11:00 am on June 11, 2025: contributor

Add release notes for #32425.

DrahtBot commented at 11:01 am on June 11, 2025: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32727.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	pablomartin4btc, janb84, glozow

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

DrahtBot added the label Docs on Jun 11, 2025

in doc/release-notes-32425.md:4 in 8a30551de9 outdated

0@@ -0,0 +1,11 @@
1+Updated settings
2+----------------
3+
4+- Previously `-proxy=addr:port` specified the proxy for all networks (except

1440000bytes commented at 7:28 pm on June 11, 2025:

A suggestion based on https://github.com/bitcoin/bitcoin/pull/30529/commits/490c8fa17829c3f8ae4da739f526531c91f3ed87

0Configuration
1----------------
2
3Previously `-proxy=addr:port` specified the proxy for all networks (except

vasild commented at 11:21 am on June 13, 2025:

I used doc/release-notes-empty-template.md as a template. It contains Updated settings section but does not contain Configuration section. I prefer to follow the template and not invent own sections. If everybody comes up with their own section then we may end up with “Configuration”, “Config”, “Configuration settings”, “Changed configuration”, “Updated config”, etc.

in doc/release-notes-32425.md:11 in 8a30551de9 outdated

 6+  `-onion=addr:port`. Now the syntax of `-proxy` has been extended and it is
 7+  possible to specify separately the proxy for IPv4, IPv6, Tor and CJDNS by
 8+  appending `=` followed by the network name, for example
 9+  `-proxy=addr:port=ipv6` would configure a proxy only for IPv6. It is also made
10+  possible to remove the proxy and use direct connections for a given network
11+  only, e.g. `-proxy=0=cjdns`. (#32425)

janb84 commented at 8:31 am on June 12, 2025:

0  `-proxy=addr:port=ipv6` would configure a proxy only for IPv6. The -proxy option can be used multiple times to define different proxies for different networks, such as `-proxy=addr1:port1=ipv4 -proxy=addr2:port2=ipv6`. It is also made
1  possible to remove the proxy and use direct connections for a given network
2  only, e.g. `-proxy=0=cjdns`. (#32425)

NIT, it was unclear to me how to specify multiple different proxy’s. My suggestion is to make it more explicit in the text how to specify multiple different proxy’s for the different networks.

vasild commented at 11:16 am on June 13, 2025:

Done, thanks!

janb84 commented at 8:32 am on June 12, 2025: contributor

concept ACK 8a30551de9944d5896a85fa68a25741f7a00c051

Small NIT to be more explicit in how to use the option for different networks (not comma separated but use the -proxy option multiple times)

vasild force-pushed on Jun 13, 2025

vasild commented at 11:16 am on June 13, 2025: contributor

8a30551de9...8264d3c0b3: address suggestion

janb84 commented at 11:29 am on June 13, 2025: contributor

ACK 8264d3c0b35880e3a7068a0717f4b98a79708660

Changes sinds last (concept) ACK:

textual changes in the release note to give a more in-depth explanation of how to use the flag.

in doc/release-notes-32425.md:5 in 8264d3c0b3 outdated

0@@ -0,0 +1,14 @@
1+Updated settings
2+----------------
3+
4+- Previously `-proxy=addr:port` specified the proxy for all networks (except
5+  I2P) and only the Tor proxy could have been specified separately via

pablomartin4btc commented at 4:45 pm on June 17, 2025:

nit (or similar idea) if it makes sense…

0  I2P - which requires its own I2P SAM proxy to be specified with -`i2psam=<ip:port>`) and only the Tor proxy could have been specified separately via

vasild commented at 8:22 am on June 20, 2025:

Added some (shorter) clarification.

in doc/release-notes-32425.md:14 in 8264d3c0b3 outdated

 9+  `-proxy=addr:port=ipv6` would configure a proxy only for IPv6. The `-proxy`
10+  option can be used multiple times to define different proxies for different
11+  networks, such as `-proxy=addr1:port1=ipv4 -proxy=addr2:port2=ipv6`. It is
12+  also possible to override an earlier setting, which can be used to remove
13+  an earlier all-networks proxy and use direct connections for a given network
14+  only, e.g. `-proxy=addr:port -proxy=0=cjdns`. (#32425)

pablomartin4btc commented at 4:46 pm on June 17, 2025:

0  only, e.g. `-proxy=addr[:port] -proxy=0=cjdns`. (#32425)

vasild commented at 8:23 am on June 20, 2025:

This is an example, not a syntax specification or definition. I changed it to use real addresses and port numbers instead of the words “addr” and “port”.

in doc/release-notes-32425.md:6 in 8264d3c0b3 outdated

0@@ -0,0 +1,14 @@
1+Updated settings
2+----------------
3+
4+- Previously `-proxy=addr:port` specified the proxy for all networks (except
5+  I2P) and only the Tor proxy could have been specified separately via
6+  `-onion=addr:port`. Now the syntax of `-proxy` has been extended and it is

pablomartin4btc commented at 4:46 pm on June 17, 2025:

0  `-onion=addr[:port]`. Now the syntax of `-proxy` has been extended and it is

vasild commented at 8:24 am on June 20, 2025:

#32727 (review)

in doc/release-notes-32425.md:9 in 8264d3c0b3 outdated

0@@ -0,0 +1,14 @@
1+Updated settings
2+----------------
3+
4+- Previously `-proxy=addr:port` specified the proxy for all networks (except
5+  I2P) and only the Tor proxy could have been specified separately via
6+  `-onion=addr:port`. Now the syntax of `-proxy` has been extended and it is
7+  possible to specify separately the proxy for IPv4, IPv6, Tor and CJDNS by
8+  appending `=` followed by the network name, for example
9+  `-proxy=addr:port=ipv6` would configure a proxy only for IPv6. The `-proxy`

pablomartin4btc commented at 4:47 pm on June 17, 2025:

0  `-proxy=addr[:port]=ipv6` would configure a proxy only for IPv6. The `-proxy`

vasild commented at 8:24 am on June 20, 2025:

#32727 (review)

in doc/release-notes-32425.md:11 in 8264d3c0b3 outdated

 6+  `-onion=addr:port`. Now the syntax of `-proxy` has been extended and it is
 7+  possible to specify separately the proxy for IPv4, IPv6, Tor and CJDNS by
 8+  appending `=` followed by the network name, for example
 9+  `-proxy=addr:port=ipv6` would configure a proxy only for IPv6. The `-proxy`
10+  option can be used multiple times to define different proxies for different
11+  networks, such as `-proxy=addr1:port1=ipv4 -proxy=addr2:port2=ipv6`. It is

pablomartin4btc commented at 4:52 pm on June 17, 2025:

0  networks, such as `-proxy=addr1[:port1]=ipv4 -proxy=addr2[:port2]=ipv6`. It is

vasild commented at 8:24 am on June 20, 2025:

#32727 (review)

pablomartin4btc commented at 4:59 pm on June 17, 2025: member

ACK 8264d3c0b35880e3a7068a0717f4b98a79708660

I’ve left a couple of nits.

vasild force-pushed on Jun 20, 2025

vasild commented at 8:21 am on June 20, 2025: contributor

8264d3c0b3...a4cfaa5eab: address suggestion

janb84 commented at 8:32 am on June 20, 2025: contributor

8264d3c0b3...a4cfaa5eab: address suggestion

Think this has gone in the wrong direction, the feedback (as i interpreted it) was to only indicate that the port portion of the argument is optional. Going to real addresses does not addresses the feedback, and makes it less clear (imho)

vasild commented at 9:05 am on June 20, 2025: contributor

Hmm, but look - there is a difference between “specification” and “example”. The docs usually read something like:

The syntax of the proxy option is -proxy=addr[:port]. For example: -proxy=127.0.0.1:9050.

It wouldn’t make sense to use [:port] in the example:

The syntax of the proxy option is -proxy=addr[:port]. For example: -proxy=addr[:port].

It is examples in the added release note.

in doc/release-notes-32425.md:8 in a4cfaa5eab outdated

0@@ -0,0 +1,14 @@
1+Updated settings
2+----------------
3+
4+- Previously `-proxy` specified the proxy for all networks (except I2P which
5+  uses `-i2psam`) and only the Tor proxy could have been specified separately
6+  via `-onion`. Now the syntax of `-proxy` has been extended and it is possible
7+  to specify separately the proxy for IPv4, IPv6, Tor and CJDNS by appending `=`
8+  followed by the network name, for example `-proxy=127.0.0.1:5555=ipv6` would

janb84 commented at 9:18 am on June 20, 2025:

0  followed by the network name, for example `-proxy=[::01]:5555=ipv6` would

small NIT use ipv6 address for ipv6 example

pablomartin4btc commented at 3:53 pm on June 20, 2025:

I think you could still set the IPv6 proxy using its IPv4 address, maybe we could add more examples in the documentation.

in doc/release-notes-32425.md:11 in a4cfaa5eab outdated

 6+  via `-onion`. Now the syntax of `-proxy` has been extended and it is possible
 7+  to specify separately the proxy for IPv4, IPv6, Tor and CJDNS by appending `=`
 8+  followed by the network name, for example `-proxy=127.0.0.1:5555=ipv6` would
 9+  configure a proxy only for IPv6. The `-proxy` option can be used multiple
10+  times to define different proxies for different networks, such as
11+  `-proxy=127.0.0.1:4444=ipv4 -proxy=10.0.0.1:6666=ipv6`. It is also possible to

janb84 commented at 9:19 am on June 20, 2025:

0  `-proxy=127.0.0.1:4444=ipv4 -proxy=[2001:db8::1]:6666=ipv6`. It is also possible to

small NIT use ipv6 address for ipv6 example

janb84 commented at 9:25 am on June 20, 2025: contributor

Hmm, but look - there is a difference between “specification” and “example”. The docs usually read something like:

The syntax of the proxy option is -proxy=addr[:port]. For example: -proxy=127.0.0.1:9050.

It wouldn’t make sense to use [:port] in the example:

The syntax of the proxy option is -proxy=addr[:port]. For example: -proxy=addr[:port].

It is examples in the added release note.

ok, agree.

concept ACK a4cfaa5eab442081fadcc461408f1112b5e84ee7

small NITs into for matching address type with network name

DrahtBot requested review from pablomartin4btc on Jun 20, 2025

pablomartin4btc approved

pablomartin4btc commented at 3:54 pm on June 20, 2025: member

re-ACK a4cfaa5eab442081fadcc461408f1112b5e84ee7

in doc/release-notes-32425.md:9 in a4cfaa5eab outdated

0@@ -0,0 +1,14 @@
1+Updated settings
2+----------------
3+
4+- Previously `-proxy` specified the proxy for all networks (except I2P which
5+  uses `-i2psam`) and only the Tor proxy could have been specified separately
6+  via `-onion`. Now the syntax of `-proxy` has been extended and it is possible
7+  to specify separately the proxy for IPv4, IPv6, Tor and CJDNS by appending `=`
8+  followed by the network name, for example `-proxy=127.0.0.1:5555=ipv6` would
9+  configure a proxy only for IPv6. The `-proxy` option can be used multiple

glozow commented at 8:53 pm on June 23, 2025:

Should stick with present tense to describe the new behavior, otherwise it looks like it’s talking about the past behavior. Also I suggest some commas?

0- Previously, `-proxy` specified the proxy for all networks (except I2P which
1  uses `-i2psam`) and only the Tor proxy could have been specified separately
2  via `-onion`. Now, the syntax of `-proxy` has been extended and it is possible
3  to specify separately the proxy for IPv4, IPv6, Tor and CJDNS by appending `=`
4  followed by the network name, for example `-proxy=127.0.0.1:5555=ipv6`
5  configures a proxy only for IPv6. The `-proxy` option can be used multiple

vasild commented at 4:56 pm on June 25, 2025:

Done.

“for example -proxy=127.0.0.1:5555=ipv6 would configure a proxy only for IPv6”

it looks like it’s talking about the past behavior

I guess I used “5: The second conditional” from https://www.perfect-english-grammar.com/would.html:

If I had enough money, I would travel around the world. If we lived in Madrid, we would study Spanish.

in doc/release-notes-32425.md:12 in a4cfaa5eab outdated

 7+  to specify separately the proxy for IPv4, IPv6, Tor and CJDNS by appending `=`
 8+  followed by the network name, for example `-proxy=127.0.0.1:5555=ipv6` would
 9+  configure a proxy only for IPv6. The `-proxy` option can be used multiple
10+  times to define different proxies for different networks, such as
11+  `-proxy=127.0.0.1:4444=ipv4 -proxy=10.0.0.1:6666=ipv6`. It is also possible to
12+  override an earlier setting, which can be used to remove an earlier

glozow commented at 8:56 pm on June 23, 2025:

Are you saying that newer settings automatically override old ones, or there is special syntax to do so? If it’s the former, should remove “It is also possible.”

0  `-proxy=127.0.0.1:4444=ipv4 -proxy=10.0.0.1:6666=ipv6`.
1  Later settings override earlier ones; this can be used to remove an earlier

vasild commented at 4:25 pm on June 25, 2025:

Done, plus some more rewording.

doc: add release notes for https://github.com/bitcoin/bitcoin/pull/32425

Co-authored-by: Jan B <608446+janb84@users.noreply.github.com>

b9a2e8ee96

vasild force-pushed on Jun 25, 2025

vasild commented at 4:25 pm on June 25, 2025: contributor

a4cfaa5eab...b9a2e8ee96: take suggestions

pablomartin4btc approved

pablomartin4btc commented at 4:51 pm on June 25, 2025: member

a4cfaa5eab…b9a2e8ee96: take suggestions

re-ACK b9a2e8ee96

DrahtBot requested review from janb84 on Jun 25, 2025

janb84 commented at 5:08 pm on June 25, 2025: contributor

reACK b9a2e8ee965daffe2bc618f58b21f0ddebadeb23

Changes sinds last ACK;

div textual changes

(still find it weird that a non-localhost ipv4 address for ipv6 proxy can be used, but agree to disagree on that )

glozow commented at 7:57 pm on June 25, 2025: member

ACK b9a2e8ee965daffe2bc618f58b21f0ddebadeb23, thanks for taking suggestions!

glozow merged this on Jun 25, 2025

glozow closed this on Jun 25, 2025

vasild deleted the branch on Jun 26, 2025

doc: add release notes for #32425 #32727

Code Coverage & Benchmarks

Reviews