test: remove unnecessary m_best_header setting hack in feature_assumeutxo.py #32746

pull theStack wants to merge 1 commits into bitcoin:master from theStack:202506-test-assumeutxo_remove_hack_for_mbestheader changing 1 files +0 −6
  1. theStack commented at 12:50 pm on June 13, 2025: contributor
    The mentioned bug (issue #26245) has been fixed in PR #30666, so the workaround is not needed anymore.
  2. test: remove unnecessary m_best_header setting hack in feature_assumeutxo.py
    The mentioned bug has been fixed in PR #30666,
    so the workaround is not needed anymore.
    206bc05e62
  3. DrahtBot commented at 12:50 pm on June 13, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32746.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK fjahr, janb84, mzumsande

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. DrahtBot added the label Tests on Jun 13, 2025
  5. theStack renamed this:
    test: remove unnecessary m_best_header setting hack in feature_assume_utxo.py
    test: remove unnecessary m_best_header setting hack in feature_assumeutxo.py
    on Jun 13, 2025
  6. fjahr commented at 2:16 pm on June 13, 2025: contributor
    ACK 206bc05e62c6a71c328eaab90fd865f46328642f
  7. janb84 commented at 2:26 pm on June 13, 2025: contributor

    ACK 206bc05e62c6a71c328eaab90fd865f46328642f

    The issue is resolved, the “hack” is not needed anymore.

    • Validated that the test still runs / passed ✅
  8. mzumsande commented at 2:37 pm on June 13, 2025: contributor
    utACK 206bc05e62c6a71c328eaab90fd865f46328642f
  9. fanquake merged this on Jun 13, 2025
  10. fanquake closed this on Jun 13, 2025

  11. theStack deleted the branch on Jun 13, 2025
  12. bitcoin deleted a comment on Jun 13, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-06-15 06:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me