The mentioned bug (issue #26245) has been fixed in PR #30666, so the workaround is not needed anymore.
test: remove unnecessary m_best_header setting hack in feature_assumeutxo.py #32746
pull theStack wants to merge 1 commits into bitcoin:master from theStack:202506-test-assumeutxo_remove_hack_for_mbestheader changing 1 files +0 −6-
theStack commented at 12:50 PM on June 13, 2025: contributor
-
206bc05e62
test: remove unnecessary m_best_header setting hack in feature_assumeutxo.py
The mentioned bug has been fixed in PR #30666, so the workaround is not needed anymore.
-
DrahtBot commented at 12:50 PM on June 13, 2025: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32746.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
- DrahtBot added the label Tests on Jun 13, 2025
- theStack renamed this:
test: remove unnecessary m_best_header setting hack in feature_assume_utxo.py
test: remove unnecessary m_best_header setting hack in feature_assumeutxo.py
on Jun 13, 2025 -
fjahr commented at 2:16 PM on June 13, 2025: contributor
ACK 206bc05e62c6a71c328eaab90fd865f46328642f
-
janb84 commented at 2:26 PM on June 13, 2025: contributor
ACK 206bc05e62c6a71c328eaab90fd865f46328642f
The issue is resolved, the "hack" is not needed anymore.
- Validated that the test still runs / passed ✅
-
mzumsande commented at 2:37 PM on June 13, 2025: contributor
utACK 206bc05e62c6a71c328eaab90fd865f46328642f
- fanquake merged this on Jun 13, 2025
- fanquake closed this on Jun 13, 2025
- theStack deleted the branch on Jun 13, 2025
- bitcoin deleted a comment on Jun 13, 2025
