rpc, doc: clarify watch-only wallets balances in RPCHelp #32761

pull rkrux wants to merge 1 commits into bitcoin:master from rkrux:watchonly-balance changing 1 files +4 −2
  1. rkrux commented at 11:58 am on June 16, 2025: contributor
    The watch-only behaviour is per-wallet level in the descriptor wallets (the only kind of wallets now). The docs of the balance related RPCs seemed to be outdated to me. This patch adds a related note in both the balance related RPCS.
  2. rpc, doc: clarify watch-only wallets balances in RPCHelp
    The watch-only behaviour is per-wallet level in the descriptor
    wallets (the only kind of wallets now). The docs of the balance
    related RPCs seemed to be outdated to me. This patch adds a
    related note in both the balance related RPCS.
    220074ef09
  3. DrahtBot commented at 11:58 am on June 16, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32761.

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

  4. rkrux commented at 12:03 pm on June 16, 2025: contributor

    Essentially I want to convey the message that the watch-only wallets need not (read cannot) have corresponding private keys for the unspent outputs and thus they are not factored in the balance calculation.

    I’m open to changing the verbiage in the RPC docs if someone has a better suggestion.

  5. rkrux commented at 12:14 pm on June 16, 2025: contributor

    MSan, dependsFailing after 11s — Task Summary

    This failure seems unrelated to me as per the error messages from the CI run.

    0[07:58:31.196] Error: creating container storage: the container name "ci_native_msan" is already in use by a8395f5207b2bee3eff8c9392096e3e535820dcc96f5ced45dfe4256a1f6488b. You have to remove that container to be able to reuse that name: that name is already in use by an external entity, or use --replace to instruct Podman to do so.
    1[07:58:31.200] + CI_CONTAINER_ID=
    
  6. DrahtBot added the label CI failed on Jun 17, 2025
  7. DrahtBot removed the label CI failed on Jun 17, 2025
  8. maflcko added the label Docs on Jun 17, 2025
  9. maflcko added the label Wallet on Jun 17, 2025
  10. maflcko added the label RPC/REST/ZMQ on Jun 17, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-06-18 06:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me